All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Koen Beel <koen.beel.barco@gmail.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Huang Shijie <b32955@freescale.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Ivan Djelic <ivan.djelic@parrot.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: GPMI-NAND Status?
Date: Mon, 15 Aug 2011 19:18:36 +0300	[thread overview]
Message-ID: <1313425121.8691.31.camel@sauron> (raw)
In-Reply-To: <20040.45443.810005.525431@ipc1.ka-ro>

On Mon, 2011-08-15 at 07:41 +0200, Lothar Waßmann wrote:
> > As explained in the thread linked above, this issue should be fixed in your
> > flashing tool, _not_ in your driver. The nand device you are using does not
> > support programming pages multiple times in a row; pretending it does in the
> >
> It's not a problem of the device (Samsung K9F1G08U0B in my case)! The
> problem is that the controller generates an ECC code that is non-FF
> for all-FF data, which JFFS2 cannot handle properly.

I believe that it does not matter for the kernel community that your
specific device can survive multiple writes. I certainly does matter for
you, so if you want a quick fix - just change your kernel, but I would
not recommend to do this.

We (the community) care about the _general_ case - in general, only one
write is allowed, period. Once the JFFS2 or/and the flashing tool is
fixed - the problem will go away.

Let me put it this way - hacking the driver will just hide the issue
deeper - we'll have this issue popped up again a bit later and because
of hacks like that [1] it will be more confusing. Let's avoid this.

Also, someone pointed in that thread that if I write data to NAND - I
want my data to be ECC-protected. Please, explain why my data should be
unprotected if it happened to be just 2KiB of 0xFFs covering whole NAND
page?

Ivan provided much better explanation, showing that even with NOP 4
flashes there may be problems (e.g., 1 write of all 0xFFs + 4 writes
from the user).

[1] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037181.html

-- 
Best Regards,
Artem Bityutskiy

WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: GPMI-NAND Status?
Date: Mon, 15 Aug 2011 19:18:36 +0300	[thread overview]
Message-ID: <1313425121.8691.31.camel@sauron> (raw)
In-Reply-To: <20040.45443.810005.525431@ipc1.ka-ro>

On Mon, 2011-08-15 at 07:41 +0200, Lothar Wa?mann wrote:
> > As explained in the thread linked above, this issue should be fixed in your
> > flashing tool, _not_ in your driver. The nand device you are using does not
> > support programming pages multiple times in a row; pretending it does in the
> >
> It's not a problem of the device (Samsung K9F1G08U0B in my case)! The
> problem is that the controller generates an ECC code that is non-FF
> for all-FF data, which JFFS2 cannot handle properly.

I believe that it does not matter for the kernel community that your
specific device can survive multiple writes. I certainly does matter for
you, so if you want a quick fix - just change your kernel, but I would
not recommend to do this.

We (the community) care about the _general_ case - in general, only one
write is allowed, period. Once the JFFS2 or/and the flashing tool is
fixed - the problem will go away.

Let me put it this way - hacking the driver will just hide the issue
deeper - we'll have this issue popped up again a bit later and because
of hacks like that [1] it will be more confusing. Let's avoid this.

Also, someone pointed in that thread that if I write data to NAND - I
want my data to be ECC-protected. Please, explain why my data should be
unprotected if it happened to be just 2KiB of 0xFFs covering whole NAND
page?

Ivan provided much better explanation, showing that even with NOP 4
flashes there may be problems (e.g., 1 write of all 0xFFs + 4 writes
from the user).

[1] http://lists.infradead.org/pipermail/linux-mtd/2011-July/037181.html

-- 
Best Regards,
Artem Bityutskiy

  parent reply	other threads:[~2011-08-15 16:18 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 13:51 GPMI-NAND Status? Wolfram Sang
2011-08-05 13:51 ` Wolfram Sang
2011-08-08  6:21 ` Huang Shijie
2011-08-08  6:21   ` Huang Shijie
2011-08-08  9:19   ` Koen Beel
2011-08-08  9:19     ` Koen Beel
2011-08-08 10:37     ` Huang Shijie
2011-08-08 10:37       ` Huang Shijie
2011-08-08 12:42       ` Koen Beel
2011-08-08 12:42         ` Koen Beel
2011-08-09  6:36         ` Huang Shijie
2011-08-09  6:36           ` Huang Shijie
2011-08-09  7:58           ` Koen Beel
2011-08-09  7:58             ` Koen Beel
2011-08-09  8:18             ` Huang Shijie
2011-08-09  8:18               ` Huang Shijie
2011-08-09  8:25               ` Koen Beel
2011-08-09  8:25                 ` Koen Beel
2011-08-09  5:11     ` Huang Shijie
2011-08-09  5:11       ` Huang Shijie
2011-08-09  6:25       ` Koen Beel
2011-08-09  6:25         ` Koen Beel
2011-08-09  6:40         ` Huang Shijie
2011-08-09  6:40           ` Huang Shijie
2011-08-09  9:45     ` Wolfram Sang
2011-08-09  9:45       ` Wolfram Sang
2011-08-09  9:35   ` Wolfram Sang
2011-08-09  9:35     ` Wolfram Sang
2011-08-09 10:54     ` Huang Shijie
2011-08-09 10:54       ` Huang Shijie
2011-08-09 20:42       ` Wolfram Sang
2011-08-09 20:42         ` Wolfram Sang
2011-08-08  9:12 ` Huang Shijie
2011-08-08  9:12   ` Huang Shijie
2011-08-09  9:19   ` Wolfram Sang
2011-08-09  9:19     ` Wolfram Sang
2011-08-09 10:41     ` Huang Shijie
2011-08-09 10:41       ` Huang Shijie
2011-08-09 11:36       ` Lothar Waßmann
2011-08-09 11:36         ` Lothar Waßmann
2011-08-14  8:11 ` Ivan Djelic
2011-08-14  8:11   ` Ivan Djelic
2011-08-14 18:31   ` Wolfram Sang
2011-08-14 18:31     ` Wolfram Sang
2011-08-15  5:41   ` Lothar Waßmann
2011-08-15  5:41     ` Lothar Waßmann
2011-08-15  6:30     ` Lin Tony-B19295
2011-08-15  6:30       ` Lin Tony-B19295
2011-08-15  8:41       ` Ivan Djelic
2011-08-15  8:41         ` Ivan Djelic
2011-08-15  8:29     ` Ivan Djelic
2011-08-15  8:29       ` Ivan Djelic
2011-08-15  9:31       ` Lothar Waßmann
2011-08-15  9:31         ` Lothar Waßmann
2011-08-15 12:54         ` Ivan Djelic
2011-08-15 12:54           ` Ivan Djelic
2011-08-15 13:37           ` Lothar Waßmann
2011-08-15 13:37             ` Lothar Waßmann
2011-08-15 16:34         ` Artem Bityutskiy
2011-08-15 16:34           ` Artem Bityutskiy
2011-08-15 16:18     ` Artem Bityutskiy [this message]
2011-08-15 16:18       ` Artem Bityutskiy
2011-08-15 16:22   ` Artem Bityutskiy
2011-08-15 16:22     ` Artem Bityutskiy
2011-08-15 16:57     ` Ivan Djelic
2011-08-15 16:57       ` Ivan Djelic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313425121.8691.31.camel@sauron \
    --to=dedekind1@gmail.com \
    --cc=LW@KARO-electronics.de \
    --cc=b32955@freescale.com \
    --cc=ivan.djelic@parrot.com \
    --cc=koen.beel.barco@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shawn.guo@linaro.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.