From: bhutchings@solarflare.com (Ben Hutchings)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] af_packet: flush complete kernel cache in packet_sendmsg
Date: Fri, 02 Sep 2011 14:46:17 +0100 [thread overview]
Message-ID: <1314971179.3092.159.camel@deadeye> (raw)
In-Reply-To: <1314961686-30870-1-git-send-email-phil.sutter@viprinet.com>
On Fri, 2011-09-02 at 13:08 +0200, Phil Sutter wrote:
> This flushes the cache before and after accessing the mmapped packet
> buffer. It seems like the call to flush_dcache_page from inside
> __packet_get_status is not enough on Kirkwood (or ARM in general).
> ---
> I know this is far from an optimal solution, but it's in fact the only working
> one I found.
[...]
This is ridiculous. If flush_dcache_page() isn't doing everything it
should, you need to fix that.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Hutchings <bhutchings@solarflare.com>
To: Phil Sutter <phil.sutter@viprinet.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] af_packet: flush complete kernel cache in packet_sendmsg
Date: Fri, 02 Sep 2011 14:46:17 +0100 [thread overview]
Message-ID: <1314971179.3092.159.camel@deadeye> (raw)
In-Reply-To: <1314961686-30870-1-git-send-email-phil.sutter@viprinet.com>
On Fri, 2011-09-02 at 13:08 +0200, Phil Sutter wrote:
> This flushes the cache before and after accessing the mmapped packet
> buffer. It seems like the call to flush_dcache_page from inside
> __packet_get_status is not enough on Kirkwood (or ARM in general).
> ---
> I know this is far from an optimal solution, but it's in fact the only working
> one I found.
[...]
This is ridiculous. If flush_dcache_page() isn't doing everything it
should, you need to fix that.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-09-02 13:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 13:06 ARM, AF_PACKET: caching problems on Marvell Kirkwood Phil Sutter
2011-04-08 13:06 ` Phil Sutter
2011-05-05 14:11 ` Phil Sutter
2011-05-05 14:11 ` Phil Sutter
2011-05-05 14:56 ` Eric Dumazet
2011-05-05 14:56 ` Eric Dumazet
2011-05-06 16:12 ` Phil Sutter
2011-05-06 16:12 ` Phil Sutter
2011-05-05 19:46 ` Andrew Lunn
2011-05-05 19:46 ` Andrew Lunn
2011-05-06 16:17 ` Phil Sutter
2011-05-06 16:17 ` Phil Sutter
2011-05-09 8:59 ` Phil Sutter
2011-05-09 8:59 ` Phil Sutter
2011-05-25 10:32 ` Phil Sutter
2011-05-25 10:32 ` Phil Sutter
2011-09-02 11:08 ` [PATCH] af_packet: flush complete kernel cache in packet_sendmsg Phil Sutter
2011-09-02 11:08 ` Phil Sutter
2011-09-02 13:46 ` Ben Hutchings [this message]
2011-09-02 13:46 ` Ben Hutchings
2011-09-02 13:59 ` Phil Sutter
2011-09-02 13:59 ` Phil Sutter
2011-09-02 17:28 ` Russell King - ARM Linux
2011-09-02 17:28 ` Russell King - ARM Linux
2011-09-05 19:57 ` Phil Sutter
2011-09-05 19:57 ` Phil Sutter
2011-09-06 9:57 ` Russell King - ARM Linux
2011-09-06 9:57 ` Russell King - ARM Linux
2011-09-06 11:05 ` Phil Sutter
2011-09-06 11:05 ` Phil Sutter
[not found] ` <D3F292ADF945FB49B35E96C94C2061B90A239361@nsmail.netscout.com>
2011-09-02 14:00 ` FW: " chetan loke
2011-09-02 14:00 ` chetan loke
2011-09-02 15:31 ` Phil Sutter
2011-09-02 15:31 ` Phil Sutter
2011-09-02 16:49 ` chetan loke
2011-09-02 16:49 ` chetan loke
2011-09-06 9:44 ` Phil Sutter
2011-09-06 9:44 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314971179.3092.159.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.