* [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features
@ 2011-09-09 0:22 Marek Vasut
2011-09-09 7:52 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2011-09-09 0:22 UTC (permalink / raw)
To: qemu-devel; +Cc: dbaryshkov, Marek Vasut
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
target-arm/helper.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 58cd99f..2f3e937 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
env->cp15.c0_cpuid = id;
switch (id) {
case ARM_CPUID_ARM7TDMI:
+ set_feature(env, ARM_FEATURE_V4T);
// set_feature(env, ARM_FEATURE_ABORT_BU);
// set_feature(env, ARM_FEATURE_NO_CP15);
break;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features
2011-09-09 0:22 [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features Marek Vasut
@ 2011-09-09 7:52 ` Peter Maydell
2011-09-09 9:06 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2011-09-09 7:52 UTC (permalink / raw)
To: Marek Vasut; +Cc: dbaryshkov, qemu-devel
On 9 September 2011 01:22, Marek Vasut <marek.vasut@gmail.com> wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> target-arm/helper.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 58cd99f..2f3e937 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
> env->cp15.c0_cpuid = id;
> switch (id) {
> case ARM_CPUID_ARM7TDMI:
> + set_feature(env, ARM_FEATURE_V4T);
> // set_feature(env, ARM_FEATURE_ABORT_BU);
> // set_feature(env, ARM_FEATURE_NO_CP15);
> break;
Did you mean to send this as part of a patch series or something?
Upstream qemu doesn't have any support for ARM7TDMI (and in particular
doesn't even define ARM_CPUID_ARM7TDMI), so this patch obviously
applies on top of something else...
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features
2011-09-09 7:52 ` Peter Maydell
@ 2011-09-09 9:06 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2011-09-09 9:06 UTC (permalink / raw)
To: Peter Maydell; +Cc: dbaryshkov, qemu-devel
On Friday, September 09, 2011 09:52:42 AM Peter Maydell wrote:
> On 9 September 2011 01:22, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > target-arm/helper.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/target-arm/helper.c b/target-arm/helper.c
> > index 58cd99f..2f3e937 100644
> > --- a/target-arm/helper.c
> > +++ b/target-arm/helper.c
> > @@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env,
> > uint32_t id) env->cp15.c0_cpuid = id;
> > switch (id) {
> > case ARM_CPUID_ARM7TDMI:
> > + set_feature(env, ARM_FEATURE_V4T);
> > // set_feature(env, ARM_FEATURE_ABORT_BU);
> > // set_feature(env, ARM_FEATURE_NO_CP15);
> > break;
>
> Did you mean to send this as part of a patch series or something?
> Upstream qemu doesn't have any support for ARM7TDMI (and in particular
> doesn't even define ARM_CPUID_ARM7TDMI), so this patch obviously
> applies on top of something else...
Ah damn, I just realized I have it on top of a patchset from some other person.
I'll continue cleaning up the patchset, then submit the whole thing. Please
ignore this one.
Cheers
>
> -- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-09 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 0:22 [Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features Marek Vasut
2011-09-09 7:52 ` Peter Maydell
2011-09-09 9:06 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.