Re: [PATCH] Fix includes for userspace tools and libraries (and possible security issue)

[Guido Trentalancia <guido@trentalancia.com>]

On Tue, 2011-09-13 at 16:42 -0400, Stephen Smalley wrote: 
> > Personally, I'd like to see just 'make' at the top level dir build
> > properly and I think your patches get us most of the way there without
> > (further) breaking the building method that sds prefers.
> > 
> > If you get your best patch which does nothing but allow us to just type
> > 'make' at the top level dir and it builds everything properly in place,
> > I'll review and probably commit such a patch.
> 
> Be sure to test at least the following scenarios:
> 1) No sepol/selinux/semanage system headers installed on build host,

I've tested this when creating any of the previous patches. It is
important if Eric and/or somebody else could test it again
independently.

> 2) Old/incompatible sepol/selinux/semanage system headers installed on
> build host (e.g. f14 build host, latest selinux git tree),

This was the original motivation for creating the patch and as such it
has obviously been tested, at least on my system. It is important if
Eric and/or somebody else could test it again independently.

> 3) Ability to build each component separately without the rest of the
> source tree, e.g. package rebuilds.

I have never specifically tested this. But it is supposed to work at
least until the SUBDIR order is respected.

> The make DESTDIR=~/out install approach enabled the first two to work
> without breaking the third, which is why it was attractive.  If he can
> make all three work via another mechanism, then I'm fine with it.

After applying the patch, it should be possible to use "make
DESTDIR=~/out" to build and "make DESTDIR=~/out install" to install it
as a special case of passing special environment variables to the
Makefiles.

If previously it was ever possible to build and install at the same time
by just using "make DESTDIR=~/out" (i.e. without explicitly requiring
the "install" target), it was wrong. It's probably written nowhere
specifically, but install at least about a hundred random Linux packages
and you will tell me it is wrong !

Note: it is generally preferable to prepend the environment variables to
be passed to the make process. If the variables are appended, their
value cannot be changed or manipulated by the Makefile(s). Very often
the Makefiles need to manipulate (for example, conditional append) the
value of some environment variable (for example, CFLAGS).

Regards,

Guido


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.