Re: [PATCH] Fix function arguments in libsemanage tests (was Re: [PATCH v4] Fix includes for userspace tools and libraries)

[Eric Paris <eparis@redhat.com>]

On Wed, 2011-09-14 at 01:33 +0200, Guido Trentalancia wrote:
> Another possible improvement could be as follows (libsemanag):
> 
> Fix a few calls to semanage_store_access_check() in the libsemanage
> tests so that a void function is called.

Please in the future include a line which looks something like the
following at the end of the comments with all patches you wish to have
committed:

Signed-off-by: Guido Trentalancia <guido@trentalancia.com>

The purpose of this line is to indicate that you have the rights to
contribute this code to the project and that you agree to license the
code according to the license(s) of the file(s) that the patch will be
applied to.

I prefer patches in the format like the linux kernel: 
https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches

Basically that entails the subject line of the e-mail is the short
description of the patch (nothing extra except inside the [])

The body should be a complete description of what change you made and in
particular why.  You should mention testing and things like that as
well.

The signed-off-by line.
The last line of the changelog should be just --- (at the beginning of
the line)

After the --- line include the patch.

thanks so much!

-Eric


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.