Re: [PATCH v5] Fix includes for userspace tools and libraries (and possible security issue)

[Guido Trentalancia <guido@trentalancia.com>]

Hello Stephen.

On Thu, 2011-09-15 at 12:35 -0400, Stephen Smalley wrote:
> On Thu, 2011-09-15 at 18:04 +0200, Guido Trentalancia wrote:
> > which results in an error caused by wrong compiler link flags being used
> > by the current SELinux userspace build system (wrong shared library path
> > to be more precise, i.e. wrong path after -L flag):
> > 
> > ...
> > make -C src install
> > make[2]: Entering directory
> > `/usr/src/selinux-userspace/git/selinux-test/libsemanage/src'
> > cc -O3 -march=corei7 -mtune=corei7 -fPIC -I../include
> > -I/opt/out/usr/include -D_GNU_SOURCE   -shared -o libsemanage.so.1
> > utilities.lo user_extra_record.lo modules.lo boolean_record.lo
> > ports_file.lo interfaces_file.lo interfaces_local.lo seuser_record.lo
> > user_base_record.lo booleans_file.lo genhomedircon.lo fcontexts_file.lo
> > booleans_local.lo database_llist.lo parse_utils.lo nodes_policydb.lo
> > policy_components.lo users_extra_file.lo debug.lo fcontext_record.lo
> > database_file.lo seusers_file.lo fcontexts_local.lo ports_local.lo
> > direct_api.lo seusers_local.lo context_record.lo nodes_file.lo
> > port_record.lo users_base_policydb.lo semanage_store.lo
> > users_base_file.lo fcontexts_policy.lo booleans_activedb.lo
> > users_policy.lo handle.lo booleans_policydb.lo nodes_local.lo
> > interfaces_policy.lo database.lo users_local.lo ports_policy.lo
> > booleans_active.lo nodes_policy.lo booleans_policy.lo users_join.lo
> > user_record.lo seusers_policy.lo database_join.lo database_activedb.lo
> > ports_policydb.lo interfaces_policydb.lo database_policydb.lo
> > iface_record.lo node_record.lo conf-scan.lo conf-parse.lo -lsepol
> > -lselinux -lbz2 -lustr -L/usr/lib64/
> > -Wl,-soname,libsemanage.so.1,--version-script=libsemanage.map,-z,defs
> > /usr/lib/gcc/x86_64-unknown-linux-gnu/4.6.1/../../../../x86_64-unknown-linux-gnu/bin/ld: /usr/lib64//libselinux.a(selinux_config.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
> > /usr/lib64//libselinux.a: could not read symbols: Bad value
> > collect2: ld returned 1 exit status
> > make[2]: *** [libsemanage.so.1] Error 1
> > make[2]: Leaving directory
> > `/usr/src/selinux-userspace/git/selinux-test/libsemanage/src'
> > make[1]: *** [install] Error 2
> > make[1]: Leaving directory
> > `/usr/src/selinux-userspace/git/selinux-test/libsemanage'
> > make: *** [install] Error 1
> > 
> > It is sourcing dynamic libraries from /usr/lib64 or in other words from
> > LIBDIR, while you would expect it to source dynamic libraries
> > from /opt/out/usr/lib64 (or ~/out/usr/lib64 for the lucky ones that have
> > the tilde on their keyboard).
> 
> Is that with your patched tree?  

Nope, with original from git.

With my patch everything works all right. Otherwise why did I create the
patch in the first place ??

> Because I don't get that error, and it
> doesn't make sense based on my reading of the current
> libsemanage/src/Makefile and how it sets LIBDIR based on DESTDIR.

I only forgot to mention the flags that I used:

CFLAGS="-O3 -march=corei7 -mtune=corei7" LIBDIR=/usr/lib64
SHLIBDIR=/usr/lib64 DESTDIR=/opt/out make install

Regards,

Guido


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.