[PATCH 5/6] leases: break leases on any attribute modification

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-nfs@vger.kernel.org, samba-technical@lists.samba.org,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 5/6] leases: break leases on any attribute modification
Date: Wed, 21 Sep 2011 10:58:16 -0400	[thread overview]
Message-ID: <1316617097-21384-6-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1316617097-21384-1-git-send-email-bfields@redhat.com>

NFSv4 uses leases to guarantee that clients can cash metadata as well as
data.

(I suspect the same is true for Samba.)

This covers chmod, chown, etc.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/attr.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/attr.c b/fs/attr.c
index 538e279..4ce31cb 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -231,6 +231,9 @@ int notify_change(struct dentry * dentry, struct iattr * attr)
 	error = security_inode_setattr(dentry, attr);
 	if (error)
 		return error;
+	error = break_lease(inode, O_WRONLY);
+	if (error)
+		return error;
 
 	if (inode->i_op->setattr)
 		error = inode->i_op->setattr(dentry, attr);
-- 
1.7.4.1

WARNING: multiple messages have this Message-ID (diff)

From: "J. Bruce Fields" <bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
	Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	Mimi Zohar
	<zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	"J. Bruce Fields"
	<bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 5/6] leases: break leases on any attribute modification
Date: Wed, 21 Sep 2011 10:58:16 -0400	[thread overview]
Message-ID: <1316617097-21384-6-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1316617097-21384-1-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

NFSv4 uses leases to guarantee that clients can cash metadata as well as
data.

(I suspect the same is true for Samba.)

This covers chmod, chown, etc.

Signed-off-by: J. Bruce Fields <bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 fs/attr.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/attr.c b/fs/attr.c
index 538e279..4ce31cb 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -231,6 +231,9 @@ int notify_change(struct dentry * dentry, struct iattr * attr)
 	error = security_inode_setattr(dentry, attr);
 	if (error)
 		return error;
+	error = break_lease(inode, O_WRONLY);
+	if (error)
+		return error;
 
 	if (inode->i_op->setattr)
 		error = inode->i_op->setattr(dentry, attr);
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2011-09-21 14:58 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 14:58 breaking leases on metadata changes J. Bruce Fields
2011-09-21 14:58 ` [PATCH 1/6] leases: split up generic_setlease into lock/unlock cases J. Bruce Fields
2011-09-21 14:58   ` J. Bruce Fields
2011-09-22 17:16   ` Mimi Zohar
2011-09-22 17:16     ` Mimi Zohar
2011-09-23 18:57     ` J. Bruce Fields
2011-09-23 18:57       ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 2/6] leases: fix write-open/read-lease race J. Bruce Fields
2011-09-21 15:01   ` J. Bruce Fields
2011-09-22 17:17     ` Mimi Zohar
2011-09-22 17:17       ` Mimi Zohar
2011-10-10 21:59   ` J. Bruce Fields
2011-10-10 21:59     ` J. Bruce Fields
2011-10-11  6:19     ` Need information about the net ads user command Pankaj Baranwal
2011-10-11  6:19       ` Pankaj Baranwal
2011-10-28  8:46     ` [PATCH 2/6] leases: fix write-open/read-lease race J. Bruce Fields
2011-10-28  8:46       ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 3/6] leases: break read leases on unlink J. Bruce Fields
2011-09-21 15:02   ` Christoph Hellwig
2011-09-21 15:02     ` Christoph Hellwig
2011-09-21 17:41     ` J. Bruce Fields
2011-09-21 17:41       ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 4/6] leases: break read leases on rename J. Bruce Fields
2011-09-22 17:17   ` Mimi Zohar
2011-09-22 17:17     ` Mimi Zohar
2011-09-23 16:55     ` J. Bruce Fields
2011-09-23 16:55       ` J. Bruce Fields
2011-09-23 18:55       ` J. Bruce Fields
2011-09-23 18:55         ` J. Bruce Fields
2011-09-23 19:58       ` Mimi Zohar
2011-09-23 20:13         ` J. Bruce Fields
2011-09-23 20:13           ` J. Bruce Fields
2011-09-21 14:58 ` J. Bruce Fields [this message]
2011-09-21 14:58   ` [PATCH 5/6] leases: break leases on any attribute modification J. Bruce Fields
2011-09-21 15:35   ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 6/6] leases: break read leases on link J. Bruce Fields
2011-09-24 18:36 ` breaking leases on metadata changes Stefan (metze) Metzmacher
2011-09-24 18:36   ` Stefan (metze) Metzmacher
2011-09-26 14:10   ` J. Bruce Fields
2011-09-26 16:16     ` J. Bruce Fields
2011-09-26 16:16       ` J. Bruce Fields

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:538e279 dfblob:4ce31cb dfblob:538e279 dfblob:4ce31cb )
 OR (
bs:"[PATCH 5/6] leases: break leases on any attribute modification" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316617097-21384-6-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.