From: "Stefan (metze) Metzmacher" <metze@samba.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-nfs@vger.kernel.org, samba-technical@lists.samba.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: breaking leases on metadata changes
Date: Sat, 24 Sep 2011 20:36:04 +0200 [thread overview]
Message-ID: <4E7E2314.6000101@samba.org> (raw)
In-Reply-To: <1316617097-21384-1-git-send-email-bfields@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
Hi Bruce,
> So there's this longstanding problem that read leases should really be
> broken on anything that changes an inode's metadata or any change to the
> set of links pointing to the inode.
>
> (Cc'ing samba-technical for confirmation of that statement from Samba's
> point of view....)
>
> So we need mutual exclusion between read leases and link, unlink,
> rename, etc.
As far as I know oplocks in SMB only care about content
and attribute only opens (without the READ/WRITE access bits) doesn't
break oplocks.
So changing the modification time of a file should not break the oplock.
I think link and rename doesn't break oplocks, while unlink would.
But Samba requirements may change for SMB 2.2 support with directory leases.
We're currently exploring what the details are.
metze
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Stefan (metze) Metzmacher" <metze@samba.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, samba-technical@lists.samba.org,
linux-nfs@vger.kernel.org, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: breaking leases on metadata changes
Date: Sat, 24 Sep 2011 20:36:04 +0200 [thread overview]
Message-ID: <4E7E2314.6000101@samba.org> (raw)
In-Reply-To: <1316617097-21384-1-git-send-email-bfields@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
Hi Bruce,
> So there's this longstanding problem that read leases should really be
> broken on anything that changes an inode's metadata or any change to the
> set of links pointing to the inode.
>
> (Cc'ing samba-technical for confirmation of that statement from Samba's
> point of view....)
>
> So we need mutual exclusion between read leases and link, unlink,
> rename, etc.
As far as I know oplocks in SMB only care about content
and attribute only opens (without the READ/WRITE access bits) doesn't
break oplocks.
So changing the modification time of a file should not break the oplock.
I think link and rename doesn't break oplocks, while unlink would.
But Samba requirements may change for SMB 2.2 support with directory leases.
We're currently exploring what the details are.
metze
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-09-24 18:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 14:58 breaking leases on metadata changes J. Bruce Fields
2011-09-21 14:58 ` [PATCH 1/6] leases: split up generic_setlease into lock/unlock cases J. Bruce Fields
2011-09-21 14:58 ` J. Bruce Fields
2011-09-22 17:16 ` Mimi Zohar
2011-09-22 17:16 ` Mimi Zohar
2011-09-23 18:57 ` J. Bruce Fields
2011-09-23 18:57 ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 2/6] leases: fix write-open/read-lease race J. Bruce Fields
2011-09-21 15:01 ` J. Bruce Fields
2011-09-22 17:17 ` Mimi Zohar
2011-09-22 17:17 ` Mimi Zohar
2011-10-10 21:59 ` J. Bruce Fields
2011-10-10 21:59 ` J. Bruce Fields
2011-10-11 6:19 ` Need information about the net ads user command Pankaj Baranwal
2011-10-11 6:19 ` Pankaj Baranwal
2011-10-28 8:46 ` [PATCH 2/6] leases: fix write-open/read-lease race J. Bruce Fields
2011-10-28 8:46 ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 3/6] leases: break read leases on unlink J. Bruce Fields
2011-09-21 15:02 ` Christoph Hellwig
2011-09-21 15:02 ` Christoph Hellwig
2011-09-21 17:41 ` J. Bruce Fields
2011-09-21 17:41 ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 4/6] leases: break read leases on rename J. Bruce Fields
2011-09-22 17:17 ` Mimi Zohar
2011-09-22 17:17 ` Mimi Zohar
2011-09-23 16:55 ` J. Bruce Fields
2011-09-23 16:55 ` J. Bruce Fields
2011-09-23 18:55 ` J. Bruce Fields
2011-09-23 18:55 ` J. Bruce Fields
2011-09-23 19:58 ` Mimi Zohar
2011-09-23 20:13 ` J. Bruce Fields
2011-09-23 20:13 ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 5/6] leases: break leases on any attribute modification J. Bruce Fields
2011-09-21 14:58 ` J. Bruce Fields
2011-09-21 15:35 ` J. Bruce Fields
2011-09-21 14:58 ` [PATCH 6/6] leases: break read leases on link J. Bruce Fields
2011-09-24 18:36 ` Stefan (metze) Metzmacher [this message]
2011-09-24 18:36 ` breaking leases on metadata changes Stefan (metze) Metzmacher
2011-09-26 14:10 ` J. Bruce Fields
2011-09-26 16:16 ` J. Bruce Fields
2011-09-26 16:16 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7E2314.6000101@samba.org \
--to=metze@samba.org \
--cc=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.