From: Artem Bityutskiy <dedekind1@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] mtd: Add DiskOnChip G3 support
Date: Tue, 27 Sep 2011 15:58:37 +0300 [thread overview]
Message-ID: <1317128326.6207.30.camel@sauron> (raw)
In-Reply-To: <1316805250-11105-1-git-send-email-robert.jarzmik@free.fr>
On Fri, 2011-09-23 at 21:14 +0200, Robert Jarzmik wrote:
> Add support for DiskOnChip G3 chips. The support is quite
> limited yet :
> - no flash writes/erases are implemented
> - ECC fixes are not implemented
> - powerdown is not implemented
> - IPL handling is not yet done
>
> On the brighter side, the chip reading does work.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Sparse complains:
[dedekind@sauron l2-mtd-2.6 (master)]$ make C=1
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHECK drivers/mtd/devices/docg3.c
drivers/mtd/devices/docg3.h:217:21: error: dubious one-bit signed bitfield
And indeed:
int device_id:4;
int if_cfg:1;
should be unsigned int bit-fields, not signed.
--
Best Regards,
Artem Bityutskiy
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] mtd: Add DiskOnChip G3 support
Date: Tue, 27 Sep 2011 15:58:37 +0300 [thread overview]
Message-ID: <1317128326.6207.30.camel@sauron> (raw)
In-Reply-To: <1316805250-11105-1-git-send-email-robert.jarzmik@free.fr>
On Fri, 2011-09-23 at 21:14 +0200, Robert Jarzmik wrote:
> Add support for DiskOnChip G3 chips. The support is quite
> limited yet :
> - no flash writes/erases are implemented
> - ECC fixes are not implemented
> - powerdown is not implemented
> - IPL handling is not yet done
>
> On the brighter side, the chip reading does work.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Sparse complains:
[dedekind@sauron l2-mtd-2.6 (master)]$ make C=1
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CHECK drivers/mtd/devices/docg3.c
drivers/mtd/devices/docg3.h:217:21: error: dubious one-bit signed bitfield
And indeed:
int device_id:4;
int if_cfg:1;
should be unsigned int bit-fields, not signed.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-09-27 12:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 19:27 [PATCH V4] mtd: Add DiskOnChip G3 support Robert Jarzmik
2011-09-21 19:27 ` Robert Jarzmik
2011-09-22 14:45 ` Artem Bityutskiy
2011-09-22 14:45 ` Artem Bityutskiy
2011-09-22 17:42 ` Robert Jarzmik
2011-09-22 17:42 ` Robert Jarzmik
2011-09-27 13:39 ` Arnd Bergmann
2011-09-27 13:39 ` Arnd Bergmann
2011-09-27 17:51 ` Robert Jarzmik
2011-09-27 17:51 ` Robert Jarzmik
2011-09-28 12:45 ` Arnd Bergmann
2011-09-28 12:45 ` Arnd Bergmann
2011-10-01 12:19 ` Robert Jarzmik
2011-10-01 12:19 ` Robert Jarzmik
2011-10-01 15:02 ` Arnd Bergmann
2011-10-01 15:02 ` Arnd Bergmann
2011-09-23 19:14 ` [PATCH V5] " Robert Jarzmik
2011-09-23 19:14 ` Robert Jarzmik
2011-09-27 12:58 ` Artem Bityutskiy [this message]
2011-09-27 12:58 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317128326.6207.30.camel@sauron \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.