From: Robert Jarzmik <robert.jarzmik@free.fr>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] mtd: Add DiskOnChip G3 support
Date: Thu, 22 Sep 2011 19:42:59 +0200 [thread overview]
Message-ID: <87mxdwiicc.fsf@free.fr> (raw)
In-Reply-To: <1316702729.4849.114.camel@sauron> (Artem Bityutskiy's message of "Thu, 22 Sep 2011 17:45:21 +0300")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> Could you please re-base your driver on top of my l2 tree and fix
> warnings 0 I get the following:
Of course.
> BTW, the next step I'd do is to try to compile it with sparse, so you
> could test this driver with sparse: Documentation/sparse.txt
OK.
>> +#define doc_flashSequence(seq) \
>> +do { \
>> + doc_dbg("doc_flashSequence: %02x " #seq "\n", DoC_Seq_##seq); \
>> + doc_writeb(DoC_Seq_##seq, DoC_FlashSequence); \
>> +} while (0)
>> +
...zip...
>
> Could you please turn these macros into 'static inline' function - this
> is one of the modern patterns of kernel programming - we try to use
> functions for better type checking.
No sorry, that I cannot. If you look closely, the ##seq is not something you can
convert with an inline function, neither the #seq.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: dedekind1@gmail.com
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] mtd: Add DiskOnChip G3 support
Date: Thu, 22 Sep 2011 19:42:59 +0200 [thread overview]
Message-ID: <87mxdwiicc.fsf@free.fr> (raw)
In-Reply-To: <1316702729.4849.114.camel@sauron> (Artem Bityutskiy's message of "Thu, 22 Sep 2011 17:45:21 +0300")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> Could you please re-base your driver on top of my l2 tree and fix
> warnings 0 I get the following:
Of course.
> BTW, the next step I'd do is to try to compile it with sparse, so you
> could test this driver with sparse: Documentation/sparse.txt
OK.
>> +#define doc_flashSequence(seq) \
>> +do { \
>> + doc_dbg("doc_flashSequence: %02x " #seq "\n", DoC_Seq_##seq); \
>> + doc_writeb(DoC_Seq_##seq, DoC_FlashSequence); \
>> +} while (0)
>> +
...zip...
>
> Could you please turn these macros into 'static inline' function - this
> is one of the modern patterns of kernel programming - we try to use
> functions for better type checking.
No sorry, that I cannot. If you look closely, the ##seq is not something you can
convert with an inline function, neither the #seq.
--
Robert
next prev parent reply other threads:[~2011-09-22 17:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 19:27 [PATCH V4] mtd: Add DiskOnChip G3 support Robert Jarzmik
2011-09-21 19:27 ` Robert Jarzmik
2011-09-22 14:45 ` Artem Bityutskiy
2011-09-22 14:45 ` Artem Bityutskiy
2011-09-22 17:42 ` Robert Jarzmik [this message]
2011-09-22 17:42 ` Robert Jarzmik
2011-09-27 13:39 ` Arnd Bergmann
2011-09-27 13:39 ` Arnd Bergmann
2011-09-27 17:51 ` Robert Jarzmik
2011-09-27 17:51 ` Robert Jarzmik
2011-09-28 12:45 ` Arnd Bergmann
2011-09-28 12:45 ` Arnd Bergmann
2011-10-01 12:19 ` Robert Jarzmik
2011-10-01 12:19 ` Robert Jarzmik
2011-10-01 15:02 ` Arnd Bergmann
2011-10-01 15:02 ` Arnd Bergmann
2011-09-23 19:14 ` [PATCH V5] " Robert Jarzmik
2011-09-23 19:14 ` Robert Jarzmik
2011-09-27 12:58 ` Artem Bityutskiy
2011-09-27 12:58 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxdwiicc.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.