From: Dave Hansen <dave@linux.vnet.ibm.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rientjes@google.com, James.Bottomley@HansenPartnership.com
Subject: Re: [RFCv2][PATCH 1/4] break units out of string_get_size()
Date: Fri, 30 Sep 2011 15:46:01 -0700 [thread overview]
Message-ID: <1317422761.16137.669.camel@nimitz> (raw)
In-Reply-To: <4E8634D3.2080504@zytor.com>
On Fri, 2011-09-30 at 14:29 -0700, H. Peter Anvin wrote:
> On 09/30/2011 01:32 PM, Dave Hansen wrote:
> > diff -puN lib/string_helpers.c~string_get_size-pow2 lib/string_helpers.c
> >
> > +const char *units_10[] = { "B", "kB", "MB", "GB", "TB", "PB",
> > + "EB", "ZB", "YB", NULL};
> > +const char *units_2[] = {"B", "KiB", "MiB", "GiB", "TiB", "PiB",
> > + "EiB", "ZiB", "YiB", NULL };
>
> These names are way too generic to be public symbols.
Ack, I managed to drop the static when I broke this out for the third
time. :)
> Another thing worth thinking about is whether or not the -B suffix
> should be part of these arrays.
... or the 'i' for that matter.
I'll give it a go.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rientjes@google.com, James.Bottomley@HansenPartnership.com
Subject: Re: [RFCv2][PATCH 1/4] break units out of string_get_size()
Date: Fri, 30 Sep 2011 15:46:01 -0700 [thread overview]
Message-ID: <1317422761.16137.669.camel@nimitz> (raw)
In-Reply-To: <4E8634D3.2080504@zytor.com>
On Fri, 2011-09-30 at 14:29 -0700, H. Peter Anvin wrote:
> On 09/30/2011 01:32 PM, Dave Hansen wrote:
> > diff -puN lib/string_helpers.c~string_get_size-pow2 lib/string_helpers.c
> >
> > +const char *units_10[] = { "B", "kB", "MB", "GB", "TB", "PB",
> > + "EB", "ZB", "YB", NULL};
> > +const char *units_2[] = {"B", "KiB", "MiB", "GiB", "TiB", "PiB",
> > + "EiB", "ZiB", "YiB", NULL };
>
> These names are way too generic to be public symbols.
Ack, I managed to drop the static when I broke this out for the third
time. :)
> Another thing worth thinking about is whether or not the -B suffix
> should be part of these arrays.
... or the 'i' for that matter.
I'll give it a go.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-30 22:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 20:32 [RFCv2][PATCH 1/4] break units out of string_get_size() Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 2/4] add string_get_size_pow2() Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 3/4] add seq_print_pow2() function Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 21:29 ` [RFCv2][PATCH 1/4] break units out of string_get_size() H. Peter Anvin
2011-09-30 21:29 ` H. Peter Anvin
2011-09-30 22:46 ` Dave Hansen [this message]
2011-09-30 22:46 ` Dave Hansen
2011-09-30 22:47 ` H. Peter Anvin
2011-09-30 22:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317422761.16137.669.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.