From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
James.Bottomley@HansenPartnership.com, hpa@zytor.com,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFCv2][PATCH 2/4] add string_get_size_pow2()
Date: Fri, 30 Sep 2011 13:32:20 -0700 [thread overview]
Message-ID: <20110930203220.522ECB96@kernel> (raw)
In-Reply-To: <20110930203219.60D507CB@kernel>
This is a specialized version of string_get_size().
It only works on powers-of-two, and only outputs in
KiB/MiB/etc... Doing it this way means that we do
not have to do any division like string_get_size()
does.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/include/linux/string_helpers.h | 1
linux-2.6.git-dave/lib/string_helpers.c | 23 ++++++++++++++++++++++
2 files changed, 24 insertions(+)
diff -puN lib/string_helpers.c~string_get_size-pow2-1 lib/string_helpers.c
--- linux-2.6.git/lib/string_helpers.c~string_get_size-pow2-1 2011-09-30 12:10:31.653729703 -0700
+++ linux-2.6.git-dave/lib/string_helpers.c 2011-09-30 12:40:13.090605408 -0700
@@ -21,6 +21,29 @@ static const unsigned int divisor[] = {
[STRING_UNITS_2] = 1024,
};
+u64 string_get_size_pow2(u64 size, const char **unit_ret)
+{
+ int log2;
+ int unit_index;
+
+ if (!size)
+ log2 = 0;
+ else
+ log2 = ilog2(size);
+
+ /* KiB is log2=0->9, MiB is 10->19, etc... */
+ unit_index = log2 / 10;
+ /* Can not overflow since YiB=2^80 does
+ * not fit in a u64. */
+ *unit_ret = units_2[unit_index];
+
+ /* 512 aka 2^9 is the largest integer without
+ * overflowing to the next power-of-two, so
+ * use %10 to make it max out there */
+ return (1 << (log2 % 10));
+}
+EXPORT_SYMBOL(string_get_size_pow2);
+
/**
* string_get_size - get the size in the specified units
* @size: The size to be converted
diff -puN include/linux/string_helpers.h~string_get_size-pow2-1 include/linux/string_helpers.h
--- linux-2.6.git/include/linux/string_helpers.h~string_get_size-pow2-1 2011-09-30 12:40:21.110592191 -0700
+++ linux-2.6.git-dave/include/linux/string_helpers.h 2011-09-30 12:40:31.186575591 -0700
@@ -10,6 +10,7 @@ enum string_size_units {
STRING_UNITS_2, /* use binary powers of 2^10 */
};
+u64 string_get_size_pow2(u64 size, const char **unit_ret);
int string_get_size(u64 size, enum string_size_units units,
char *buf, int len);
_
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
James.Bottomley@HansenPartnership.com, hpa@zytor.com,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFCv2][PATCH 2/4] add string_get_size_pow2()
Date: Fri, 30 Sep 2011 13:32:20 -0700 [thread overview]
Message-ID: <20110930203220.522ECB96@kernel> (raw)
In-Reply-To: <20110930203219.60D507CB@kernel>
This is a specialized version of string_get_size().
It only works on powers-of-two, and only outputs in
KiB/MiB/etc... Doing it this way means that we do
not have to do any division like string_get_size()
does.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/include/linux/string_helpers.h | 1
linux-2.6.git-dave/lib/string_helpers.c | 23 ++++++++++++++++++++++
2 files changed, 24 insertions(+)
diff -puN lib/string_helpers.c~string_get_size-pow2-1 lib/string_helpers.c
--- linux-2.6.git/lib/string_helpers.c~string_get_size-pow2-1 2011-09-30 12:10:31.653729703 -0700
+++ linux-2.6.git-dave/lib/string_helpers.c 2011-09-30 12:40:13.090605408 -0700
@@ -21,6 +21,29 @@ static const unsigned int divisor[] = {
[STRING_UNITS_2] = 1024,
};
+u64 string_get_size_pow2(u64 size, const char **unit_ret)
+{
+ int log2;
+ int unit_index;
+
+ if (!size)
+ log2 = 0;
+ else
+ log2 = ilog2(size);
+
+ /* KiB is log2=0->9, MiB is 10->19, etc... */
+ unit_index = log2 / 10;
+ /* Can not overflow since YiB=2^80 does
+ * not fit in a u64. */
+ *unit_ret = units_2[unit_index];
+
+ /* 512 aka 2^9 is the largest integer without
+ * overflowing to the next power-of-two, so
+ * use %10 to make it max out there */
+ return (1 << (log2 % 10));
+}
+EXPORT_SYMBOL(string_get_size_pow2);
+
/**
* string_get_size - get the size in the specified units
* @size: The size to be converted
diff -puN include/linux/string_helpers.h~string_get_size-pow2-1 include/linux/string_helpers.h
--- linux-2.6.git/include/linux/string_helpers.h~string_get_size-pow2-1 2011-09-30 12:40:21.110592191 -0700
+++ linux-2.6.git-dave/include/linux/string_helpers.h 2011-09-30 12:40:31.186575591 -0700
@@ -10,6 +10,7 @@ enum string_size_units {
STRING_UNITS_2, /* use binary powers of 2^10 */
};
+u64 string_get_size_pow2(u64 size, const char **unit_ret);
int string_get_size(u64 size, enum string_size_units units,
char *buf, int len);
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-30 20:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 20:32 [RFCv2][PATCH 1/4] break units out of string_get_size() Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 20:32 ` Dave Hansen [this message]
2011-09-30 20:32 ` [RFCv2][PATCH 2/4] add string_get_size_pow2() Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 3/4] add seq_print_pow2() function Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-09-30 20:32 ` Dave Hansen
2011-09-30 21:29 ` [RFCv2][PATCH 1/4] break units out of string_get_size() H. Peter Anvin
2011-09-30 21:29 ` H. Peter Anvin
2011-09-30 22:46 ` Dave Hansen
2011-09-30 22:46 ` Dave Hansen
2011-09-30 22:47 ` H. Peter Anvin
2011-09-30 22:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930203220.522ECB96@kernel \
--to=dave@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.