* ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now
@ 2011-10-04 9:24 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2011-10-04 9:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, alsa-devel
Hi,
I just found that after commit be3ea3b9e
"SoC: Use new register map API for ASoC generic physical I/O",
snd_soc_codec_set_cache_io does not set codec->hw_write any more.
It is still used in some drivers. e.g.
In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
For the drivers that is using snd_soc_codec_set_cache_io now,
where is the place to set codec->hw_write callback now?
Regards,
Axel
^ permalink raw reply [flat|nested] 4+ messages in thread
* ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now
@ 2011-10-04 9:24 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2011-10-04 9:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, alsa-devel
Hi,
I just found that after commit be3ea3b9e
"SoC: Use new register map API for ASoC generic physical I/O",
snd_soc_codec_set_cache_io does not set codec->hw_write any more.
It is still used in some drivers. e.g.
In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
For the drivers that is using snd_soc_codec_set_cache_io now,
where is the place to set codec->hw_write callback now?
Regards,
Axel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now
2011-10-04 9:24 ` Axel Lin
@ 2011-10-04 9:51 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-10-04 9:51 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Liam Girdwood
On Tue, Oct 04, 2011 at 05:24:32PM +0800, Axel Lin wrote:
> I just found that after commit be3ea3b9e
> "SoC: Use new register map API for ASoC generic physical I/O",
> snd_soc_codec_set_cache_io does not set codec->hw_write any more.
> It is still used in some drivers. e.g.
> In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
> For the drivers that is using snd_soc_codec_set_cache_io now,
> where is the place to set codec->hw_write callback now?
These drivers should be using the standard I/O functions, probably
they're looking for the cache_bypass flag. Either that or convert to
use regmap directly.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now
@ 2011-10-04 9:51 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-10-04 9:51 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, alsa-devel
On Tue, Oct 04, 2011 at 05:24:32PM +0800, Axel Lin wrote:
> I just found that after commit be3ea3b9e
> "SoC: Use new register map API for ASoC generic physical I/O",
> snd_soc_codec_set_cache_io does not set codec->hw_write any more.
> It is still used in some drivers. e.g.
> In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
> For the drivers that is using snd_soc_codec_set_cache_io now,
> where is the place to set codec->hw_write callback now?
These drivers should be using the standard I/O functions, probably
they're looking for the cache_bypass flag. Either that or convert to
use regmap directly.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-04 9:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-04 9:24 ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now Axel Lin
2011-10-04 9:24 ` Axel Lin
2011-10-04 9:51 ` Mark Brown
2011-10-04 9:51 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.