Re: [patch 2.6.13-rc3] sis190 driver

Re: [patch 2.6.13-rc3] sis190 driver

[Pascal CHAPPERON]

> Message du 30/07/05 12:13
> De : "Francois Romieu" <romieu@fr.zoreil.com>
[...]
> Lars noticed that the link status is not correctly reported and suggested
> a few changes. Can you check if the version below works better ?
> 
I was precisely modifying mii_chip_table[] in sis190-120 to make it work ;-)

Yes, that new version works well.

#dmesg
sis190 Gigabit Ethernet driver 1.2 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
PCI: Setting latency timer of device 0000:00:04.0 to 64
0000:00:04.0: Read MAC address from APC.
eth0: Realtek PHY RTL8201 transceiver at address 1.
eth0: Using transceiver at address 1 as default.
0000:00:04.0: sis190 at ffffc20000004c00 (IRQ: 11), 00:11:2f:e9:42:70
eth0: Enabling Auto-negotiation.
eth0: mii ext = 0000.
eth0: mii lpa = c1e1 adv = 01e1.
eth0: link on 100 Mbps Full Duplex mode.

By the way,  i still can not force speed/mode/autoneg (ethtool or mii-tool); 
ethtool reports correctly the changes, but autoneg is not really disabled, 
and the driver falls back to 100 Full...

Had Lars better results with autoneg off?

-
Pascal

Re: [patch 2.6.13-rc3] sis190 driver

[Francois Romieu]

Pascal CHAPPERON <pascal.chapperon@wanadoo.fr> :
[...]
> By the way,  i still can not force speed/mode/autoneg (ethtool or mii-tool); 
> ethtool reports correctly the changes, but autoneg is not really disabled, 
> and the driver falls back to 100 Full...
> 
> Had Lars better results with autoneg off?

I doubt it. So far this is a known feature :o)

--
Ueimor

Re: [patch 2.6.13-rc3] sis190 driver

[Pascal CHAPPERON]

> Message du 29/07/05 00:13
> De : "Francois Romieu" <romieu@fr.zoreil.com>
[...]
 
> Changes from previous version (20050722)
[...]
> o Minor round of mii/phy related changes. May crash.
> 
> Testing reports/review/patches are always appreciated.
> 

sis190-120 compiles, loads but does not work (sis190_init_phy() function).

# service network start
Bringing up loopback interface:                            [  OK  ]
Bringing up interface eth0:
Determining IP information for eth0... failed; no link present.  Check cable?
                                                           [FAILED]

#dmesg
sis190 Gigabit Ethernet driver 1.2 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11
PCI: Setting latency timer of device 0000:00:04.0 to 64
0000:00:04.0: Read MAC address from APC.
eth0: Unknown PHY transceiver at address 1.
0000:00:04.0: sis190 at ffffc20000004c00 (IRQ: 11), 00:11:2f:e9:42:70
eth0: Enabling Auto-negotiation.

# ethtool eth0
Settings for eth0:
        Supported ports: [ TP MII ]
        Supported link modes:   10baseT/Half 10baseT/Full
                                100baseT/Half 100baseT/Full
        Supports auto-negotiation: Yes
        Advertised link modes:  10baseT/Half 10baseT/Full
                                100baseT/Half 100baseT/Full
        Advertised auto-negotiation: Yes
        Speed: 100Mb/s
        Duplex: Full
        Port: MII
        PHYAD: 0
        Transceiver: internal
        Auto-negotiation: on
        Current message level: 0x00000037 (55)
        Link detected: no

I reverted to sis190-110, which works well on my box.

--
Pascal

Re: [patch 2.6.13-rc3] sis190 driver

[Francois Romieu]

Pascal CHAPPERON <pascal.chapperon@wanadoo.fr> :
[...]
> sis190-120 compiles, loads but does not work (sis190_init_phy() function).
> 
> # service network start
> Bringing up loopback interface:                            [  OK  ]
> Bringing up interface eth0:
> Determining IP information for eth0... failed; no link present.  Check cable?
>                                                            [FAILED]

Thanks, your report/dmesg are welcome.

Lars noticed that the link status is not correctly reported and suggested
a few changes. Can you check if the version below works better ?

Single file patch:
http://www.zoreil.com/~romieu/sis190/20050730-2.6.13-rc4-sis190-test.patch

Patch-kit:
http://www.zoreil.com/~romieu/sis190/20050730-2.6.13-rc4/patches

Tarball:
http://www.zoreil.com/~romieu/sis190/20050730-2.6.13-rc4.tar.bz2

If it does not pass the network init, can you issue
- ifconfig eth0 blah, blah by hand
- mii-tool -vvv eth0

I'll send the whole serie of patches to netdev/akpm.

Jeff, do you want that I publish it in some git repo as well ?

--
Ueimor

[patch 2.6.13-rc3] sis190 driver

[Francois Romieu]

Single file patch:
http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3-sis190-test.patch

Patch-kit:
http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3/patches

Tarball:
http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3.tar.bz2

Changes from previous version (20050722)
o Add endian annotations (Alexey Dobriyan).

o Hopefully fixed the build of the patch.

o Minor round of mii/phy related changes. May crash.

Testing reports/review/patches are always appreciated.

Ok, now back to washing.

--
Ueimor