From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, scottwood@freescale.com,
akpm@linux-foundation.org, leoli@freescale.com,
dwmw2@infradead.org
Subject: Re: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c
Date: Fri, 18 Nov 2011 00:08:08 +0200 [thread overview]
Message-ID: <1321567690.2272.24.camel@koala> (raw)
In-Reply-To: <1321349355-1639-1-git-send-email-b35362@freescale.com>
On Tue, 2011-11-15 at 17:29 +0800, b35362@freescale.com wrote:
> From: Liu Shuo <b35362@freescale.com>
>
> fix whitespaces,tabs coding style issue and use #include <linux/io.h> instead of <asm/io.h>
> in drivers/mtd/nand/fsl_elbc.c.
>
> Signed-off-by: Liu Shuo <b35362@freescale.com>
> Signed-off-by: Li Yang <leoli@freescale.com>
Hi, It is really matter of taste whether to use only tabs for
indentations or tabs + few spaces to align nicely with the previous
line. I personally prefer the latter and dislike when people use only
tabs. But other people love tabs and use them everywhere, even like
#define\tBLAH_BLAH\tvalue, which I find ugly, but I do not mind people
using this.
So no, please, let's leave the indentation as is in this file. It is ok
to assume tab is 8 spaces in the kernel.
Artem.
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, scottwood@freescale.com,
akpm@linux-foundation.org, dwmw2@infradead.org
Subject: Re: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c
Date: Fri, 18 Nov 2011 00:08:08 +0200 [thread overview]
Message-ID: <1321567690.2272.24.camel@koala> (raw)
In-Reply-To: <1321349355-1639-1-git-send-email-b35362@freescale.com>
On Tue, 2011-11-15 at 17:29 +0800, b35362@freescale.com wrote:
> From: Liu Shuo <b35362@freescale.com>
>
> fix whitespaces,tabs coding style issue and use #include <linux/io.h> instead of <asm/io.h>
> in drivers/mtd/nand/fsl_elbc.c.
>
> Signed-off-by: Liu Shuo <b35362@freescale.com>
> Signed-off-by: Li Yang <leoli@freescale.com>
Hi, It is really matter of taste whether to use only tabs for
indentations or tabs + few spaces to align nicely with the previous
line. I personally prefer the latter and dislike when people use only
tabs. But other people love tabs and use them everywhere, even like
#define\tBLAH_BLAH\tvalue, which I find ugly, but I do not mind people
using this.
So no, please, let's leave the indentation as is in this file. It is ok
to assume tab is 8 spaces in the kernel.
Artem.
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, leoli@freescale.com,
scottwood@freescale.com
Subject: Re: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c
Date: Fri, 18 Nov 2011 00:08:08 +0200 [thread overview]
Message-ID: <1321567690.2272.24.camel@koala> (raw)
In-Reply-To: <1321349355-1639-1-git-send-email-b35362@freescale.com>
On Tue, 2011-11-15 at 17:29 +0800, b35362@freescale.com wrote:
> From: Liu Shuo <b35362@freescale.com>
>
> fix whitespaces,tabs coding style issue and use #include <linux/io.h> instead of <asm/io.h>
> in drivers/mtd/nand/fsl_elbc.c.
>
> Signed-off-by: Liu Shuo <b35362@freescale.com>
> Signed-off-by: Li Yang <leoli@freescale.com>
Hi, It is really matter of taste whether to use only tabs for
indentations or tabs + few spaces to align nicely with the previous
line. I personally prefer the latter and dislike when people use only
tabs. But other people love tabs and use them everywhere, even like
#define\tBLAH_BLAH\tvalue, which I find ugly, but I do not mind people
using this.
So no, please, let's leave the indentation as is in this file. It is ok
to assume tab is 8 spaces in the kernel.
Artem.
next prev parent reply other threads:[~2011-11-17 22:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 9:29 [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c b35362
2011-11-15 9:29 ` b35362
2011-11-15 9:29 ` b35362
2011-11-15 9:29 ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly b35362
2011-11-15 9:29 ` b35362
2011-11-15 9:29 ` b35362
2011-11-15 9:29 ` [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-15 9:29 ` b35362
2011-11-15 9:29 ` b35362
2011-11-22 21:04 ` Artem Bityutskiy
2011-11-22 21:04 ` Artem Bityutskiy
2011-11-22 21:04 ` Artem Bityutskiy
2011-11-22 23:55 ` Scott Wood
2011-11-22 23:55 ` Scott Wood
2011-11-22 23:55 ` Scott Wood
2011-11-23 1:56 ` LiuShuo
2011-11-23 1:56 ` LiuShuo
2011-11-23 1:56 ` LiuShuo
2011-11-23 12:14 ` LiuShuo
2011-11-23 12:14 ` LiuShuo
2011-11-23 12:14 ` LiuShuo
2011-11-28 21:41 ` Scott Wood
2011-11-28 21:41 ` Scott Wood
2011-11-28 21:41 ` Scott Wood
2011-11-17 22:13 ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly Artem Bityutskiy
2011-11-17 22:13 ` Artem Bityutskiy
2011-11-17 22:13 ` Artem Bityutskiy
2011-11-18 2:08 ` LiuShuo
2011-11-18 2:08 ` LiuShuo
2011-11-18 2:08 ` LiuShuo
2011-11-22 21:05 ` Artem Bityutskiy
2011-11-22 21:05 ` Artem Bityutskiy
2011-11-22 21:05 ` Artem Bityutskiy
2011-11-15 11:26 ` [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c Jenkins, Clive
2011-11-15 11:26 ` Jenkins, Clive
2011-11-15 13:10 ` David Woodhouse
2011-11-15 13:10 ` David Woodhouse
2011-11-15 14:42 ` Jenkins, Clive
2011-11-15 14:42 ` Jenkins, Clive
2011-11-15 14:42 ` Jenkins, Clive
2011-11-15 15:05 ` David Woodhouse
2011-11-15 15:05 ` David Woodhouse
2011-11-15 14:51 ` David Laight
2011-11-15 14:51 ` David Laight
2011-11-15 14:51 ` David Laight
2011-11-17 22:08 ` Artem Bityutskiy [this message]
2011-11-17 22:08 ` Artem Bityutskiy
2011-11-17 22:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321567690.2272.24.camel@koala \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=b35362@freescale.com \
--cc=dwmw2@infradead.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.