All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: Artem.Bityutskiy@nokia.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Liu Shuo <Shuo.Liu@freescale.com>,
	Shengzhou Liu <Shengzhou.Liu@freescale.com>,
	linux-mtd@lists.infradead.org, scottwood@freescale.com,
	akpm@linux-foundation.org, leoli@freescale.com,
	dwmw2@infradead.org
Subject: Re: [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Tue, 22 Nov 2011 23:04:18 +0200	[thread overview]
Message-ID: <1321995862.2222.2.camel@koala> (raw)
In-Reply-To: <1321349355-1639-3-git-send-email-b35362@freescale.com>

On Tue, 2011-11-15 at 17:29 +0800, b35362@freescale.com wrote:
> +               /*
> +                * Freescale FCM controller has a 2K size limitation of buffer
> +                * RAM, so elbc_fcm_ctrl->buffer have to be used if writesize
> +                * of chip is greater than 2048.
> +                * We malloc a large enough buffer at this point, because we
> +                * don't know writesize before calling nand_scan(). We will
> +                * re-malloc later if needed.
> +                */
> +               elbc_fcm_ctrl->buffer = kmalloc(4096 * 6, GFP_KERNEL);
> +               if (!elbc_fcm_ctrl->buffer)
> +                       return -ENOMEM; 

Why 4096*6? Judging from the comment it should be 4096.

Artem.

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: Artem.Bityutskiy@nokia.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Liu Shuo <Shuo.Liu@freescale.com>,
	Shengzhou Liu <Shengzhou.Liu@freescale.com>,
	linux-mtd@lists.infradead.org, scottwood@freescale.com,
	akpm@linux-foundation.org, dwmw2@infradead.org
Subject: Re: [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Tue, 22 Nov 2011 23:04:18 +0200	[thread overview]
Message-ID: <1321995862.2222.2.camel@koala> (raw)
In-Reply-To: <1321349355-1639-3-git-send-email-b35362@freescale.com>

On Tue, 2011-11-15 at 17:29 +0800, b35362@freescale.com wrote:
> +               /*
> +                * Freescale FCM controller has a 2K size limitation of buffer
> +                * RAM, so elbc_fcm_ctrl->buffer have to be used if writesize
> +                * of chip is greater than 2048.
> +                * We malloc a large enough buffer at this point, because we
> +                * don't know writesize before calling nand_scan(). We will
> +                * re-malloc later if needed.
> +                */
> +               elbc_fcm_ctrl->buffer = kmalloc(4096 * 6, GFP_KERNEL);
> +               if (!elbc_fcm_ctrl->buffer)
> +                       return -ENOMEM; 

Why 4096*6? Judging from the comment it should be 4096.

Artem.

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: b35362@freescale.com
Cc: dwmw2@infradead.org, Artem.Bityutskiy@nokia.com,
	linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	leoli@freescale.com, scottwood@freescale.com,
	Liu Shuo <Shuo.Liu@freescale.com>,
	Shengzhou Liu <Shengzhou.Liu@freescale.com>
Subject: Re: [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Tue, 22 Nov 2011 23:04:18 +0200	[thread overview]
Message-ID: <1321995862.2222.2.camel@koala> (raw)
In-Reply-To: <1321349355-1639-3-git-send-email-b35362@freescale.com>

On Tue, 2011-11-15 at 17:29 +0800, b35362@freescale.com wrote:
> +               /*
> +                * Freescale FCM controller has a 2K size limitation of buffer
> +                * RAM, so elbc_fcm_ctrl->buffer have to be used if writesize
> +                * of chip is greater than 2048.
> +                * We malloc a large enough buffer at this point, because we
> +                * don't know writesize before calling nand_scan(). We will
> +                * re-malloc later if needed.
> +                */
> +               elbc_fcm_ctrl->buffer = kmalloc(4096 * 6, GFP_KERNEL);
> +               if (!elbc_fcm_ctrl->buffer)
> +                       return -ENOMEM; 

Why 4096*6? Judging from the comment it should be 4096.

Artem.


  reply	other threads:[~2011-11-22 21:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  9:29 [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c b35362
2011-11-15  9:29 ` b35362
2011-11-15  9:29 ` b35362
2011-11-15  9:29 ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly b35362
2011-11-15  9:29   ` b35362
2011-11-15  9:29   ` b35362
2011-11-15  9:29   ` [PATCH v3 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-15  9:29     ` b35362
2011-11-15  9:29     ` b35362
2011-11-22 21:04     ` Artem Bityutskiy [this message]
2011-11-22 21:04       ` Artem Bityutskiy
2011-11-22 21:04       ` Artem Bityutskiy
2011-11-22 23:55     ` Scott Wood
2011-11-22 23:55       ` Scott Wood
2011-11-22 23:55       ` Scott Wood
2011-11-23  1:56       ` LiuShuo
2011-11-23  1:56         ` LiuShuo
2011-11-23  1:56         ` LiuShuo
2011-11-23 12:14       ` LiuShuo
2011-11-23 12:14         ` LiuShuo
2011-11-23 12:14         ` LiuShuo
2011-11-28 21:41         ` Scott Wood
2011-11-28 21:41           ` Scott Wood
2011-11-28 21:41           ` Scott Wood
2011-11-17 22:13   ` [PATCH 2/3] mtd/nand : set Nand flash page address to FBAR and FPAR correctly Artem Bityutskiy
2011-11-17 22:13     ` Artem Bityutskiy
2011-11-17 22:13     ` Artem Bityutskiy
2011-11-18  2:08     ` LiuShuo
2011-11-18  2:08       ` LiuShuo
2011-11-18  2:08       ` LiuShuo
2011-11-22 21:05       ` Artem Bityutskiy
2011-11-22 21:05         ` Artem Bityutskiy
2011-11-22 21:05         ` Artem Bityutskiy
2011-11-15 11:26 ` [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c Jenkins, Clive
2011-11-15 11:26   ` Jenkins, Clive
2011-11-15 13:10   ` David Woodhouse
2011-11-15 13:10     ` David Woodhouse
2011-11-15 14:42     ` Jenkins, Clive
2011-11-15 14:42       ` Jenkins, Clive
2011-11-15 14:42       ` Jenkins, Clive
2011-11-15 15:05       ` David Woodhouse
2011-11-15 15:05         ` David Woodhouse
2011-11-15 14:51     ` David Laight
2011-11-15 14:51       ` David Laight
2011-11-15 14:51       ` David Laight
2011-11-17 22:08 ` Artem Bityutskiy
2011-11-17 22:08   ` Artem Bityutskiy
2011-11-17 22:08   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321995862.2222.2.camel@koala \
    --to=dedekind1@gmail.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=Shengzhou.Liu@freescale.com \
    --cc=Shuo.Liu@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=b35362@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=leoli@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.