* [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls
@ 2011-11-19 6:41 Axel Lin
2011-11-19 7:59 ` Alexander Sverdlin
2011-11-20 20:58 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-11-19 6:41 UTC (permalink / raw)
To: alsa-devel
Cc: H Hartley Sweeten, Mark Brown, Alexander Sverdlin, Liam Girdwood
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/cs4271.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index 23d1bd5..69fde15 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -434,7 +434,8 @@ static int cs4271_soc_suspend(struct snd_soc_codec *codec, pm_message_t mesg)
{
int ret;
/* Set power-down bit */
- ret = snd_soc_update_bits(codec, CS4271_MODE2, 0, CS4271_MODE2_PDN);
+ ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN,
+ CS4271_MODE2_PDN);
if (ret < 0)
return ret;
return 0;
@@ -501,8 +502,9 @@ static int cs4271_probe(struct snd_soc_codec *codec)
return ret;
}
- ret = snd_soc_update_bits(codec, CS4271_MODE2, 0,
- CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
+ ret = snd_soc_update_bits(codec, CS4271_MODE2,
+ CS4271_MODE2_PDN | CS4271_MODE2_CPEN,
+ CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
if (ret < 0)
return ret;
ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, 0);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls
2011-11-19 6:41 [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls Axel Lin
@ 2011-11-19 7:59 ` Alexander Sverdlin
2011-11-20 20:58 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Sverdlin @ 2011-11-19 7:59 UTC (permalink / raw)
To: Axel Lin; +Cc: H Hartley Sweeten, alsa-devel, Mark Brown, Liam Girdwood
Hello!
According to changes in API, fix is correct.
Acked-by: Alexander Sverdlin <subaparts@yandex.ru>
On Sat, 2011-11-19 at 14:41 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/cs4271.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
> index 23d1bd5..69fde15 100644
> --- a/sound/soc/codecs/cs4271.c
> +++ b/sound/soc/codecs/cs4271.c
> @@ -434,7 +434,8 @@ static int cs4271_soc_suspend(struct snd_soc_codec *codec, pm_message_t mesg)
> {
> int ret;
> /* Set power-down bit */
> - ret = snd_soc_update_bits(codec, CS4271_MODE2, 0, CS4271_MODE2_PDN);
> + ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN,
> + CS4271_MODE2_PDN);
> if (ret < 0)
> return ret;
> return 0;
> @@ -501,8 +502,9 @@ static int cs4271_probe(struct snd_soc_codec *codec)
> return ret;
> }
>
> - ret = snd_soc_update_bits(codec, CS4271_MODE2, 0,
> - CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
> + ret = snd_soc_update_bits(codec, CS4271_MODE2,
> + CS4271_MODE2_PDN | CS4271_MODE2_CPEN,
> + CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
> if (ret < 0)
> return ret;
> ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, 0);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls
2011-11-19 6:41 [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls Axel Lin
2011-11-19 7:59 ` Alexander Sverdlin
@ 2011-11-20 20:58 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-11-20 20:58 UTC (permalink / raw)
To: Axel Lin; +Cc: H Hartley Sweeten, alsa-devel, Alexander Sverdlin, Liam Girdwood
On Sat, Nov 19, 2011 at 02:41:07PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-20 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-19 6:41 [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls Axel Lin
2011-11-19 7:59 ` Alexander Sverdlin
2011-11-20 20:58 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.