All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Chris Ball <cjb@laptop.org>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] omap: board-sdp4430: declare support for MMC_PM_KEEP_POWER
Date: Mon, 28 Nov 2011 12:18:10 +0200	[thread overview]
Message-ID: <1322475490.6502.56.camel@cumari> (raw)
In-Reply-To: <CAB3XZEfS4XN8sXf=r6s2cqOMnsSwLBsRLva61bQK4R-ZZnHPsA@mail.gmail.com>

On Mon, 2011-11-28 at 12:12 +0200, Eliad Peller wrote: 
> On Mon, Nov 28, 2011 at 11:58 AM, Luciano Coelho <coelho@ti.com> wrote:
> > On Mon, 2011-11-28 at 11:26 +0200, Igor Grinberg wrote:
> >> On 11/28/11 11:08, Luciano Coelho wrote:
> >> > I may do it for panda later on, if I get the time to test it.  For
> >> > beagle, it doesn't really apply, because the wl12xx support is
> >> > out-of-tree, unfortunately. :(
> >>
> >> If I understood correctly, you want to change all the
> >> board files supporting the wl12xx wifi chip to have this
> >> capability set, right?
> >> Isn't this immediately affects the power consumption in
> >> sleep state?
> >> Shouldn't this be runtime controllable?
> >> I bet there are many applications that do not care about WoW,
> >> but do care about the power consumption.
> >> How does this change affect them?
> >
> > Good point, I don't know. :) Probably Eliad has the answer for that.
> >
> see the discussion regarding patch [2/3] - we only declare here
> support for this capability, but it's disabled by default.

Great, thanks! :) I now also understand the difference between the
pm_flags and pm_caps. :)

So, back to where we started, we should add the capability to all boards
that define the MMC capabilities of the wl12xx chip.  No matter who will
do it. :)

-- 
Cheers,
Luca.


WARNING: multiple messages have this Message-ID (diff)
From: coelho@ti.com (Luciano Coelho)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] omap: board-sdp4430: declare support for MMC_PM_KEEP_POWER
Date: Mon, 28 Nov 2011 12:18:10 +0200	[thread overview]
Message-ID: <1322475490.6502.56.camel@cumari> (raw)
In-Reply-To: <CAB3XZEfS4XN8sXf=r6s2cqOMnsSwLBsRLva61bQK4R-ZZnHPsA@mail.gmail.com>

On Mon, 2011-11-28 at 12:12 +0200, Eliad Peller wrote: 
> On Mon, Nov 28, 2011 at 11:58 AM, Luciano Coelho <coelho@ti.com> wrote:
> > On Mon, 2011-11-28 at 11:26 +0200, Igor Grinberg wrote:
> >> On 11/28/11 11:08, Luciano Coelho wrote:
> >> > I may do it for panda later on, if I get the time to test it.  For
> >> > beagle, it doesn't really apply, because the wl12xx support is
> >> > out-of-tree, unfortunately. :(
> >>
> >> If I understood correctly, you want to change all the
> >> board files supporting the wl12xx wifi chip to have this
> >> capability set, right?
> >> Isn't this immediately affects the power consumption in
> >> sleep state?
> >> Shouldn't this be runtime controllable?
> >> I bet there are many applications that do not care about WoW,
> >> but do care about the power consumption.
> >> How does this change affect them?
> >
> > Good point, I don't know. :) Probably Eliad has the answer for that.
> >
> see the discussion regarding patch [2/3] - we only declare here
> support for this capability, but it's disabled by default.

Great, thanks! :) I now also understand the difference between the
pm_flags and pm_caps. :)

So, back to where we started, we should add the capability to all boards
that define the MMC capabilities of the wl12xx chip.  No matter who will
do it. :)

-- 
Cheers,
Luca.

  reply	other threads:[~2011-11-28 10:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 14:02 [PATCH 1/3] omap_hsmmc: consider MMC_PM_KEEP_POWER on suspend/resume Eliad Peller
2011-11-22 14:02 ` Eliad Peller
2011-11-22 14:02 ` [PATCH 2/3] omap_hsmmc: add pm_caps field Eliad Peller
2011-11-22 14:02   ` Eliad Peller
2011-11-28  9:15   ` Igor Grinberg
2011-11-28  9:15     ` Igor Grinberg
2011-11-28  9:23     ` Eliad Peller
2011-11-28  9:23       ` Eliad Peller
2011-11-28 10:01       ` Igor Grinberg
2011-11-28 10:01         ` Igor Grinberg
2011-11-28 10:07         ` Eliad Peller
2011-11-28 10:07           ` Eliad Peller
2011-11-28 10:39           ` Igor Grinberg
2011-11-28 10:39             ` Igor Grinberg
2011-11-22 14:02 ` [PATCH 3/3] omap: board-sdp4430: declare support for MMC_PM_KEEP_POWER Eliad Peller
2011-11-22 14:02   ` Eliad Peller
2011-11-28  7:50   ` Coelho, Luciano
2011-11-28  7:50     ` Coelho, Luciano
2011-11-28  8:26     ` Eliad Peller
2011-11-28  8:26       ` Eliad Peller
2011-11-28  9:08       ` Luciano Coelho
2011-11-28  9:08         ` Luciano Coelho
2011-11-28  9:26         ` Igor Grinberg
2011-11-28  9:26           ` Igor Grinberg
2011-11-28  9:58           ` Luciano Coelho
2011-11-28  9:58             ` Luciano Coelho
2011-11-28 10:12             ` Eliad Peller
2011-11-28 10:12               ` Eliad Peller
2011-11-28 10:18               ` Luciano Coelho [this message]
2011-11-28 10:18                 ` Luciano Coelho
2011-12-01 18:16 ` [PATCH 1/3] omap_hsmmc: consider MMC_PM_KEEP_POWER on suspend/resume Chris Ball
2011-12-01 18:16   ` Chris Ball
2011-12-09  0:28   ` Tony Lindgren
2011-12-09  0:28     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322475490.6502.56.camel@cumari \
    --to=coelho@ti.com \
    --cc=cjb@laptop.org \
    --cc=eliad@wizery.com \
    --cc=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.