All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mmc@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Chris Ball <cjb@laptop.org>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 2/3] omap_hsmmc: add pm_caps field
Date: Mon, 28 Nov 2011 12:01:34 +0200	[thread overview]
Message-ID: <4ED35BFE.9060202@compulab.co.il> (raw)
In-Reply-To: <CAB3XZEeFSXBQZCR17bRdaG3UbhpE6JJHD_aEiq8Y2Kc3=eGRSQ@mail.gmail.com>

On 11/28/11 11:23, Eliad Peller wrote:
> hi Igor,
> 
> On Mon, Nov 28, 2011 at 11:15 AM, Igor Grinberg <grinberg@compulab.co.il> wrote:
>> On 11/22/11 16:02, Eliad Peller wrote:
>>> Add pm_caps field to omap2_hsmmc_info and omap_mmc_slot_data
>>> structs, so we will be able to indicate mmc pm capabilities
>>> in the board file.
>>
>> Shouldn't this be user space runtime controllable?
>> Instead of being a static per board decision?
>>
> we only declare here support for the pm capabilities.
> the actual configuration of these capabilities is done at a later
> stage, and can be controlled (implicitly) by userspace (e.g. by
> enabling Wakeup-On-Wireless for the wl12xx chip).

This is good to hear, because patch 1/3 makes it look like
the bus power does get immediately affected depending
on that capability, isn't it?


-- 
Regards,
Igor.

WARNING: multiple messages have this Message-ID (diff)
From: grinberg@compulab.co.il (Igor Grinberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] omap_hsmmc: add pm_caps field
Date: Mon, 28 Nov 2011 12:01:34 +0200	[thread overview]
Message-ID: <4ED35BFE.9060202@compulab.co.il> (raw)
In-Reply-To: <CAB3XZEeFSXBQZCR17bRdaG3UbhpE6JJHD_aEiq8Y2Kc3=eGRSQ@mail.gmail.com>

On 11/28/11 11:23, Eliad Peller wrote:
> hi Igor,
> 
> On Mon, Nov 28, 2011 at 11:15 AM, Igor Grinberg <grinberg@compulab.co.il> wrote:
>> On 11/22/11 16:02, Eliad Peller wrote:
>>> Add pm_caps field to omap2_hsmmc_info and omap_mmc_slot_data
>>> structs, so we will be able to indicate mmc pm capabilities
>>> in the board file.
>>
>> Shouldn't this be user space runtime controllable?
>> Instead of being a static per board decision?
>>
> we only declare here support for the pm capabilities.
> the actual configuration of these capabilities is done at a later
> stage, and can be controlled (implicitly) by userspace (e.g. by
> enabling Wakeup-On-Wireless for the wl12xx chip).

This is good to hear, because patch 1/3 makes it look like
the bus power does get immediately affected depending
on that capability, isn't it?


-- 
Regards,
Igor.

  reply	other threads:[~2011-11-28 10:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 14:02 [PATCH 1/3] omap_hsmmc: consider MMC_PM_KEEP_POWER on suspend/resume Eliad Peller
2011-11-22 14:02 ` Eliad Peller
2011-11-22 14:02 ` [PATCH 2/3] omap_hsmmc: add pm_caps field Eliad Peller
2011-11-22 14:02   ` Eliad Peller
2011-11-28  9:15   ` Igor Grinberg
2011-11-28  9:15     ` Igor Grinberg
2011-11-28  9:23     ` Eliad Peller
2011-11-28  9:23       ` Eliad Peller
2011-11-28 10:01       ` Igor Grinberg [this message]
2011-11-28 10:01         ` Igor Grinberg
2011-11-28 10:07         ` Eliad Peller
2011-11-28 10:07           ` Eliad Peller
2011-11-28 10:39           ` Igor Grinberg
2011-11-28 10:39             ` Igor Grinberg
2011-11-22 14:02 ` [PATCH 3/3] omap: board-sdp4430: declare support for MMC_PM_KEEP_POWER Eliad Peller
2011-11-22 14:02   ` Eliad Peller
2011-11-28  7:50   ` Coelho, Luciano
2011-11-28  7:50     ` Coelho, Luciano
2011-11-28  8:26     ` Eliad Peller
2011-11-28  8:26       ` Eliad Peller
2011-11-28  9:08       ` Luciano Coelho
2011-11-28  9:08         ` Luciano Coelho
2011-11-28  9:26         ` Igor Grinberg
2011-11-28  9:26           ` Igor Grinberg
2011-11-28  9:58           ` Luciano Coelho
2011-11-28  9:58             ` Luciano Coelho
2011-11-28 10:12             ` Eliad Peller
2011-11-28 10:12               ` Eliad Peller
2011-11-28 10:18               ` Luciano Coelho
2011-11-28 10:18                 ` Luciano Coelho
2011-12-01 18:16 ` [PATCH 1/3] omap_hsmmc: consider MMC_PM_KEEP_POWER on suspend/resume Chris Ball
2011-12-01 18:16   ` Chris Ball
2011-12-09  0:28   ` Tony Lindgren
2011-12-09  0:28     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED35BFE.9060202@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=cjb@laptop.org \
    --cc=eliad@wizery.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.