* [lm-sensors] [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver
@ 2011-12-08 13:33 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-12-08 13:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Jean Delvare, Guenter Roeck, lm-sensors
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hwmon/jz4740-hwmon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
index 3d7e590..5253d23 100644
--- a/drivers/hwmon/jz4740-hwmon.c
+++ b/drivers/hwmon/jz4740-hwmon.c
@@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev)
return 0;
}
-struct platform_driver jz4740_hwmon_driver = {
+static struct platform_driver jz4740_hwmon_driver = {
.probe = jz4740_hwmon_probe,
.remove = __devexit_p(jz4740_hwmon_remove),
.driver = {
--
1.7.5.4
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver
@ 2011-12-08 13:33 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-12-08 13:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Jean Delvare, Guenter Roeck, lm-sensors
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hwmon/jz4740-hwmon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
index 3d7e590..5253d23 100644
--- a/drivers/hwmon/jz4740-hwmon.c
+++ b/drivers/hwmon/jz4740-hwmon.c
@@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev)
return 0;
}
-struct platform_driver jz4740_hwmon_driver = {
+static struct platform_driver jz4740_hwmon_driver = {
.probe = jz4740_hwmon_probe,
.remove = __devexit_p(jz4740_hwmon_remove),
.driver = {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: jz4740: Staticise
2011-12-08 13:33 ` Axel Lin
@ 2011-12-08 14:08 ` Lars-Peter Clausen
-1 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2011-12-08 14:08 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Jean Delvare, Guenter Roeck, lm-sensors
On 12/08/2011 02:33 PM, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
> ---
> drivers/hwmon/jz4740-hwmon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
> index 3d7e590..5253d23 100644
> --- a/drivers/hwmon/jz4740-hwmon.c
> +++ b/drivers/hwmon/jz4740-hwmon.c
> @@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev)
> return 0;
> }
>
> -struct platform_driver jz4740_hwmon_driver = {
> +static struct platform_driver jz4740_hwmon_driver = {
> .probe = jz4740_hwmon_probe,
> .remove = __devexit_p(jz4740_hwmon_remove),
> .driver = {
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver
@ 2011-12-08 14:08 ` Lars-Peter Clausen
0 siblings, 0 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2011-12-08 14:08 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Jean Delvare, Guenter Roeck, lm-sensors
On 12/08/2011 02:33 PM, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
> ---
> drivers/hwmon/jz4740-hwmon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
> index 3d7e590..5253d23 100644
> --- a/drivers/hwmon/jz4740-hwmon.c
> +++ b/drivers/hwmon/jz4740-hwmon.c
> @@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev)
> return 0;
> }
>
> -struct platform_driver jz4740_hwmon_driver = {
> +static struct platform_driver jz4740_hwmon_driver = {
> .probe = jz4740_hwmon_probe,
> .remove = __devexit_p(jz4740_hwmon_remove),
> .driver = {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: jz4740: Staticise
2011-12-08 13:33 ` Axel Lin
@ 2011-12-08 14:21 ` Guenter Roeck
-1 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2011-12-08 14:21 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen, Jean Delvare,
lm-sensors@lm-sensors.org
On Thu, Dec 08, 2011 at 08:33:37AM -0500, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-08 14:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-08 13:33 [lm-sensors] [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver Axel Lin
2011-12-08 13:33 ` Axel Lin
2011-12-08 14:08 ` [lm-sensors] [PATCH] hwmon: jz4740: Staticise Lars-Peter Clausen
2011-12-08 14:08 ` [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver Lars-Peter Clausen
2011-12-08 14:21 ` [lm-sensors] [PATCH] hwmon: jz4740: Staticise Guenter Roeck
2011-12-08 14:21 ` [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.