From: David Howells <dhowells@cambridge.redhat.com>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: Rik van Riel <riel@conectiva.com.br>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Date: Tue, 30 Jan 2001 08:18:56 +0000 [thread overview]
Message-ID: <13240.980842736@warthog.cambridge.redhat.com> (raw)
In-Reply-To: Message from Rasmus Andersen <rasmus@jaquet.dk> of "Mon, 29 Jan 2001 22:43:11 +0100." <20010129224311.H603@jaquet.dk>
>...
> + spin_lock(&mm->page_table_lock);
> mm->rss++;
> + spin_unlock(&mm->page_table_lock);
>...
Would it not be better to use some sort of atomic add/subtract/clear operation
rather than a spinlock? (Which would also give you fewer atomic memory access
cycles).
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@cambridge.redhat.com>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: Rik van Riel <riel@conectiva.com.br>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Date: Tue, 30 Jan 2001 08:18:56 +0000 [thread overview]
Message-ID: <13240.980842736@warthog.cambridge.redhat.com> (raw)
In-Reply-To: Message from Rasmus Andersen <rasmus@jaquet.dk> of "Mon, 29 Jan 2001 22:43:11 +0100." <20010129224311.H603@jaquet.dk>
>...
> + spin_lock(&mm->page_table_lock);
> mm->rss++;
> + spin_unlock(&mm->page_table_lock);
>...
Would it not be better to use some sort of atomic add/subtract/clear operation
rather than a spinlock? (Which would also give you fewer atomic memory access
cycles).
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2001-01-30 8:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-29 21:23 [PATCH] guard mm->rss with page_table_lock (241p11) Rasmus Andersen
2001-01-29 21:23 ` Rasmus Andersen
2001-01-29 21:30 ` Rik van Riel
2001-01-29 21:30 ` Rik van Riel
2001-01-29 21:43 ` Rasmus Andersen
2001-01-29 21:43 ` Rasmus Andersen
2001-01-29 21:47 ` Rik van Riel
2001-01-29 21:47 ` Rik van Riel
2001-01-30 8:18 ` David Howells [this message]
2001-01-30 8:18 ` David Howells
2001-01-30 8:31 ` Rasmus Andersen
2001-01-30 8:31 ` Rasmus Andersen
2001-01-30 14:32 ` Mark Hahn
2001-01-30 15:30 ` Eric W. Biederman
2001-01-30 8:39 ` David S. Miller
2001-01-30 8:39 ` David S. Miller
2001-01-30 11:17 ` Chris Wedgwood
2001-01-30 11:17 ` Chris Wedgwood
2001-01-30 11:23 ` Rik van Riel
2001-01-30 11:23 ` Rik van Riel
2001-01-30 11:38 ` Rasmus Andersen
2001-01-30 11:38 ` Rasmus Andersen
2001-02-13 3:15 ` george anzinger
2001-02-13 3:15 ` george anzinger
2001-02-13 2:05 ` Marcelo Tosatti
2001-02-13 2:05 ` Marcelo Tosatti
2001-02-13 10:08 ` Stephen C. Tweedie
2001-02-13 10:08 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13240.980842736@warthog.cambridge.redhat.com \
--to=dhowells@cambridge.redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rasmus@jaquet.dk \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.