From: Rasmus Andersen <rasmus@jaquet.dk>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Chris Wedgwood <cw@f00f.org>,
"David S. Miller" <davem@redhat.com>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Date: Tue, 30 Jan 2001 12:38:12 +0100 [thread overview]
Message-ID: <20010130123812.O3298@jaquet.dk> (raw)
In-Reply-To: <20010131001737.C6620@metastasis.f00f.org> <Pine.LNX.4.21.0101300921480.1321-100000@duckman.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0101300921480.1321-100000@duckman.distro.conectiva>; from riel@conectiva.com.br on Tue, Jan 30, 2001 at 09:23:27AM -0200
On Tue, Jan 30, 2001 at 09:23:27AM -0200, Rik van Riel wrote:
> Why bother ?
>
> In most places where we update mm->rss, we are *already*
> holding the spinlock anyway, this correction is just for
> a few places.
>
> The big patch Rasmus made seems to contain spin_lock(&foo)
> in places where we already have the lock, leading to
> instant SMP deadlock. I suspect Rasmus' patch should be
> about half the size it is currently...
After donning my brown paper bag yesterday I looked at
the call-paths again and removed one more lock pair
(the one in swapfile). The others seemed OK so I made
a SMP-on-UP kernel and ran my usual stuff (X, mozilla,
kernel compiles) alongside mmap001, mmap002 and misc001
with no ill effects.
I will beat on it some more today and tomorrow, but if
real SMP is needed for testing I need some help to do
that.
Regards,
Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Andersen <rasmus@jaquet.dk>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Chris Wedgwood <cw@f00f.org>,
"David S. Miller" <davem@redhat.com>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Date: Tue, 30 Jan 2001 12:38:12 +0100 [thread overview]
Message-ID: <20010130123812.O3298@jaquet.dk> (raw)
In-Reply-To: <Pine.LNX.4.21.0101300921480.1321-100000@duckman.distro.conectiva>; from riel@conectiva.com.br on Tue, Jan 30, 2001 at 09:23:27AM -0200
On Tue, Jan 30, 2001 at 09:23:27AM -0200, Rik van Riel wrote:
> Why bother ?
>
> In most places where we update mm->rss, we are *already*
> holding the spinlock anyway, this correction is just for
> a few places.
>
> The big patch Rasmus made seems to contain spin_lock(&foo)
> in places where we already have the lock, leading to
> instant SMP deadlock. I suspect Rasmus' patch should be
> about half the size it is currently...
After donning my brown paper bag yesterday I looked at
the call-paths again and removed one more lock pair
(the one in swapfile). The others seemed OK so I made
a SMP-on-UP kernel and ran my usual stuff (X, mozilla,
kernel compiles) alongside mmap001, mmap002 and misc001
with no ill effects.
I will beat on it some more today and tomorrow, but if
real SMP is needed for testing I need some help to do
that.
Regards,
Rasmus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2001-01-30 11:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-29 21:23 [PATCH] guard mm->rss with page_table_lock (241p11) Rasmus Andersen
2001-01-29 21:23 ` Rasmus Andersen
2001-01-29 21:30 ` Rik van Riel
2001-01-29 21:30 ` Rik van Riel
2001-01-29 21:43 ` Rasmus Andersen
2001-01-29 21:43 ` Rasmus Andersen
2001-01-29 21:47 ` Rik van Riel
2001-01-29 21:47 ` Rik van Riel
2001-01-30 8:18 ` David Howells
2001-01-30 8:18 ` David Howells
2001-01-30 8:31 ` Rasmus Andersen
2001-01-30 8:31 ` Rasmus Andersen
2001-01-30 14:32 ` Mark Hahn
2001-01-30 15:30 ` Eric W. Biederman
2001-01-30 8:39 ` David S. Miller
2001-01-30 8:39 ` David S. Miller
2001-01-30 11:17 ` Chris Wedgwood
2001-01-30 11:17 ` Chris Wedgwood
2001-01-30 11:23 ` Rik van Riel
2001-01-30 11:23 ` Rik van Riel
2001-01-30 11:38 ` Rasmus Andersen [this message]
2001-01-30 11:38 ` Rasmus Andersen
2001-02-13 3:15 ` george anzinger
2001-02-13 3:15 ` george anzinger
2001-02-13 2:05 ` Marcelo Tosatti
2001-02-13 2:05 ` Marcelo Tosatti
2001-02-13 10:08 ` Stephen C. Tweedie
2001-02-13 10:08 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010130123812.O3298@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=cw@f00f.org \
--cc=davem@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.