* Re: [Qemu-devel] Compiling without python?
@ 2011-12-30 22:36 Sebastian Herbszt
2011-12-30 23:08 ` Stefan Weil
2012-01-01 11:45 ` [Qemu-devel] Compiling without python? Michael S. Tsirkin
0 siblings, 2 replies; 12+ messages in thread
From: Sebastian Herbszt @ 2011-12-30 22:36 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini, Michael S. Tsirkin, Anthony Liguori
Cc: Sebastian Herbszt
Sebastian Herbszt wrote:
> Is it still possible to compile without python?
>
> python /v1.0-267-gda5361c/scripts/qapi-commands.py -m -o .
> /bin/sh: python: command not found
> make: *** [qmp-commands.h] Error 127
>
> Sebastian
Care to answer?
Thanks,
Sebastian
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Compiling without python?
2011-12-30 22:36 [Qemu-devel] Compiling without python? Sebastian Herbszt
@ 2011-12-30 23:08 ` Stefan Weil
2011-12-30 23:59 ` [Qemu-devel] Subject: [PATCH] Make python mandatory Sebastian Herbszt
2012-01-01 11:45 ` [Qemu-devel] Compiling without python? Michael S. Tsirkin
1 sibling, 1 reply; 12+ messages in thread
From: Stefan Weil @ 2011-12-30 23:08 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-devel
Am 30.12.2011 23:36, schrieb Sebastian Herbszt:
> Sebastian Herbszt wrote:
>> Is it still possible to compile without python?
>>
>> python /v1.0-267-gda5361c/scripts/qapi-commands.py -m -o .
>> /bin/sh: python: command not found
>> make: *** [qmp-commands.h] Error 127
>>
>> Sebastian
>
> Care to answer?
>
> Thanks,
> Sebastian
No, this is no longer possible. You need Python 2.x.
Python 3.x does not work!
Regards,
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] Subject: [PATCH] Make python mandatory
2011-12-30 23:08 ` Stefan Weil
@ 2011-12-30 23:59 ` Sebastian Herbszt
2011-12-31 0:52 ` Peter Maydell
0 siblings, 1 reply; 12+ messages in thread
From: Sebastian Herbszt @ 2011-12-30 23:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Weil
Make python mandatory.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
---
configure | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/configure b/configure
index 640e815..6c2a1b4 100755
--- a/configure
+++ b/configure
@@ -1185,13 +1185,11 @@ if test "$solaris" = "yes" ; then
fi
fi
-if test "$guest_agent" != "no" ; then
- if has $python; then
- :
- else
- echo "Python not found. Use --python=/path/to/python"
- exit 1
- fi
+if has $python; then
+ :
+else
+ echo "Python not found. Use --python=/path/to/python"
+ exit 1
fi
if test -z "$target_list" ; then
--
1.7.3.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Subject: [PATCH] Make python mandatory
2011-12-30 23:59 ` [Qemu-devel] Subject: [PATCH] Make python mandatory Sebastian Herbszt
@ 2011-12-31 0:52 ` Peter Maydell
2011-12-31 1:00 ` Sebastian Herbszt
2011-12-31 11:14 ` [Qemu-devel] [PATCH V2] " Sebastian Herbszt
0 siblings, 2 replies; 12+ messages in thread
From: Peter Maydell @ 2011-12-31 0:52 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: Stefan Weil, qemu-devel
On 30 December 2011 23:59, Sebastian Herbszt <herbszt@gmx.de> wrote:
> Make python mandatory.
> +if has $python; then
> + :
> +else
> + echo "Python not found. Use --python=/path/to/python"
> + exit 1
> fi
>
> if test -z "$target_list" ; then
I know you've just removed the outer condition here, but
while we're fiddling with it, wouldn't
if ! has "$python"; then
echo "Python not found etc"
fi
be better?
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] Subject: [PATCH] Make python mandatory
2011-12-31 0:52 ` Peter Maydell
@ 2011-12-31 1:00 ` Sebastian Herbszt
2011-12-31 11:14 ` [Qemu-devel] [PATCH V2] " Sebastian Herbszt
1 sibling, 0 replies; 12+ messages in thread
From: Sebastian Herbszt @ 2011-12-31 1:00 UTC (permalink / raw)
To: Peter Maydell; +Cc: Stefan Weil, qemu-devel
Peter Maydell wrote:
>On 30 December 2011 23:59, Sebastian Herbszt <herbszt@gmx.de> wrote:
>> Make python mandatory.
>>
>> +if has $python; then
>> + :
>> +else
>> + echo "Python not found. Use --python=/path/to/python"
>> + exit 1
>> fi
>>
>> if test -z "$target_list" ; then
>
> I know you've just removed the outer condition here, but
> while we're fiddling with it, wouldn't
> if ! has "$python"; then
> echo "Python not found etc"
> fi
>
> be better?
>
> -- PMM
I just restored it to the state it was before commit "guest agent: add --enable-guest-agent config option".
This check was added in commit "Let users select their pythons".
Sebastian
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH V2] Make python mandatory
2011-12-31 0:52 ` Peter Maydell
2011-12-31 1:00 ` Sebastian Herbszt
@ 2011-12-31 11:14 ` Sebastian Herbszt
2011-12-31 11:20 ` Stefan Weil
2011-12-31 11:39 ` [Qemu-devel] " Peter Maydell
1 sibling, 2 replies; 12+ messages in thread
From: Sebastian Herbszt @ 2011-12-31 11:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Weil, Peter Maydell
Make python mandatory.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
---
configure | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/configure b/configure
index 640e815..a54439d 100755
--- a/configure
+++ b/configure
@@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
fi
fi
-if test "$guest_agent" != "no" ; then
- if has $python; then
- :
- else
- echo "Python not found. Use --python=/path/to/python"
- exit 1
- fi
+if ! has $python; then
+ echo "Python not found. Use --python=/path/to/python"
+ exit 1
fi
if test -z "$target_list" ; then
--
1.7.3.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH V2] Make python mandatory
2011-12-31 11:14 ` [Qemu-devel] [PATCH V2] " Sebastian Herbszt
@ 2011-12-31 11:20 ` Stefan Weil
2011-12-31 11:39 ` [Qemu-devel] " Peter Maydell
1 sibling, 0 replies; 12+ messages in thread
From: Stefan Weil @ 2011-12-31 11:20 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-trivial, Peter Maydell, qemu-devel
Am 31.12.2011 12:14, schrieb Sebastian Herbszt:
> Make python mandatory.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
> configure | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/configure b/configure
> index 640e815..a54439d 100755
> --- a/configure
> +++ b/configure
> @@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
> fi
> fi
>
> -if test "$guest_agent" != "no" ; then
> - if has $python; then
> - :
> - else
> - echo "Python not found. Use --python=/path/to/python"
> - exit 1
> - fi
> +if ! has $python; then
> + echo "Python not found. Use --python=/path/to/python"
> + exit 1
> fi
>
> if test -z "$target_list" ; then
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Maybe this patch can be applied via qemu-trivial.
Regards,
Stefan Weil
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH V2] Make python mandatory
@ 2011-12-31 11:20 ` Stefan Weil
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Weil @ 2011-12-31 11:20 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-trivial, Peter Maydell, qemu-devel
Am 31.12.2011 12:14, schrieb Sebastian Herbszt:
> Make python mandatory.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
> configure | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/configure b/configure
> index 640e815..a54439d 100755
> --- a/configure
> +++ b/configure
> @@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
> fi
> fi
>
> -if test "$guest_agent" != "no" ; then
> - if has $python; then
> - :
> - else
> - echo "Python not found. Use --python=/path/to/python"
> - exit 1
> - fi
> +if ! has $python; then
> + echo "Python not found. Use --python=/path/to/python"
> + exit 1
> fi
>
> if test -z "$target_list" ; then
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Maybe this patch can be applied via qemu-trivial.
Regards,
Stefan Weil
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH V2] Make python mandatory
2011-12-31 11:20 ` Stefan Weil
@ 2012-01-03 10:53 ` Stefan Hajnoczi
-1 siblings, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2012-01-03 10:53 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Peter Maydell, qemu-devel, Sebastian Herbszt
On Sat, Dec 31, 2011 at 12:20:47PM +0100, Stefan Weil wrote:
> Am 31.12.2011 12:14, schrieb Sebastian Herbszt:
> >Make python mandatory.
> >
> >Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> >---
> >configure | 10 +++-------
> >1 files changed, 3 insertions(+), 7 deletions(-)
> >
> >diff --git a/configure b/configure
> >index 640e815..a54439d 100755
> >--- a/configure
> >+++ b/configure
> >@@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
> >fi
> >fi
> >
> >-if test "$guest_agent" != "no" ; then
> >- if has $python; then
> >- :
> >- else
> >- echo "Python not found. Use --python=/path/to/python"
> >- exit 1
> >- fi
> >+if ! has $python; then
> >+ echo "Python not found. Use --python=/path/to/python"
> >+ exit 1
> >fi
> >
> >if test -z "$target_list" ; then
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Maybe this patch can be applied via qemu-trivial.
Thanks, applied to the trivial patches -next tree:
https://github.com/stefanha/qemu/tree/trivial-patches-next
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH V2] Make python mandatory
@ 2012-01-03 10:53 ` Stefan Hajnoczi
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2012-01-03 10:53 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Peter Maydell, qemu-devel, Sebastian Herbszt
On Sat, Dec 31, 2011 at 12:20:47PM +0100, Stefan Weil wrote:
> Am 31.12.2011 12:14, schrieb Sebastian Herbszt:
> >Make python mandatory.
> >
> >Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> >---
> >configure | 10 +++-------
> >1 files changed, 3 insertions(+), 7 deletions(-)
> >
> >diff --git a/configure b/configure
> >index 640e815..a54439d 100755
> >--- a/configure
> >+++ b/configure
> >@@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
> >fi
> >fi
> >
> >-if test "$guest_agent" != "no" ; then
> >- if has $python; then
> >- :
> >- else
> >- echo "Python not found. Use --python=/path/to/python"
> >- exit 1
> >- fi
> >+if ! has $python; then
> >+ echo "Python not found. Use --python=/path/to/python"
> >+ exit 1
> >fi
> >
> >if test -z "$target_list" ; then
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> Maybe this patch can be applied via qemu-trivial.
Thanks, applied to the trivial patches -next tree:
https://github.com/stefanha/qemu/tree/trivial-patches-next
Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH V2] Make python mandatory
2011-12-31 11:14 ` [Qemu-devel] [PATCH V2] " Sebastian Herbszt
2011-12-31 11:20 ` Stefan Weil
@ 2011-12-31 11:39 ` Peter Maydell
1 sibling, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2011-12-31 11:39 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: Stefan Weil, qemu-devel
On 31 December 2011 11:14, Sebastian Herbszt <herbszt@gmx.de> wrote:
> +if ! has $python; then
> + echo "Python not found. Use --python=/path/to/python"
> + exit 1
> fi
This will do the wrong thing if the user runs configure with
'--python=/path with spaces/python', but the Makefile won't
cope with that either so I guess it's not that important.
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Compiling without python?
2011-12-30 22:36 [Qemu-devel] Compiling without python? Sebastian Herbszt
2011-12-30 23:08 ` Stefan Weil
@ 2012-01-01 11:45 ` Michael S. Tsirkin
1 sibling, 0 replies; 12+ messages in thread
From: Michael S. Tsirkin @ 2012-01-01 11:45 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
On Fri, Dec 30, 2011 at 11:36:53PM +0100, Sebastian Herbszt wrote:
> Sebastian Herbszt wrote:
> >Is it still possible to compile without python?
> >
> >python /v1.0-267-gda5361c/scripts/qapi-commands.py -m -o .
> >/bin/sh: python: command not found
> >make: *** [qmp-commands.h] Error 127
> >
> >Sebastian
>
> Care to answer?
>
> Thanks,
> Sebastian
Probably not. I think configure should check for python.
--
MST
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-01-03 10:53 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-30 22:36 [Qemu-devel] Compiling without python? Sebastian Herbszt
2011-12-30 23:08 ` Stefan Weil
2011-12-30 23:59 ` [Qemu-devel] Subject: [PATCH] Make python mandatory Sebastian Herbszt
2011-12-31 0:52 ` Peter Maydell
2011-12-31 1:00 ` Sebastian Herbszt
2011-12-31 11:14 ` [Qemu-devel] [PATCH V2] " Sebastian Herbszt
2011-12-31 11:20 ` [Qemu-trivial] " Stefan Weil
2011-12-31 11:20 ` Stefan Weil
2012-01-03 10:53 ` [Qemu-trivial] " Stefan Hajnoczi
2012-01-03 10:53 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-12-31 11:39 ` [Qemu-devel] " Peter Maydell
2012-01-01 11:45 ` [Qemu-devel] Compiling without python? Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.