From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video/omap2. dispc_mgr_enable needs runtime PM
Date: Thu, 05 Jan 2012 07:40:22 +0000 [thread overview]
Message-ID: <1325749222.2045.31.camel@deskari> (raw)
In-Reply-To: <20120105183241.751b8086@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Thu, 2012-01-05 at 18:32 +1100, NeilBrown wrote:
> On Wed, 04 Jan 2012 09:50:56 +0200 Tomi Valkeinen <tomi.valkeinen@ti.com>
> wrote:
>
> yep, that looks likely. The 'disable' routines of other panels only call
> omapdss_dpi_display_disable() if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE).
> This panel calls it unconditionally. I guess that is the real bug? (and
> putting an appropriate test in fixes it).
Yes, that's the bug then. The enable and disable calls must match.
> Thanks for your help.
>
> (If/when I get this td028ttec driver cleaned up, would you be the one I send
> it to?)
Yep. However, I'm currently working on device tree support for omapdss,
which will affect all panel drivers, and I may reject any new panel
patches until the dev tree stuff is in. But please send anyway =).
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video/omap2. dispc_mgr_enable needs runtime PM
Date: Thu, 05 Jan 2012 09:40:22 +0200 [thread overview]
Message-ID: <1325749222.2045.31.camel@deskari> (raw)
In-Reply-To: <20120105183241.751b8086@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Thu, 2012-01-05 at 18:32 +1100, NeilBrown wrote:
> On Wed, 04 Jan 2012 09:50:56 +0200 Tomi Valkeinen <tomi.valkeinen@ti.com>
> wrote:
>
> yep, that looks likely. The 'disable' routines of other panels only call
> omapdss_dpi_display_disable() if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE).
> This panel calls it unconditionally. I guess that is the real bug? (and
> putting an appropriate test in fixes it).
Yes, that's the bug then. The enable and disable calls must match.
> Thanks for your help.
>
> (If/when I get this td028ttec driver cleaned up, would you be the one I send
> it to?)
Yep. However, I'm currently working on device tree support for omapdss,
which will affect all panel drivers, and I may reject any new panel
patches until the dev tree stuff is in. But please send anyway =).
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-05 7:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 1:37 [PATCH] video/omap2. dispc_mgr_enable needs runtime PM NeilBrown
2011-12-30 1:37 ` NeilBrown
2012-01-04 7:50 ` Tomi Valkeinen
2012-01-04 7:50 ` Tomi Valkeinen
2012-01-05 7:32 ` NeilBrown
2012-01-05 7:32 ` NeilBrown
2012-01-05 7:40 ` Tomi Valkeinen [this message]
2012-01-05 7:40 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325749222.2045.31.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.