From: NeilBrown <neilb@suse.de>
To: Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Subject: [PATCH] video/omap2. dispc_mgr_enable needs runtime PM
Date: Fri, 30 Dec 2011 01:37:55 +0000 [thread overview]
Message-ID: <20111230123755.384a5b5c@notabene.brown> (raw)
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
When dispc_mgr_enable is called during shutdown the device might
be asleep, which causes problems. So ensure it is awake.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index 5c81533..75a767f 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -2052,12 +2052,14 @@ bool dispc_mgr_is_enabled(enum omap_channel channel)
void dispc_mgr_enable(enum omap_channel channel, bool enable)
{
+ dispc_runtime_get();
if (dispc_mgr_is_lcd(channel))
dispc_mgr_enable_lcd_out(channel, enable);
else if (channel == OMAP_DSS_CHANNEL_DIGIT)
dispc_mgr_enable_digit_out(enable);
else
BUG();
+ dispc_runtime_put();
}
void dispc_lcd_enable_signal_polarity(bool act_high)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neilb@suse.de>
To: Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Subject: [PATCH] video/omap2. dispc_mgr_enable needs runtime PM
Date: Fri, 30 Dec 2011 12:37:55 +1100 [thread overview]
Message-ID: <20111230123755.384a5b5c@notabene.brown> (raw)
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
When dispc_mgr_enable is called during shutdown the device might
be asleep, which causes problems. So ensure it is awake.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index 5c81533..75a767f 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -2052,12 +2052,14 @@ bool dispc_mgr_is_enabled(enum omap_channel channel)
void dispc_mgr_enable(enum omap_channel channel, bool enable)
{
+ dispc_runtime_get();
if (dispc_mgr_is_lcd(channel))
dispc_mgr_enable_lcd_out(channel, enable);
else if (channel == OMAP_DSS_CHANNEL_DIGIT)
dispc_mgr_enable_digit_out(enable);
else
BUG();
+ dispc_runtime_put();
}
void dispc_lcd_enable_signal_polarity(bool act_high)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next reply other threads:[~2011-12-30 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 1:37 NeilBrown [this message]
2011-12-30 1:37 ` [PATCH] video/omap2. dispc_mgr_enable needs runtime PM NeilBrown
2012-01-04 7:50 ` Tomi Valkeinen
2012-01-04 7:50 ` Tomi Valkeinen
2012-01-05 7:32 ` NeilBrown
2012-01-05 7:32 ` NeilBrown
2012-01-05 7:40 ` Tomi Valkeinen
2012-01-05 7:40 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230123755.384a5b5c@notabene.brown \
--to=neilb@suse.de \
--cc=khilman@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.