From: James Bottomley <jbottomley@parallels.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <greg@kroah.com>
Cc: Parisc List <linux-parisc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Fix compile breakage with kref.h
Date: Tue, 17 Jan 2012 21:14:05 +0000 [thread overview]
Message-ID: <1326834845.3020.36.camel@dabdike> (raw)
VGhpcyBzZXQgb2YgYnVpbGQgZmFpbHVyZXMganVzdCBzdGFydGVkIGFwcGVhcmluZyBvbiBwYXJp
c2M6DQoNCkluIGZpbGUgaW5jbHVkZWQgZnJvbSBkcml2ZXJzL2lucHV0L3NlcmlvL3NlcmlvX3Jh
dy5jOjEyOg0KaW5jbHVkZS9saW51eC9rcmVmLmg6IEluIGZ1bmN0aW9uICdrcmVmX2dldCc6DQpp
bmNsdWRlL2xpbnV4L2tyZWYuaDo0MDogZXJyb3I6ICdUQUlOVF9XQVJOJyB1bmRlY2xhcmVkIChm
aXJzdCB1c2UgaW4gdGhpcyBmdW5jdGlvbikNCmluY2x1ZGUvbGludXgva3JlZi5oOjQwOiBlcnJv
cjogKEVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZQ0KaW5j
bHVkZS9saW51eC9rcmVmLmg6NDA6IGVycm9yOiBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJz
IGluLikNCmluY2x1ZGUvbGludXgva3JlZi5oOiBJbiBmdW5jdGlvbiAna3JlZl9zdWInOg0KaW5j
bHVkZS9saW51eC9rcmVmLmg6NjU6IGVycm9yOiAnVEFJTlRfV0FSTicgdW5kZWNsYXJlZCAoZmly
c3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pDQoNCkl0IGhhcHBlbnMgYmVjYXVzZSBUQUlOVF9XQVJO
IGlzIGRlZmluZWQgaW4ga2VybmVsLmggYW5kIHRoaXMgcGFydGljdWxhcg0KY29tcGlsZSBkb2Vz
bid0IHNlZW0gdG8gaW5jbHVkZSBpdCAobm8gaWRlYSB3aHkgaXQncyBqdXN0DQptYW5pZmVzdGlu
ZyAuLi4gcHJvYmFibHkgc29tZSAjaW5jbHVkZSBmaWxlIHVudGFuZ2xpbmcgZXhwb3NlZCBpdCku
ICBGaXgNCmJ5IGFkZGluZyAjaW5jbHVkZSA8bGludXgva2VybmVsLmg+IHRvIGxpbnV4L2tyZWYu
aA0KDQpTaWduZWQtb2ZmLWJ5OiBKYW1lcyBCb3R0b21sZXkgPEpCb3R0b21sZXlAUGFyYWxsZWxz
LmNvbT4NCg0KLS0tDQoNCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2tyZWYuaCBiL2luY2x1
ZGUvbGludXgva3JlZi5oDQppbmRleCBhYmMwMTIwLi45YzA3ZGNlIDEwMDY0NA0KLS0tIGEvaW5j
bHVkZS9saW51eC9rcmVmLmgNCisrKyBiL2luY2x1ZGUvbGludXgva3JlZi5oDQpAQCAtMTcsNiAr
MTcsNyBAQA0KIA0KICNpbmNsdWRlIDxsaW51eC9idWcuaD4NCiAjaW5jbHVkZSA8bGludXgvYXRv
bWljLmg+DQorI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPg0KIA0KIHN0cnVjdCBrcmVmIHsNCiAJ
YXRvbWljX3QgcmVmY291bnQ7DQoNCg==
WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <jbottomley@parallels.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <greg@kroah.com>
Cc: Parisc List <linux-parisc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Fix compile breakage with kref.h
Date: Tue, 17 Jan 2012 21:14:05 +0000 [thread overview]
Message-ID: <1326834845.3020.36.camel@dabdike> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1290 bytes --]
This set of build failures just started appearing on parisc:
In file included from drivers/input/serio/serio_raw.c:12:
include/linux/kref.h: In function 'kref_get':
include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use in this function)
include/linux/kref.h:40: error: (Each undeclared identifier is reported only once
include/linux/kref.h:40: error: for each function it appears in.)
include/linux/kref.h: In function 'kref_sub':
include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use in this function)
It happens because TAINT_WARN is defined in kernel.h and this particular
compile doesn't seem to include it (no idea why it's just
manifesting ... probably some #include file untangling exposed it). Fix
by adding #include <linux/kernel.h> to linux/kref.h
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
---
diff --git a/include/linux/kref.h b/include/linux/kref.h
index abc0120..9c07dce 100644
--- a/include/linux/kref.h
+++ b/include/linux/kref.h
@@ -17,6 +17,7 @@
#include <linux/bug.h>
#include <linux/atomic.h>
+#include <linux/kernel.h>
struct kref {
atomic_t refcount;
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next reply other threads:[~2012-01-17 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 21:14 James Bottomley [this message]
2012-01-17 21:14 ` Fix compile breakage with kref.h James Bottomley
2012-01-17 21:26 ` Greg Kroah-Hartman
2012-01-17 22:09 ` Paul Gortmaker
2012-01-17 22:09 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326834845.3020.36.camel@dabdike \
--to=jbottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.