* Fix compile breakage with kref.h
@ 2012-01-17 21:14 ` James Bottomley
0 siblings, 0 replies; 5+ messages in thread
From: James Bottomley @ 2012-01-17 21:14 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton, Greg Kroah-Hartman
Cc: Parisc List, linux-kernel
VGhpcyBzZXQgb2YgYnVpbGQgZmFpbHVyZXMganVzdCBzdGFydGVkIGFwcGVhcmluZyBvbiBwYXJp
c2M6DQoNCkluIGZpbGUgaW5jbHVkZWQgZnJvbSBkcml2ZXJzL2lucHV0L3NlcmlvL3NlcmlvX3Jh
dy5jOjEyOg0KaW5jbHVkZS9saW51eC9rcmVmLmg6IEluIGZ1bmN0aW9uICdrcmVmX2dldCc6DQpp
bmNsdWRlL2xpbnV4L2tyZWYuaDo0MDogZXJyb3I6ICdUQUlOVF9XQVJOJyB1bmRlY2xhcmVkIChm
aXJzdCB1c2UgaW4gdGhpcyBmdW5jdGlvbikNCmluY2x1ZGUvbGludXgva3JlZi5oOjQwOiBlcnJv
cjogKEVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZQ0KaW5j
bHVkZS9saW51eC9rcmVmLmg6NDA6IGVycm9yOiBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJz
IGluLikNCmluY2x1ZGUvbGludXgva3JlZi5oOiBJbiBmdW5jdGlvbiAna3JlZl9zdWInOg0KaW5j
bHVkZS9saW51eC9rcmVmLmg6NjU6IGVycm9yOiAnVEFJTlRfV0FSTicgdW5kZWNsYXJlZCAoZmly
c3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pDQoNCkl0IGhhcHBlbnMgYmVjYXVzZSBUQUlOVF9XQVJO
IGlzIGRlZmluZWQgaW4ga2VybmVsLmggYW5kIHRoaXMgcGFydGljdWxhcg0KY29tcGlsZSBkb2Vz
bid0IHNlZW0gdG8gaW5jbHVkZSBpdCAobm8gaWRlYSB3aHkgaXQncyBqdXN0DQptYW5pZmVzdGlu
ZyAuLi4gcHJvYmFibHkgc29tZSAjaW5jbHVkZSBmaWxlIHVudGFuZ2xpbmcgZXhwb3NlZCBpdCku
ICBGaXgNCmJ5IGFkZGluZyAjaW5jbHVkZSA8bGludXgva2VybmVsLmg+IHRvIGxpbnV4L2tyZWYu
aA0KDQpTaWduZWQtb2ZmLWJ5OiBKYW1lcyBCb3R0b21sZXkgPEpCb3R0b21sZXlAUGFyYWxsZWxz
LmNvbT4NCg0KLS0tDQoNCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2tyZWYuaCBiL2luY2x1
ZGUvbGludXgva3JlZi5oDQppbmRleCBhYmMwMTIwLi45YzA3ZGNlIDEwMDY0NA0KLS0tIGEvaW5j
bHVkZS9saW51eC9rcmVmLmgNCisrKyBiL2luY2x1ZGUvbGludXgva3JlZi5oDQpAQCAtMTcsNiAr
MTcsNyBAQA0KIA0KICNpbmNsdWRlIDxsaW51eC9idWcuaD4NCiAjaW5jbHVkZSA8bGludXgvYXRv
bWljLmg+DQorI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPg0KIA0KIHN0cnVjdCBrcmVmIHsNCiAJ
YXRvbWljX3QgcmVmY291bnQ7DQoNCg==
^ permalink raw reply [flat|nested] 5+ messages in thread
* Fix compile breakage with kref.h
@ 2012-01-17 21:14 ` James Bottomley
0 siblings, 0 replies; 5+ messages in thread
From: James Bottomley @ 2012-01-17 21:14 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton, Greg Kroah-Hartman
Cc: Parisc List, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1290 bytes --]
This set of build failures just started appearing on parisc:
In file included from drivers/input/serio/serio_raw.c:12:
include/linux/kref.h: In function 'kref_get':
include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use in this function)
include/linux/kref.h:40: error: (Each undeclared identifier is reported only once
include/linux/kref.h:40: error: for each function it appears in.)
include/linux/kref.h: In function 'kref_sub':
include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use in this function)
It happens because TAINT_WARN is defined in kernel.h and this particular
compile doesn't seem to include it (no idea why it's just
manifesting ... probably some #include file untangling exposed it). Fix
by adding #include <linux/kernel.h> to linux/kref.h
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
---
diff --git a/include/linux/kref.h b/include/linux/kref.h
index abc0120..9c07dce 100644
--- a/include/linux/kref.h
+++ b/include/linux/kref.h
@@ -17,6 +17,7 @@
#include <linux/bug.h>
#include <linux/atomic.h>
+#include <linux/kernel.h>
struct kref {
atomic_t refcount;
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: Fix compile breakage with kref.h
2012-01-17 21:14 ` James Bottomley
(?)
@ 2012-01-17 21:26 ` Greg Kroah-Hartman
2012-01-17 22:09 ` Paul Gortmaker
-1 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2012-01-17 21:26 UTC (permalink / raw)
To: James Bottomley; +Cc: Linus Torvalds, Andrew Morton, Parisc List, linux-kernel
On Tue, Jan 17, 2012 at 09:14:05PM +0000, James Bottomley wrote:
> This set of build failures just started appearing on parisc:
>
> In file included from drivers/input/serio/serio_raw.c:12:
> include/linux/kref.h: In function 'kref_get':
> include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use in this function)
> include/linux/kref.h:40: error: (Each undeclared identifier is reported only once
> include/linux/kref.h:40: error: for each function it appears in.)
> include/linux/kref.h: In function 'kref_sub':
> include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use in this function)
>
> It happens because TAINT_WARN is defined in kernel.h and this particular
> compile doesn't seem to include it (no idea why it's just
> manifesting ... probably some #include file untangling exposed it). Fix
> by adding #include <linux/kernel.h> to linux/kref.h
Does adding <linux/bug.h> fix it instead? We are using WARN_ON() here.
Hm, but that needs kernel.h as well, ugh, what a mess.
> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fix compile breakage with kref.h
2012-01-17 21:26 ` Greg Kroah-Hartman
@ 2012-01-17 22:09 ` Paul Gortmaker
0 siblings, 0 replies; 5+ messages in thread
From: Paul Gortmaker @ 2012-01-17 22:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: James Bottomley, Linus Torvalds, Andrew Morton, Parisc List,
linux-kernel
On Tue, Jan 17, 2012 at 4:26 PM, Greg Kroah-Hartman <greg@kroah.com> wr=
ote:
> On Tue, Jan 17, 2012 at 09:14:05PM +0000, James Bottomley wrote:
>> This set of build failures just started appearing on parisc:
>>
>> In file included from drivers/input/serio/serio_raw.c:12:
>> include/linux/kref.h: In function 'kref_get':
>> include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use i=
n this function)
>> include/linux/kref.h:40: error: (Each undeclared identifier is repor=
ted only once
>> include/linux/kref.h:40: error: for each function it appears in.)
>> include/linux/kref.h: In function 'kref_sub':
>> include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use i=
n this function)
>>
>> It happens because TAINT_WARN is defined in kernel.h and this partic=
ular
>> compile doesn't seem to include it (no idea why it's just
>> manifesting ... probably some #include file untangling exposed it). =
=A0Fix
>> by adding #include <linux/kernel.h> to linux/kref.h
>
> Does adding <linux/bug.h> fix it instead? =A0We are using WARN_ON() h=
ere.
> Hm, but that needs kernel.h as well, ugh, what a mess.
I've got some work done already towards cleaning this up; aiming for
getting it done and in linux-next for the 3.4 cycle.
https://lkml.org/lkml/2012/1/4/455
Paul.
---
>
>> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kerne=
l" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at =A0http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fix compile breakage with kref.h
@ 2012-01-17 22:09 ` Paul Gortmaker
0 siblings, 0 replies; 5+ messages in thread
From: Paul Gortmaker @ 2012-01-17 22:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: James Bottomley, Linus Torvalds, Andrew Morton, Parisc List,
linux-kernel
On Tue, Jan 17, 2012 at 4:26 PM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> On Tue, Jan 17, 2012 at 09:14:05PM +0000, James Bottomley wrote:
>> This set of build failures just started appearing on parisc:
>>
>> In file included from drivers/input/serio/serio_raw.c:12:
>> include/linux/kref.h: In function 'kref_get':
>> include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use in this function)
>> include/linux/kref.h:40: error: (Each undeclared identifier is reported only once
>> include/linux/kref.h:40: error: for each function it appears in.)
>> include/linux/kref.h: In function 'kref_sub':
>> include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use in this function)
>>
>> It happens because TAINT_WARN is defined in kernel.h and this particular
>> compile doesn't seem to include it (no idea why it's just
>> manifesting ... probably some #include file untangling exposed it). Fix
>> by adding #include <linux/kernel.h> to linux/kref.h
>
> Does adding <linux/bug.h> fix it instead? We are using WARN_ON() here.
> Hm, but that needs kernel.h as well, ugh, what a mess.
I've got some work done already towards cleaning this up; aiming for
getting it done and in linux-next for the 3.4 cycle.
https://lkml.org/lkml/2012/1/4/455
Paul.
---
>
>> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-17 22:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 21:14 Fix compile breakage with kref.h James Bottomley
2012-01-17 21:14 ` James Bottomley
2012-01-17 21:26 ` Greg Kroah-Hartman
2012-01-17 22:09 ` Paul Gortmaker
2012-01-17 22:09 ` Paul Gortmaker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.