All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	David Gibson
	<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Subject: Re: [PATCH 1/3] Device isolation group infrastructure (v3)
Date: Thu, 09 Feb 2012 08:39:28 +1100	[thread overview]
Message-ID: <1328737168.2903.35.camel@pasglop> (raw)
In-Reply-To: <20120208152748.GD22598-5C7GfCeVMHo@public.gmane.org>

On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote:
> Again, device grouping is done by the IOMMU drivers, so this all
> belongs
> into the generic iommu-code rather than the driver core.

Except that there isn't really a "generic iommu code"... discovery,
initialization & matching of iommu vs. devices etc... that's all
implemented in the arch specific iommu code.

Cheers,
Ben.
  
> I think it makes sense to introduce a device->iommu pointer which
> depends on CONFIG_IOMMU_API and put the group information into it.
> This also has the benefit that we can consolidate all the
> device->arch.iommu pointers into device->iommu as well.
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
	dwmw2@infradead.org, iommu@lists.linux-foundation.org,
	aik@ozlabs.ru, qemu-devel@nongnu.org, alex.williamson@redhat.com,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Device isolation group infrastructure (v3)
Date: Thu, 09 Feb 2012 08:39:28 +1100	[thread overview]
Message-ID: <1328737168.2903.35.camel@pasglop> (raw)
In-Reply-To: <20120208152748.GD22598@amd.com>

On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote:
> Again, device grouping is done by the IOMMU drivers, so this all
> belongs
> into the generic iommu-code rather than the driver core.

Except that there isn't really a "generic iommu code"... discovery,
initialization & matching of iommu vs. devices etc... that's all
implemented in the arch specific iommu code.

Cheers,
Ben.
  
> I think it makes sense to introduce a device->iommu pointer which
> depends on CONFIG_IOMMU_API and put the group information into it.
> This also has the benefit that we can consolidate all the
> device->arch.iommu pointers into device->iommu as well.
> 
> 


WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: kvm@vger.kernel.org, aik@ozlabs.ru, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, qemu-devel@nongnu.org,
	alex.williamson@redhat.com, dwmw2@infradead.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3)
Date: Thu, 09 Feb 2012 08:39:28 +1100	[thread overview]
Message-ID: <1328737168.2903.35.camel@pasglop> (raw)
In-Reply-To: <20120208152748.GD22598@amd.com>

On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote:
> Again, device grouping is done by the IOMMU drivers, so this all
> belongs
> into the generic iommu-code rather than the driver core.

Except that there isn't really a "generic iommu code"... discovery,
initialization & matching of iommu vs. devices etc... that's all
implemented in the arch specific iommu code.

Cheers,
Ben.
  
> I think it makes sense to introduce a device->iommu pointer which
> depends on CONFIG_IOMMU_API and put the group information into it.
> This also has the benefit that we can consolidate all the
> device->arch.iommu pointers into device->iommu as well.
> 
> 

  parent reply	other threads:[~2012-02-08 21:39 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01  4:46 RFC: Device isolation groups David Gibson
2012-02-01  4:46 ` [Qemu-devel] " David Gibson
2012-02-01  4:46 ` David Gibson
     [not found] ` <1328071614-8320-1-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
2012-02-01  4:46   ` [PATCH 1/3] Device isolation group infrastructure (v3) David Gibson
2012-02-01  4:46     ` [Qemu-devel] " David Gibson
2012-02-01  4:46     ` David Gibson
     [not found]     ` <1328071614-8320-2-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
2012-02-08 15:27       ` Joerg Roedel
2012-02-08 15:27         ` [Qemu-devel] " Joerg Roedel
2012-02-08 15:27         ` Joerg Roedel
     [not found]         ` <20120208152748.GD22598-5C7GfCeVMHo@public.gmane.org>
2012-02-08 21:39           ` Benjamin Herrenschmidt [this message]
2012-02-08 21:39             ` [Qemu-devel] " Benjamin Herrenschmidt
2012-02-08 21:39             ` Benjamin Herrenschmidt
2012-02-09 11:28             ` Joerg Roedel
2012-02-09 11:28               ` [Qemu-devel] " Joerg Roedel
2012-02-09 11:28               ` Joerg Roedel
     [not found]               ` <20120209112805.GN22598-5C7GfCeVMHo@public.gmane.org>
2012-02-10  0:21                 ` David Gibson
2012-02-10  0:21                   ` [Qemu-devel] " David Gibson
2012-02-10  0:21                   ` David Gibson
2012-02-08 21:43           ` Benjamin Herrenschmidt
2012-02-08 21:43             ` [Qemu-devel] " Benjamin Herrenschmidt
2012-02-08 21:43             ` Benjamin Herrenschmidt
2012-02-09  1:40         ` David Gibson
2012-02-09  1:40           ` [Qemu-devel] " David Gibson
2012-02-09  1:40           ` David Gibson
2012-02-01  4:46   ` [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges David Gibson
2012-02-01  4:46     ` [Qemu-devel] " David Gibson
2012-02-01  4:46     ` David Gibson
     [not found]     ` <1328071614-8320-3-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
2012-02-01 18:58       ` Alex Williamson
2012-02-01 18:58         ` [Qemu-devel] " Alex Williamson
2012-02-01 18:58         ` Alex Williamson
     [not found]         ` <1328122724.6937.216.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-02-01 19:15           ` Alex Williamson
2012-02-01 19:15             ` [Qemu-devel] " Alex Williamson
2012-02-01 19:15             ` Alex Williamson
2012-02-01  4:46   ` [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges David Gibson
2012-02-01  4:46     ` [Qemu-devel] " David Gibson
2012-02-01  4:46     ` David Gibson
     [not found]     ` <1328071614-8320-4-git-send-email-david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
2012-02-01 19:17       ` Alex Williamson
2012-02-01 19:17         ` [Qemu-devel] " Alex Williamson
2012-02-01 19:17         ` Alex Williamson
     [not found]         ` <1328123825.6937.227.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-02-02  0:23           ` David Gibson
2012-02-02  0:23             ` [Qemu-devel] " David Gibson
2012-02-02  0:23             ` David Gibson
2012-02-01 20:08   ` RFC: Device isolation groups Alex Williamson
2012-02-01 20:08     ` [Qemu-devel] " Alex Williamson
2012-02-01 20:08     ` Alex Williamson
     [not found]     ` <1328126919.6937.254.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-02-02  1:24       ` David Gibson
2012-02-02  1:24         ` [Qemu-devel] " David Gibson
2012-02-02  1:24         ` David Gibson
     [not found]         ` <20120202012414.GE8700-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-02-29 19:30           ` Alex Williamson
2012-02-29 19:30             ` [Qemu-devel] " Alex Williamson
2012-02-29 19:30             ` Alex Williamson
     [not found]             ` <1330543855.29701.180.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2012-03-09  3:40               ` David Gibson
2012-03-09  3:40                 ` [Qemu-devel] " David Gibson
2012-03-09  3:40                 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328737168.2903.35.camel@pasglop \
    --to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
    --cc=aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joerg.roedel-5C7GfCeVMHo@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.