[PATCH] drm/i915: enable gmbus on gen2

[PATCH] drm/i915: enable gmbus on gen2

[Daniel Vetter]

With the recent set of gmbus fixes, this seems to work on my i855gm.

Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_i2c.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index 601c86e..8f66397 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -388,10 +388,6 @@ int intel_setup_gmbus(struct drm_device *dev)
 		bus->reg0 = i | GMBUS_RATE_100KHZ;
 
 		bus->has_gpio = intel_gpio_setup(bus, i);
-
-		/* XXX force bit banging until GMBUS is fully debugged */
-		if (bus->has_gpio && IS_GEN2(dev))
-			bus->force_bit = true;
 	}
 
 	intel_i2c_reset(dev_priv->dev);
-- 
1.7.8.3

Re: [PATCH] drm/i915: enable gmbus on gen2

[Daniel Vetter]

Hi Chris,

Given that you're about the only other gen2 user I know ... can you ack
this patch for inclusion into 3.5?

Thanks, Daniel

On Fri, Mar 02, 2012 at 07:38:30PM +0100, Daniel Vetter wrote:
> With the recent set of gmbus fixes, this seems to work on my i855gm.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_i2c.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
> index 601c86e..8f66397 100644
> --- a/drivers/gpu/drm/i915/intel_i2c.c
> +++ b/drivers/gpu/drm/i915/intel_i2c.c
> @@ -388,10 +388,6 @@ int intel_setup_gmbus(struct drm_device *dev)
>  		bus->reg0 = i | GMBUS_RATE_100KHZ;
>  
>  		bus->has_gpio = intel_gpio_setup(bus, i);
> -
> -		/* XXX force bit banging until GMBUS is fully debugged */
> -		if (bus->has_gpio && IS_GEN2(dev))
> -			bus->force_bit = true;
>  	}
>  
>  	intel_i2c_reset(dev_priv->dev);
> -- 
> 1.7.8.3
> 

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

Re: [PATCH] drm/i915: enable gmbus on gen2

[Chris Wilson]

On Sat, 24 Mar 2012 16:08:44 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> Hi Chris,
> 
> Given that you're about the only other gen2 user I know ... can you ack
> this patch for inclusion into 3.5?

Sure, I'll start building a kernel for the 855gm.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] drm/i915: enable gmbus on gen2

[Chris Wilson]

On Sat, 24 Mar 2012 16:08:44 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> Hi Chris,
> 
> Given that you're about the only other gen2 user I know ... can you ack
> this patch for inclusion into 3.5?

It boots, but it didn't manage to acquire the EDID for CRT. Then again,
that fails using GPIO as well... (The good news is that it fails quicker
and quieter using GMBUS!)

So it appears to be no worse than before,
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] drm/i915: enable gmbus on gen2

[Daniel Vetter]

On Sun, Mar 25, 2012 at 09:45:02AM +0100, Chris Wilson wrote:
> On Sat, 24 Mar 2012 16:08:44 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> > Hi Chris,
> > 
> > Given that you're about the only other gen2 user I know ... can you ack
> > this patch for inclusion into 3.5?
> 
> It boots, but it didn't manage to acquire the EDID for CRT. Then again,
> that fails using GPIO as well... (The good news is that it fails quicker
> and quieter using GMBUS!)
> 
> So it appears to be no worse than before,
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>

Edid reading works here, both with gmbus and bit-banging. Thanks for
testing this, queued for -next.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48