All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Miao Xie <miaox@cn.fujitsu.com>,
	David Rientjes <rientjes@google.com>,
	Christoph Lameter <cl@linux.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3
Date: Mon, 26 Mar 2012 13:07:27 +0200	[thread overview]
Message-ID: <1332760047.16159.93.camel@twins> (raw)
In-Reply-To: <1332759384.16159.92.camel@twins>

On Mon, 2012-03-26 at 12:56 +0200, Peter Zijlstra wrote:
>  static inline bool put_mems_allowed(unsigned int seq)
>  {
> -       return !read_seqcount_retry(&current->mems_allowed_seq, seq);
> +       return likely(!read_seqcount_retry(&current->mems_allowed_seq, seq));
>  } 

Ignore this hunk, read_seqcount_retry() already has a branch hint in.
I'll send a new version if people thing the rest of the patch is worth
it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Miao Xie <miaox@cn.fujitsu.com>,
	David Rientjes <rientjes@google.com>,
	Christoph Lameter <cl@linux.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3
Date: Mon, 26 Mar 2012 13:07:27 +0200	[thread overview]
Message-ID: <1332760047.16159.93.camel@twins> (raw)
In-Reply-To: <1332759384.16159.92.camel@twins>

On Mon, 2012-03-26 at 12:56 +0200, Peter Zijlstra wrote:
>  static inline bool put_mems_allowed(unsigned int seq)
>  {
> -       return !read_seqcount_retry(&current->mems_allowed_seq, seq);
> +       return likely(!read_seqcount_retry(&current->mems_allowed_seq, seq));
>  } 

Ignore this hunk, read_seqcount_retry() already has a branch hint in.
I'll send a new version if people thing the rest of the patch is worth
it.

  reply	other threads:[~2012-03-26 11:08 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 18:08 [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3 Mel Gorman
2012-03-07 18:08 ` Mel Gorman
2012-03-26 10:56 ` Peter Zijlstra
2012-03-26 10:56   ` Peter Zijlstra
2012-03-26 11:07   ` Peter Zijlstra [this message]
2012-03-26 11:07     ` Peter Zijlstra
2012-03-26 15:50   ` Mel Gorman
2012-03-26 15:50     ` Mel Gorman
2012-03-26 16:20     ` Peter Zijlstra
2012-03-26 16:20       ` Peter Zijlstra
2012-03-27 12:47       ` Mel Gorman
2012-03-27 12:47         ` Mel Gorman
2012-03-27 13:14         ` [PATCH] mm: Optimize put_mems_allowed() usage Peter Zijlstra
2012-03-27 13:14           ` Peter Zijlstra
2012-05-17 10:33           ` Peter Zijlstra
2012-05-17 10:33             ` Peter Zijlstra
2012-05-17 20:16           ` Andrew Morton
2012-05-17 20:16             ` Andrew Morton
2012-05-17 20:23             ` Peter Zijlstra
2012-05-17 20:23               ` Peter Zijlstra
2012-05-18 10:20   ` [tip:sched/numa] " tip-bot for Peter Zijlstra
2013-08-23 13:03 ` [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3 Peter Zijlstra
2013-08-23 13:03   ` Peter Zijlstra
2013-08-23 18:15   ` Peter Zijlstra
2013-08-23 18:15     ` Peter Zijlstra
2013-08-26  5:32     ` Rik van Riel
2013-08-26  5:32       ` Rik van Riel
2013-08-29  9:28     ` Mel Gorman
2013-08-29  9:28       ` Mel Gorman
2013-08-29  9:43       ` Peter Zijlstra
2013-08-29  9:43         ` Peter Zijlstra
2013-08-29  9:45         ` Peter Zijlstra
2013-08-29  9:45           ` Peter Zijlstra
2013-08-29 10:56         ` Mel Gorman
2013-08-29 10:56           ` Mel Gorman
2013-08-29 11:14           ` Peter Zijlstra
2013-08-29 11:14             ` Peter Zijlstra
2013-08-29 12:10             ` Mel Gorman
2013-08-29 12:10               ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332760047.16159.93.camel@twins \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=miaox@cn.fujitsu.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.