From: Mel Gorman <mgorman@suse.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miao Xie <miaox@cn.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
riel@redhat.com
Subject: Re: [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3
Date: Thu, 29 Aug 2013 13:10:55 +0100 [thread overview]
Message-ID: <20130829121055.GE22421@suse.de> (raw)
In-Reply-To: <20130829111419.GA10002@twins.programming.kicks-ass.net>
On Thu, Aug 29, 2013 at 01:14:19PM +0200, Peter Zijlstra wrote:
> > I intended to say nr_node_ids, the same size as buffers such as the
> > task_numa_buffers. If we ever return a nid > nr_node_ids here then
> > task_numa_fault would corrupt memory. However, it should be possible for
> > node_weight to exceed nr_node_ids except maybe during node hot-remove so
> > it's not the problem.
>
> The nodemask situation seems somewhat more confused than the cpumask
> case; how would we ever return a nid > nr_node_ids? Corrupt nodemask?
>
ARGH. I meant impossible. The exact bloody opposite of what I wrote.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miao Xie <miaox@cn.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
riel@redhat.com
Subject: Re: [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3
Date: Thu, 29 Aug 2013 13:10:55 +0100 [thread overview]
Message-ID: <20130829121055.GE22421@suse.de> (raw)
In-Reply-To: <20130829111419.GA10002@twins.programming.kicks-ass.net>
On Thu, Aug 29, 2013 at 01:14:19PM +0200, Peter Zijlstra wrote:
> > I intended to say nr_node_ids, the same size as buffers such as the
> > task_numa_buffers. If we ever return a nid > nr_node_ids here then
> > task_numa_fault would corrupt memory. However, it should be possible for
> > node_weight to exceed nr_node_ids except maybe during node hot-remove so
> > it's not the problem.
>
> The nodemask situation seems somewhat more confused than the cpumask
> case; how would we ever return a nid > nr_node_ids? Corrupt nodemask?
>
ARGH. I meant impossible. The exact bloody opposite of what I wrote.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2013-08-29 12:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 18:08 [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3 Mel Gorman
2012-03-07 18:08 ` Mel Gorman
2012-03-26 10:56 ` Peter Zijlstra
2012-03-26 10:56 ` Peter Zijlstra
2012-03-26 11:07 ` Peter Zijlstra
2012-03-26 11:07 ` Peter Zijlstra
2012-03-26 15:50 ` Mel Gorman
2012-03-26 15:50 ` Mel Gorman
2012-03-26 16:20 ` Peter Zijlstra
2012-03-26 16:20 ` Peter Zijlstra
2012-03-27 12:47 ` Mel Gorman
2012-03-27 12:47 ` Mel Gorman
2012-03-27 13:14 ` [PATCH] mm: Optimize put_mems_allowed() usage Peter Zijlstra
2012-03-27 13:14 ` Peter Zijlstra
2012-05-17 10:33 ` Peter Zijlstra
2012-05-17 10:33 ` Peter Zijlstra
2012-05-17 20:16 ` Andrew Morton
2012-05-17 20:16 ` Andrew Morton
2012-05-17 20:23 ` Peter Zijlstra
2012-05-17 20:23 ` Peter Zijlstra
2012-05-18 10:20 ` [tip:sched/numa] " tip-bot for Peter Zijlstra
2013-08-23 13:03 ` [PATCH] cpuset: mm: Reduce large amounts of memory barrier related damage v3 Peter Zijlstra
2013-08-23 13:03 ` Peter Zijlstra
2013-08-23 18:15 ` Peter Zijlstra
2013-08-23 18:15 ` Peter Zijlstra
2013-08-26 5:32 ` Rik van Riel
2013-08-26 5:32 ` Rik van Riel
2013-08-29 9:28 ` Mel Gorman
2013-08-29 9:28 ` Mel Gorman
2013-08-29 9:43 ` Peter Zijlstra
2013-08-29 9:43 ` Peter Zijlstra
2013-08-29 9:45 ` Peter Zijlstra
2013-08-29 9:45 ` Peter Zijlstra
2013-08-29 10:56 ` Mel Gorman
2013-08-29 10:56 ` Mel Gorman
2013-08-29 11:14 ` Peter Zijlstra
2013-08-29 11:14 ` Peter Zijlstra
2013-08-29 12:10 ` Mel Gorman [this message]
2013-08-29 12:10 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829121055.GE22421@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miaox@cn.fujitsu.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.