* Re: [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm [not found] <20120406001738.706A810217@opal> @ 2012-04-10 8:38 ` Martin Jansa 2012-04-10 9:01 ` Martin Jansa 2012-04-10 9:06 ` Richard Purdie 0 siblings, 2 replies; 5+ messages in thread From: Martin Jansa @ 2012-04-10 8:38 UTC (permalink / raw) To: openembedded-core; +Cc: openembedded-commits [-- Attachment #1: Type: text/plain, Size: 2874 bytes --] On Fri, Apr 06, 2012 at 12:17:38AM +0000, git@git.openembedded.org wrote: > Module: openembedded-core.git > Branch: master > Commit: e4d2ee00419f675ba8b7fb5d75256762253d8b32 > URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e4d2ee00419f675ba8b7fb5d75256762253d8b32 > > Author: Andrei Gherzan <andrei@gherzan.ro> > Date: Fri Mar 23 17:56:29 2012 +0200 > > gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/gdbm > > ndbm.h is needed by python for dbm module. This is why -enable-libgdbm-compat was added > to configure. > The second change is because python is looking for the gdbm headers in include/gdbm. > The easiest way to solve this issue is to add symlinks in include/gdbm. > > [YOCTO #1937] > > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> This breaks every package in feed which depends on old package name libgdbm4 (>= 1.10) Because now there are 2 .so files in ${PN} and no LEAD_SONAME defined. Are you going to 1) send PR bumps to all packages which depends on libgdbm4 (e.g. apr-util python pulseaudio perl gst-plugins-good and probably more) 2) define LEAD_SONAME and bump PR in gdbm recipe 3) move -compat libs to ${PN}-compat or some other package name, so that old libgdbm4 still exists (and maybe + 1) because some people could build those with gdbm as dependency now) Cheers, > > --- > > meta/recipes-support/gdbm/gdbm_1.10.bb | 13 ++++++++++++- > 1 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-support/gdbm/gdbm_1.10.bb b/meta/recipes-support/gdbm/gdbm_1.10.bb > index 9b2fde4..26b8009 100644 > --- a/meta/recipes-support/gdbm/gdbm_1.10.bb > +++ b/meta/recipes-support/gdbm/gdbm_1.10.bb > @@ -4,7 +4,7 @@ SECTION = "libs" > LICENSE = "GPLv3" > LIC_FILES_CHKSUM = "file://COPYING;md5=241da1b9fe42e642cbb2c24d5e0c4d24" > > -PR = "r1" > +PR = "r2" > > SRC_URI = "${GNU_MIRROR}/gdbm/gdbm-${PV}.tar.gz" > > @@ -13,4 +13,15 @@ SRC_URI[sha256sum] = "23f8134c5b94bbfb06d756a6b78f074fba6e6028cf2fe01341d40b26db > > inherit autotools gettext lib_package > > +# Needed for dbm python module > +EXTRA_OECONF = "-enable-libgdbm-compat" > + > BBCLASSEXTEND = "native nativesdk" > + > +do_install_append () { > + # Create a symlink to ndbm.h and gdbm.h in include/gdbm to let other packages to find > + # these headers > + install -d ${D}${includedir}/gdbm > + ln -sf ../ndbm.h ${D}/${includedir}/gdbm/ndbm.h > + ln -sf ../gdbm.h ${D}/${includedir}/gdbm/gdbm.h > +} > > > _______________________________________________ > Openembedded-commits mailing list > Openembedded-commits@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm 2012-04-10 8:38 ` [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm Martin Jansa @ 2012-04-10 9:01 ` Martin Jansa 2012-04-10 9:06 ` Richard Purdie 1 sibling, 0 replies; 5+ messages in thread From: Martin Jansa @ 2012-04-10 9:01 UTC (permalink / raw) To: openembedded-core; +Cc: openembedded-commits [-- Attachment #1: Type: text/plain, Size: 4106 bytes --] On Tue, Apr 10, 2012 at 10:38:15AM +0200, Martin Jansa wrote: > On Fri, Apr 06, 2012 at 12:17:38AM +0000, git@git.openembedded.org wrote: > > Module: openembedded-core.git > > Branch: master > > Commit: e4d2ee00419f675ba8b7fb5d75256762253d8b32 > > URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e4d2ee00419f675ba8b7fb5d75256762253d8b32 > > > > Author: Andrei Gherzan <andrei@gherzan.ro> > > Date: Fri Mar 23 17:56:29 2012 +0200 > > > > gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/gdbm > > > > ndbm.h is needed by python for dbm module. This is why -enable-libgdbm-compat was added > > to configure. > > The second change is because python is looking for the gdbm headers in include/gdbm. > > The easiest way to solve this issue is to add symlinks in include/gdbm. > > > > [YOCTO #1937] > > > > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> > > This breaks every package in feed which depends on old package name > libgdbm4 (>= 1.10) > > Because now there are 2 .so files in ${PN} and no LEAD_SONAME defined. > > Are you going to > > 1) send PR bumps to all packages which depends on libgdbm4 > (e.g. apr-util python pulseaudio perl gst-plugins-good and probably more) > 2) define LEAD_SONAME and bump PR in gdbm recipe > 3) move -compat libs to ${PN}-compat or some other package name, so that > old libgdbm4 still exists (and maybe + 1) because some people could > build those with gdbm as dependency now) And there is also broken upgrade path on target SHR root@qemux86-64 ~ $ opkg info libgdbm4 Package: libgdbm4 Version: 1.10-r1 Depends: libc6 (>= 2.15) Provides: Status: install ok installed Architecture: x86_64 Installed-Time: 1332937981 SHR root@qemux86-64 ~ $ opkg info gdbm Package: gdbm Version: 1.10-r2 Depends: libc6 (>= 2.15) Provides: Status: unknown ok not-installed Section: libs Architecture: x86_64 Maintainer: OE-Core Developers <openembedded-core@lists.openembedded.org> MD5Sum: 7dc17a86738b55b5df2e5ee67cccc2ac Size: 20062 Filename: gdbm_1.10-r2_x86_64.ipk Source: ftp://ftp.gnu.org/gnu/gdbm/gdbm-1.10.tar.gz Description: gdbm version 1.10-r2 GNU dbm is a set of database routines that use extensible hashing. And gdbm conflicts with libgdbm4, so if you decide to go with just 1) then add also RCONFLICTS/RREPLACES to ${PN} to fix upgrade path.. but I think that 3) is much better option.. Cheers, > > > > > > --- > > > > meta/recipes-support/gdbm/gdbm_1.10.bb | 13 ++++++++++++- > > 1 files changed, 12 insertions(+), 1 deletions(-) > > > > diff --git a/meta/recipes-support/gdbm/gdbm_1.10.bb b/meta/recipes-support/gdbm/gdbm_1.10.bb > > index 9b2fde4..26b8009 100644 > > --- a/meta/recipes-support/gdbm/gdbm_1.10.bb > > +++ b/meta/recipes-support/gdbm/gdbm_1.10.bb > > @@ -4,7 +4,7 @@ SECTION = "libs" > > LICENSE = "GPLv3" > > LIC_FILES_CHKSUM = "file://COPYING;md5=241da1b9fe42e642cbb2c24d5e0c4d24" > > > > -PR = "r1" > > +PR = "r2" > > > > SRC_URI = "${GNU_MIRROR}/gdbm/gdbm-${PV}.tar.gz" > > > > @@ -13,4 +13,15 @@ SRC_URI[sha256sum] = "23f8134c5b94bbfb06d756a6b78f074fba6e6028cf2fe01341d40b26db > > > > inherit autotools gettext lib_package > > > > +# Needed for dbm python module > > +EXTRA_OECONF = "-enable-libgdbm-compat" > > + > > BBCLASSEXTEND = "native nativesdk" > > + > > +do_install_append () { > > + # Create a symlink to ndbm.h and gdbm.h in include/gdbm to let other packages to find > > + # these headers > > + install -d ${D}${includedir}/gdbm > > + ln -sf ../ndbm.h ${D}/${includedir}/gdbm/ndbm.h > > + ln -sf ../gdbm.h ${D}/${includedir}/gdbm/gdbm.h > > +} > > > > > > _______________________________________________ > > Openembedded-commits mailing list > > Openembedded-commits@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm 2012-04-10 8:38 ` [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm Martin Jansa 2012-04-10 9:01 ` Martin Jansa @ 2012-04-10 9:06 ` Richard Purdie 2012-04-10 9:11 ` Koen Kooi 1 sibling, 1 reply; 5+ messages in thread From: Richard Purdie @ 2012-04-10 9:06 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: openembedded-commits On Tue, 2012-04-10 at 10:38 +0200, Martin Jansa wrote: > On Fri, Apr 06, 2012 at 12:17:38AM +0000, git@git.openembedded.org wrote: > > Module: openembedded-core.git > > Branch: master > > Commit: e4d2ee00419f675ba8b7fb5d75256762253d8b32 > > URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e4d2ee00419f675ba8b7fb5d75256762253d8b32 > > > > Author: Andrei Gherzan <andrei@gherzan.ro> > > Date: Fri Mar 23 17:56:29 2012 +0200 > > > > gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/gdbm > > > > ndbm.h is needed by python for dbm module. This is why -enable-libgdbm-compat was added > > to configure. > > The second change is because python is looking for the gdbm headers in include/gdbm. > > The easiest way to solve this issue is to add symlinks in include/gdbm. > > > > [YOCTO #1937] > > > > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> > > This breaks every package in feed which depends on old package name > libgdbm4 (>= 1.10) > > Because now there are 2 .so files in ${PN} and no LEAD_SONAME defined. > > Are you going to > > 1) send PR bumps to all packages which depends on libgdbm4 > (e.g. apr-util python pulseaudio perl gst-plugins-good and probably more) > 2) define LEAD_SONAME and bump PR in gdbm recipe > 3) move -compat libs to ${PN}-compat or some other package name, so that > old libgdbm4 still exists (and maybe + 1) because some people could > build those with gdbm as dependency now) I like the idea of putting the compat libs into a separate package... Cheers, Richard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm 2012-04-10 9:06 ` Richard Purdie @ 2012-04-10 9:11 ` Koen Kooi 2012-04-10 16:04 ` Andrei Gherzan 0 siblings, 1 reply; 5+ messages in thread From: Koen Kooi @ 2012-04-10 9:11 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: openembedded-commits Op 10 apr. 2012, om 11:06 heeft Richard Purdie het volgende geschreven: > On Tue, 2012-04-10 at 10:38 +0200, Martin Jansa wrote: >> On Fri, Apr 06, 2012 at 12:17:38AM +0000, git@git.openembedded.org wrote: >>> Module: openembedded-core.git >>> Branch: master >>> Commit: e4d2ee00419f675ba8b7fb5d75256762253d8b32 >>> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e4d2ee00419f675ba8b7fb5d75256762253d8b32 >>> >>> Author: Andrei Gherzan <andrei@gherzan.ro> >>> Date: Fri Mar 23 17:56:29 2012 +0200 >>> >>> gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/gdbm >>> >>> ndbm.h is needed by python for dbm module. This is why -enable-libgdbm-compat was added >>> to configure. >>> The second change is because python is looking for the gdbm headers in include/gdbm. >>> The easiest way to solve this issue is to add symlinks in include/gdbm. >>> >>> [YOCTO #1937] >>> >>> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> >> >> This breaks every package in feed which depends on old package name >> libgdbm4 (>= 1.10) >> >> Because now there are 2 .so files in ${PN} and no LEAD_SONAME defined. >> >> Are you going to >> >> 1) send PR bumps to all packages which depends on libgdbm4 >> (e.g. apr-util python pulseaudio perl gst-plugins-good and probably more) >> 2) define LEAD_SONAME and bump PR in gdbm recipe >> 3) move -compat libs to ${PN}-compat or some other package name, so that >> old libgdbm4 still exists (and maybe + 1) because some people could >> build those with gdbm as dependency now) > > I like the idea of putting the compat libs into a separate package... me too regards, Koen ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm 2012-04-10 9:11 ` Koen Kooi @ 2012-04-10 16:04 ` Andrei Gherzan 0 siblings, 0 replies; 5+ messages in thread From: Andrei Gherzan @ 2012-04-10 16:04 UTC (permalink / raw) To: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 2183 bytes --] Thanks a lot for your observations. I will go with the third option as the majority voted. :) On Tue, Apr 10, 2012 at 12:11, Koen Kooi <koen@dominion.thruhere.net> wrote: > > Op 10 apr. 2012, om 11:06 heeft Richard Purdie het volgende geschreven: > > > On Tue, 2012-04-10 at 10:38 +0200, Martin Jansa wrote: > >> On Fri, Apr 06, 2012 at 12:17:38AM +0000, git@git.openembedded.orgwrote: > >>> Module: openembedded-core.git > >>> Branch: master > >>> Commit: e4d2ee00419f675ba8b7fb5d75256762253d8b32 > >>> URL: > http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e4d2ee00419f675ba8b7fb5d75256762253d8b32 > >>> > >>> Author: Andrei Gherzan <andrei@gherzan.ro> > >>> Date: Fri Mar 23 17:56:29 2012 +0200 > >>> > >>> gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in > include/gdbm > >>> > >>> ndbm.h is needed by python for dbm module. This is why > -enable-libgdbm-compat was added > >>> to configure. > >>> The second change is because python is looking for the gdbm headers in > include/gdbm. > >>> The easiest way to solve this issue is to add symlinks in include/gdbm. > >>> > >>> [YOCTO #1937] > >>> > >>> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro> > >> > >> This breaks every package in feed which depends on old package name > >> libgdbm4 (>= 1.10) > >> > >> Because now there are 2 .so files in ${PN} and no LEAD_SONAME defined. > >> > >> Are you going to > >> > >> 1) send PR bumps to all packages which depends on libgdbm4 > >> (e.g. apr-util python pulseaudio perl gst-plugins-good and probably > more) > >> 2) define LEAD_SONAME and bump PR in gdbm recipe > >> 3) move -compat libs to ${PN}-compat or some other package name, so that > >> old libgdbm4 still exists (and maybe + 1) because some people could > >> build those with gdbm as dependency now) > > > > I like the idea of putting the compat libs into a separate package... > > me too > > regards, > > Koen > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 3403 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-10 16:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120406001738.706A810217@opal>
2012-04-10 8:38 ` [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm Martin Jansa
2012-04-10 9:01 ` Martin Jansa
2012-04-10 9:06 ` Richard Purdie
2012-04-10 9:11 ` Koen Kooi
2012-04-10 16:04 ` Andrei Gherzan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.