From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: check PPS regs for sanity when using eDP
Date: Tue, 10 Apr 2012 22:26:56 +0100 [thread overview]
Message-ID: <1334093218_352690@CP5-2952> (raw)
In-Reply-To: <1334084285-4770-2-git-send-email-jbarnes@virtuousgeek.org>
On Tue, 10 Apr 2012 11:58:04 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> If these regs don't have valid values, the panel won't come up, and may
> even cause a system hang. So do a basic sanity check when an eDP panel
> is detected.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Other than adding a cleanup: error path (definitely before the third
person cut'n'pastes the intel_dp*destroy()), and that checking for zero
seems a little crude,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-10 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 18:58 [PATCH 1/3] drm/i915: make DP configuration vars less confusing in ironlake_crtc_mode_se Jesse Barnes
2012-04-10 18:58 ` [PATCH 2/3] drm/i915: check PPS regs for sanity when using eDP Jesse Barnes
2012-04-10 18:59 ` Jesse Barnes
2012-04-10 21:26 ` Chris Wilson [this message]
2012-04-11 16:04 ` Daniel Vetter
2012-04-10 18:58 ` [PATCH 3/3] drm/i915: allow PCH PWM override on IVB Jesse Barnes
2012-04-10 21:50 ` Daniel Vetter
2012-04-10 22:00 ` Jesse Barnes
2012-04-10 21:22 ` [PATCH 1/3] drm/i915: make DP configuration vars less confusing in ironlake_crtc_mode_se Chris Wilson
2012-04-11 9:53 ` Daniel Vetter
2012-04-11 15:56 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334093218_352690@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.