From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers
Date: Thu, 19 Apr 2012 12:00:24 +0000 [thread overview]
Message-ID: <1334836824.1911.46.camel@deskari> (raw)
In-Reply-To: <4F8FFDD5.5030302@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]
On Thu, 2012-04-19 at 17:28 +0530, Archit Taneja wrote:
> On Thursday 19 April 2012 05:18 PM, Tomi Valkeinen wrote:
> > On Mon, 2012-04-16 at 12:53 +0530, Archit Taneja wrote:
> >> An overlay manager's timings (the manager size, and blanking parameters if an
> >> LCD manager) are DISPC shadow registers, and they should hence follow the
> >> correct programming model.
> >>
> >> This set makes the timings a manager_info parameter. The interface drivers now
> >> set the timings in manager_info instead of directly writing to registers.
> >>
> >> This change also prevents the need to use display resolution for overlay
> >> checks, hence making some of the APPLY functions less dependent on the display.
> >>
> >> These patches apply over:
> >>
> >> git://gitorious.org/linux-omap-dss2/linux.git dev
> >>
> >> Archit Taneja (6):
> >> OMAPDSS: DISPC/RFBI: Use dispc_mgr_set_lcd_timings() for setting lcd
> >> size
> >> OMAPDSS: DISPC: Use a common function to set manager timings
> >> OMAPDSS: DISPC: Clean up manager timing/size functions
> >> OMAPDSS: MANAGER: Make DISPC timings a manager_info parameter
> >> OMAPDSS: MANAGER: Check validity of manager timings
> >> OMAPDSS: APPLY: Remove display dependency from overlay and manager
> >> checks
> >
> > The patches 1, 2 and 3 in this series look like independent cleanups.
> > Should I apply those, or do you think there may be changes required?
>
> I think you can pull these 3, they were sort of a prerequisite for the
> apply-manager-timings stuff. I don't think they need to change.
>
> I'll post another series for applying the manager timings correctly(i.e,
> the fixed version of the last 3 patches).
Ok, I applied the first three patches to my dev branch.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers
Date: Thu, 19 Apr 2012 15:00:24 +0300 [thread overview]
Message-ID: <1334836824.1911.46.camel@deskari> (raw)
In-Reply-To: <4F8FFDD5.5030302@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]
On Thu, 2012-04-19 at 17:28 +0530, Archit Taneja wrote:
> On Thursday 19 April 2012 05:18 PM, Tomi Valkeinen wrote:
> > On Mon, 2012-04-16 at 12:53 +0530, Archit Taneja wrote:
> >> An overlay manager's timings (the manager size, and blanking parameters if an
> >> LCD manager) are DISPC shadow registers, and they should hence follow the
> >> correct programming model.
> >>
> >> This set makes the timings a manager_info parameter. The interface drivers now
> >> set the timings in manager_info instead of directly writing to registers.
> >>
> >> This change also prevents the need to use display resolution for overlay
> >> checks, hence making some of the APPLY functions less dependent on the display.
> >>
> >> These patches apply over:
> >>
> >> git://gitorious.org/linux-omap-dss2/linux.git dev
> >>
> >> Archit Taneja (6):
> >> OMAPDSS: DISPC/RFBI: Use dispc_mgr_set_lcd_timings() for setting lcd
> >> size
> >> OMAPDSS: DISPC: Use a common function to set manager timings
> >> OMAPDSS: DISPC: Clean up manager timing/size functions
> >> OMAPDSS: MANAGER: Make DISPC timings a manager_info parameter
> >> OMAPDSS: MANAGER: Check validity of manager timings
> >> OMAPDSS: APPLY: Remove display dependency from overlay and manager
> >> checks
> >
> > The patches 1, 2 and 3 in this series look like independent cleanups.
> > Should I apply those, or do you think there may be changes required?
>
> I think you can pull these 3, they were sort of a prerequisite for the
> apply-manager-timings stuff. I don't think they need to change.
>
> I'll post another series for applying the manager timings correctly(i.e,
> the fixed version of the last 3 patches).
Ok, I applied the first three patches to my dev branch.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-19 12:00 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 7:23 [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-16 7:23 ` [PATCH 1/6] OMAPDSS: DISPC/RFBI: Use dispc_mgr_set_lcd_timings() for setting lcd size Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-16 7:23 ` [PATCH 2/6] OMAPDSS: DISPC: Use a common function to set manager timings Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-16 7:23 ` [PATCH 3/6] OMAPDSS: DISPC: Clean up manager timing/size functions Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-16 7:23 ` [PATCH 4/6] OMAPDSS: MANAGER: Make DISPC timings a manager_info parameter Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-18 14:58 ` Tomi Valkeinen
2012-04-18 14:58 ` Tomi Valkeinen
2012-04-19 6:13 ` Archit Taneja
2012-04-19 6:25 ` Archit Taneja
2012-04-19 6:37 ` Tomi Valkeinen
2012-04-19 6:37 ` Tomi Valkeinen
2012-04-19 10:08 ` Archit Taneja
2012-04-19 10:20 ` Archit Taneja
2012-04-19 11:37 ` Tomi Valkeinen
2012-04-19 11:37 ` Tomi Valkeinen
2012-04-16 7:23 ` [PATCH 5/6] OMAPDSS: MANAGER: Check validity of manager timings Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-16 7:23 ` [PATCH 6/6] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-04-16 7:35 ` Archit Taneja
2012-04-19 11:48 ` [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Tomi Valkeinen
2012-04-19 11:48 ` Tomi Valkeinen
2012-04-19 11:58 ` Archit Taneja
2012-04-19 12:10 ` Archit Taneja
2012-04-19 12:00 ` Tomi Valkeinen [this message]
2012-04-19 12:00 ` Tomi Valkeinen
2012-05-03 7:07 ` [PATCH v2 0/4] " Archit Taneja
2012-05-03 7:19 ` Archit Taneja
2012-05-03 7:07 ` [PATCH v2 1/4] OMAPDSS: APPLY: Add manager timings as extra_info in private data Archit Taneja
2012-05-03 7:19 ` Archit Taneja
2012-05-07 14:47 ` Tomi Valkeinen
2012-05-07 14:47 ` Tomi Valkeinen
2012-05-08 4:24 ` Archit Taneja
2012-05-08 4:36 ` Archit Taneja
2012-05-08 7:01 ` Tomi Valkeinen
2012-05-08 7:01 ` Tomi Valkeinen
2012-05-03 7:07 ` [PATCH v2 2/4] OMAPDSS: Apply manager timings instead of direct DISPC writes Archit Taneja
2012-05-03 7:19 ` Archit Taneja
2012-05-03 7:07 ` [PATCH v2 3/4] OMAPDSS: MANAGER: Create a function to check manager timings Archit Taneja
2012-05-03 7:19 ` Archit Taneja
2012-05-03 7:07 ` [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-05-03 7:19 ` Archit Taneja
2012-05-07 15:03 ` Tomi Valkeinen
2012-05-07 15:03 ` Tomi Valkeinen
2012-05-08 5:03 ` Archit Taneja
2012-05-08 5:15 ` Archit Taneja
2012-05-08 7:16 ` Tomi Valkeinen
2012-05-08 7:16 ` Tomi Valkeinen
2012-05-08 7:38 ` Archit Taneja
2012-05-08 7:50 ` Archit Taneja
2012-05-08 8:52 ` Tomi Valkeinen
2012-05-08 8:52 ` Tomi Valkeinen
2012-05-08 9:07 ` Archit Taneja
2012-05-08 9:19 ` Archit Taneja
2012-05-08 9:58 ` [PATCH v3 0/5] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Archit Taneja
2012-05-08 10:10 ` Archit Taneja
2012-05-08 9:58 ` [PATCH v3 1/5] OMAPDSS: APPLY: Add manager timings as extra_info in private data Archit Taneja
2012-05-08 10:10 ` Archit Taneja
2012-05-08 9:58 ` [PATCH v3 2/5] OMAPDSS: Apply manager timings instead of direct DISPC writes Archit Taneja
2012-05-08 10:10 ` Archit Taneja
2012-05-08 10:59 ` Tomi Valkeinen
2012-05-08 10:59 ` Tomi Valkeinen
2012-05-08 9:58 ` [PATCH v3 3/5] OMAPDSS: MANAGER: Create a function to check manager timings Archit Taneja
2012-05-08 10:10 ` Archit Taneja
2012-05-08 9:58 ` [PATCH v3 4/5] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-05-08 10:10 ` Archit Taneja
2012-05-08 10:50 ` Tomi Valkeinen
2012-05-08 10:50 ` Tomi Valkeinen
2012-05-08 11:22 ` Archit Taneja
2012-05-08 11:34 ` Archit Taneja
2012-05-08 11:55 ` Tomi Valkeinen
2012-05-08 11:55 ` Tomi Valkeinen
2012-05-08 12:35 ` Archit Taneja
2012-05-08 12:47 ` Archit Taneja
2012-05-09 9:53 ` Archit Taneja
2012-05-09 9:56 ` Archit Taneja
2012-05-09 10:15 ` Tomi Valkeinen
2012-05-09 10:15 ` Tomi Valkeinen
2012-05-08 9:58 ` [PATCH v3 5/5] OMAPDSS: DPI/HDMI: Apply manager timings even if panel is disabled Archit Taneja
2012-05-08 10:10 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 1/9] OMAPDSS: APPLY: Add manager timings as extra_info in private data Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 2/9] OMAPDSS: Apply manager timings instead of direct DISPC writes Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 3/9] OMAPDSS: MANAGER: Create a function to check manager timings Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 4/9] OMAPDSS: APPLY: Don't check manager settings if it is disabled Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 5/9] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 6/9] OMAPDSS: DPI/HDMI: Apply manager timings even if panel is disabled Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 7/9] OMAPDSS: APPLY: Remove an unnecessary omap_dss_device pointer Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 8/9] OMAPDSS: DISPC: Remove omap_dss_device pointer usage from dispc_mgr_pclk_rate() Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 9/9] OMAPDSS: DISPC: Remove usage of dispc_mgr_get_device() Archit Taneja
2012-05-09 10:22 ` Archit Taneja
2012-05-09 11:13 ` [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Tomi Valkeinen
2012-05-09 11:13 ` Tomi Valkeinen
2012-05-09 11:24 ` Archit Taneja
2012-05-09 11:36 ` Archit Taneja
2012-05-09 11:51 ` Tomi Valkeinen
2012-05-09 11:51 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334836824.1911.46.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=a0393947@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.