All of lore.kernel.org
 help / color / mirror / Atom feed
From: Archit Taneja <a0393947@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers
Date: Wed, 09 May 2012 11:36:26 +0000	[thread overview]
Message-ID: <4FAA53EA.7040400@ti.com> (raw)
In-Reply-To: <1336561991.3962.31.camel@deskari>

On Wednesday 09 May 2012 04:43 PM, Tomi Valkeinen wrote:
> On Wed, 2012-05-09 at 15:40 +0530, Archit Taneja wrote:
>> An overlay manager's timings (the manager size, and blanking parameters if an
>> LCD manager) are DISPC shadow registers, and they should hence follow the
>> correct programming model.
>>
>> This set makes the timings an extra_info parameter in manager's private data .
>> The interface drivers now apply the timings in instead of directly writing to
>> registers.
>>
>> This change also prevents the need to use display resolution for overlay
>> checks, hence making some of the APPLY functions less dependent on the display.
>> Some DISPC functions that needed display width can also use these privately
>> stored timings.
>>
>> Changes since v3:
>>
>> - Remove direct setting of go bit in dpi_set_timings()
>> - Take some of the patches in "OMAPDSS: Misc fixes and cleanups" and make them a
>>    part of this series as they are more related.
>> - Don't have an initial set of manager timings in private data, only check
>>    manager and overlay parameters once the manager is enabled.
>>
>> These patches apply over:
>>
>> git://gitorious.org/linux-omap-dss2/linux.git dev
>>
>> Reference tree containing this series:
>>
>> git://gitorious.org/~boddob/linux-omap-dss2/archit-dss2-clone.git mgr_timing_and_fixes_2
>>
>> Tested on OMAP4 SDP and Panda.
>
> I did some quick tests on omap3 overo, worked fine. I'll merge to dss
> master branch.

Russ did some tests on more omap3 boards, the tree which he used has 
some slight changes comapred to what I have posted, but it's more or 
less the same.

Could you add 'Tested-by: Russ.Dill@ti.com' if not too difficult, I 
missed out doing that.

Thanks,
Archit


>
>   Tomi
>


WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <a0393947@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers
Date: Wed, 9 May 2012 16:54:26 +0530	[thread overview]
Message-ID: <4FAA53EA.7040400@ti.com> (raw)
In-Reply-To: <1336561991.3962.31.camel@deskari>

On Wednesday 09 May 2012 04:43 PM, Tomi Valkeinen wrote:
> On Wed, 2012-05-09 at 15:40 +0530, Archit Taneja wrote:
>> An overlay manager's timings (the manager size, and blanking parameters if an
>> LCD manager) are DISPC shadow registers, and they should hence follow the
>> correct programming model.
>>
>> This set makes the timings an extra_info parameter in manager's private data .
>> The interface drivers now apply the timings in instead of directly writing to
>> registers.
>>
>> This change also prevents the need to use display resolution for overlay
>> checks, hence making some of the APPLY functions less dependent on the display.
>> Some DISPC functions that needed display width can also use these privately
>> stored timings.
>>
>> Changes since v3:
>>
>> - Remove direct setting of go bit in dpi_set_timings()
>> - Take some of the patches in "OMAPDSS: Misc fixes and cleanups" and make them a
>>    part of this series as they are more related.
>> - Don't have an initial set of manager timings in private data, only check
>>    manager and overlay parameters once the manager is enabled.
>>
>> These patches apply over:
>>
>> git://gitorious.org/linux-omap-dss2/linux.git dev
>>
>> Reference tree containing this series:
>>
>> git://gitorious.org/~boddob/linux-omap-dss2/archit-dss2-clone.git mgr_timing_and_fixes_2
>>
>> Tested on OMAP4 SDP and Panda.
>
> I did some quick tests on omap3 overo, worked fine. I'll merge to dss
> master branch.

Russ did some tests on more omap3 boards, the tree which he used has 
some slight changes comapred to what I have posted, but it's more or 
less the same.

Could you add 'Tested-by: Russ.Dill@ti.com' if not too difficult, I 
missed out doing that.

Thanks,
Archit


>
>   Tomi
>


  reply	other threads:[~2012-05-09 11:36 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  7:23 [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Archit Taneja
2012-04-16  7:35 ` Archit Taneja
2012-04-16  7:23 ` [PATCH 1/6] OMAPDSS: DISPC/RFBI: Use dispc_mgr_set_lcd_timings() for setting lcd size Archit Taneja
2012-04-16  7:35   ` Archit Taneja
2012-04-16  7:23 ` [PATCH 2/6] OMAPDSS: DISPC: Use a common function to set manager timings Archit Taneja
2012-04-16  7:35   ` Archit Taneja
2012-04-16  7:23 ` [PATCH 3/6] OMAPDSS: DISPC: Clean up manager timing/size functions Archit Taneja
2012-04-16  7:35   ` Archit Taneja
2012-04-16  7:23 ` [PATCH 4/6] OMAPDSS: MANAGER: Make DISPC timings a manager_info parameter Archit Taneja
2012-04-16  7:35   ` Archit Taneja
2012-04-18 14:58   ` Tomi Valkeinen
2012-04-18 14:58     ` Tomi Valkeinen
2012-04-19  6:13     ` Archit Taneja
2012-04-19  6:25       ` Archit Taneja
2012-04-19  6:37       ` Tomi Valkeinen
2012-04-19  6:37         ` Tomi Valkeinen
2012-04-19 10:08         ` Archit Taneja
2012-04-19 10:20           ` Archit Taneja
2012-04-19 11:37           ` Tomi Valkeinen
2012-04-19 11:37             ` Tomi Valkeinen
2012-04-16  7:23 ` [PATCH 5/6] OMAPDSS: MANAGER: Check validity of manager timings Archit Taneja
2012-04-16  7:35   ` Archit Taneja
2012-04-16  7:23 ` [PATCH 6/6] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-04-16  7:35   ` Archit Taneja
2012-04-19 11:48 ` [PATCH 0/6] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Tomi Valkeinen
2012-04-19 11:48   ` Tomi Valkeinen
2012-04-19 11:58   ` Archit Taneja
2012-04-19 12:10     ` Archit Taneja
2012-04-19 12:00     ` Tomi Valkeinen
2012-04-19 12:00       ` Tomi Valkeinen
2012-05-03  7:07 ` [PATCH v2 0/4] " Archit Taneja
2012-05-03  7:19   ` Archit Taneja
2012-05-03  7:07   ` [PATCH v2 1/4] OMAPDSS: APPLY: Add manager timings as extra_info in private data Archit Taneja
2012-05-03  7:19     ` Archit Taneja
2012-05-07 14:47     ` Tomi Valkeinen
2012-05-07 14:47       ` Tomi Valkeinen
2012-05-08  4:24       ` Archit Taneja
2012-05-08  4:36         ` Archit Taneja
2012-05-08  7:01         ` Tomi Valkeinen
2012-05-08  7:01           ` Tomi Valkeinen
2012-05-03  7:07   ` [PATCH v2 2/4] OMAPDSS: Apply manager timings instead of direct DISPC writes Archit Taneja
2012-05-03  7:19     ` Archit Taneja
2012-05-03  7:07   ` [PATCH v2 3/4] OMAPDSS: MANAGER: Create a function to check manager timings Archit Taneja
2012-05-03  7:19     ` Archit Taneja
2012-05-03  7:07   ` [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-05-03  7:19     ` Archit Taneja
2012-05-07 15:03     ` Tomi Valkeinen
2012-05-07 15:03       ` Tomi Valkeinen
2012-05-08  5:03       ` Archit Taneja
2012-05-08  5:15         ` Archit Taneja
2012-05-08  7:16         ` Tomi Valkeinen
2012-05-08  7:16           ` Tomi Valkeinen
2012-05-08  7:38           ` Archit Taneja
2012-05-08  7:50             ` Archit Taneja
2012-05-08  8:52             ` Tomi Valkeinen
2012-05-08  8:52               ` Tomi Valkeinen
2012-05-08  9:07               ` Archit Taneja
2012-05-08  9:19                 ` Archit Taneja
2012-05-08  9:58 ` [PATCH v3 0/5] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Archit Taneja
2012-05-08 10:10   ` Archit Taneja
2012-05-08  9:58   ` [PATCH v3 1/5] OMAPDSS: APPLY: Add manager timings as extra_info in private data Archit Taneja
2012-05-08 10:10     ` Archit Taneja
2012-05-08  9:58   ` [PATCH v3 2/5] OMAPDSS: Apply manager timings instead of direct DISPC writes Archit Taneja
2012-05-08 10:10     ` Archit Taneja
2012-05-08 10:59     ` Tomi Valkeinen
2012-05-08 10:59       ` Tomi Valkeinen
2012-05-08  9:58   ` [PATCH v3 3/5] OMAPDSS: MANAGER: Create a function to check manager timings Archit Taneja
2012-05-08 10:10     ` Archit Taneja
2012-05-08  9:58   ` [PATCH v3 4/5] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-05-08 10:10     ` Archit Taneja
2012-05-08 10:50     ` Tomi Valkeinen
2012-05-08 10:50       ` Tomi Valkeinen
2012-05-08 11:22       ` Archit Taneja
2012-05-08 11:34         ` Archit Taneja
2012-05-08 11:55         ` Tomi Valkeinen
2012-05-08 11:55           ` Tomi Valkeinen
2012-05-08 12:35           ` Archit Taneja
2012-05-08 12:47             ` Archit Taneja
2012-05-09  9:53             ` Archit Taneja
2012-05-09  9:56               ` Archit Taneja
2012-05-09 10:15               ` Tomi Valkeinen
2012-05-09 10:15                 ` Tomi Valkeinen
2012-05-08  9:58   ` [PATCH v3 5/5] OMAPDSS: DPI/HDMI: Apply manager timings even if panel is disabled Archit Taneja
2012-05-08 10:10     ` Archit Taneja
2012-05-09 10:10 ` [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Archit Taneja
2012-05-09 10:22   ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 1/9] OMAPDSS: APPLY: Add manager timings as extra_info in private data Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 2/9] OMAPDSS: Apply manager timings instead of direct DISPC writes Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 3/9] OMAPDSS: MANAGER: Create a function to check manager timings Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 4/9] OMAPDSS: APPLY: Don't check manager settings if it is disabled Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 5/9] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 6/9] OMAPDSS: DPI/HDMI: Apply manager timings even if panel is disabled Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 7/9] OMAPDSS: APPLY: Remove an unnecessary omap_dss_device pointer Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 8/9] OMAPDSS: DISPC: Remove omap_dss_device pointer usage from dispc_mgr_pclk_rate() Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 10:10   ` [PATCH v4 9/9] OMAPDSS: DISPC: Remove usage of dispc_mgr_get_device() Archit Taneja
2012-05-09 10:22     ` Archit Taneja
2012-05-09 11:13   ` [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers Tomi Valkeinen
2012-05-09 11:13     ` Tomi Valkeinen
2012-05-09 11:24     ` Archit Taneja [this message]
2012-05-09 11:36       ` Archit Taneja
2012-05-09 11:51       ` Tomi Valkeinen
2012-05-09 11:51         ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAA53EA.7040400@ti.com \
    --to=a0393947@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.