All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Andre Heider" <a.heider@gmail.com>, "Michael Büsch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))
Date: Fri, 08 Jun 2012 17:44:47 +0200	[thread overview]
Message-ID: <1339170287.5748.8.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1339170182.5748.7.camel@jlt3.sipsolutions.net> (sfid-20120608_174309_875550_ADC4A235)

On Fri, 2012-06-08 at 17:43 +0200, Johannes Berg wrote:
> On Fri, 2012-06-08 at 10:38 -0500, Larry Finger wrote:
> 
> > I got the same result as Andre when using open-source firmware - endless MAC 
> > suspend failures. It works OK with the proprietary fw, with or without a "qos=0" 
> > module parameter.
> 
> I just noticed one more bug -- I need to number the ACs the other way
> around, changing
> 	vif->hw_queue[i] = i;
> to
> 	vif->hw_queue[i] = 3 - i;
> 
> in main.c, because 0 is BK and 3 is VO, rather than 0 VO/3 BK like in
> mac80211.
> 
> http://p.sipsolutions.net/449d71a3c76656f1.txt

Ahrg! I keep numbering them wrong, this should be fixed:
http://p.sipsolutions.net/3bbdb9c6294dad70.txt

johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Andre Heider" <a.heider@gmail.com>, "Michael Büsch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))
Date: Fri, 08 Jun 2012 17:44:47 +0200	[thread overview]
Message-ID: <1339170287.5748.8.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1339170182.5748.7.camel@jlt3.sipsolutions.net> (sfid-20120608_174309_875550_ADC4A235)

On Fri, 2012-06-08 at 17:43 +0200, Johannes Berg wrote:
> On Fri, 2012-06-08 at 10:38 -0500, Larry Finger wrote:
> 
> > I got the same result as Andre when using open-source firmware - endless MAC 
> > suspend failures. It works OK with the proprietary fw, with or without a "qos=0" 
> > module parameter.
> 
> I just noticed one more bug -- I need to number the ACs the other way
> around, changing
> 	vif->hw_queue[i] = i;
> to
> 	vif->hw_queue[i] = 3 - i;
> 
> in main.c, because 0 is BK and 3 is VO, rather than 0 VO/3 BK like in
> mac80211.
> 
> http://p.sipsolutions.net/449d71a3c76656f1.txt

Ahrg! I keep numbering them wrong, this should be fixed:
http://p.sipsolutions.net/3bbdb9c6294dad70.txt

johannes


  reply	other threads:[~2012-06-08 15:44 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 19:10 chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues)) Andre Heider
2012-06-06 20:35 ` Johannes Berg
2012-06-06 20:35   ` Johannes Berg
2012-06-07  7:10   ` Andre Heider
2012-06-07  7:10     ` Andre Heider
2012-06-07  7:16     ` Johannes Berg
2012-06-07  7:16       ` Johannes Berg
2012-06-07 15:24       ` Andre Heider
2012-06-07 15:24         ` Andre Heider
2012-06-07 16:03         ` Michael Büsch
2012-06-07 16:03           ` Michael Büsch
2012-06-07 17:25           ` Larry Finger
2012-06-07 17:25             ` Larry Finger
2012-06-07 17:30             ` Michael Büsch
2012-06-07 17:30               ` Michael Büsch
2012-06-07 18:29               ` Larry Finger
2012-06-07 18:29                 ` Larry Finger
2012-06-07 18:34               ` Andre Heider
2012-06-07 18:34                 ` Andre Heider
2012-06-07 18:36           ` Johannes Berg
2012-06-07 18:36             ` Johannes Berg
2012-06-07 20:56             ` Johannes Berg
2012-06-07 20:56               ` Johannes Berg
2012-06-07 21:21               ` Larry Finger
2012-06-07 21:21                 ` Larry Finger
2012-06-07 21:47                 ` Andre Heider
2012-06-07 21:47                   ` Andre Heider
2012-06-08  6:27                   ` Johannes Berg
2012-06-08  6:27                     ` Johannes Berg
2012-06-08  6:41                     ` Johannes Berg
2012-06-08  6:41                       ` Johannes Berg
2012-06-08 13:49                       ` Andre Heider
2012-06-08 13:49                         ` Andre Heider
2012-06-08 14:52                         ` Johannes Berg
2012-06-08 14:52                           ` Johannes Berg
2012-06-08 15:04                           ` Andre Heider
2012-06-08 15:04                             ` Andre Heider
2012-06-08 15:14                             ` Johannes Berg
2012-06-08 15:14                               ` Johannes Berg
2012-06-08 15:16                               ` Johannes Berg
2012-06-08 15:16                                 ` Johannes Berg
2012-06-08 15:25                                 ` Andre Heider
2012-06-08 15:25                                   ` Andre Heider
2012-06-08 15:38                                   ` Larry Finger
2012-06-08 15:38                                     ` Larry Finger
2012-06-08 15:43                                     ` Johannes Berg
2012-06-08 15:43                                       ` Johannes Berg
2012-06-08 15:44                                       ` Johannes Berg [this message]
2012-06-08 15:44                                         ` Johannes Berg
2012-06-08 15:48                                         ` Johannes Berg
2012-06-08 15:48                                           ` Johannes Berg
2012-06-08 15:52                                           ` Johannes Berg
2012-06-08 15:52                                             ` Johannes Berg
2012-06-08 15:56                                             ` Andre Heider
2012-06-08 15:56                                               ` Andre Heider
2012-06-08 15:59                                               ` Johannes Berg
2012-06-08 15:59                                                 ` Johannes Berg
2012-06-08 16:05                                                 ` Andre Heider
2012-06-08 16:05                                                   ` Andre Heider
2012-06-08 16:08                                                   ` Johannes Berg
2012-06-08 16:08                                                     ` Johannes Berg
2012-06-08 16:16                                                     ` Andre Heider
2012-06-08 16:16                                                       ` Andre Heider
2012-06-08 16:20                                                       ` Johannes Berg
2012-06-08 16:20                                                         ` Johannes Berg
2012-06-08 16:24                                                         ` Johannes Berg
2012-06-08 16:24                                                           ` Johannes Berg
2012-06-08 16:41                                                       ` Johannes Berg
2012-06-08 16:41                                                         ` Johannes Berg
2012-06-08 16:54                                                         ` Andre Heider
2012-06-08 16:54                                                           ` Andre Heider
2012-06-08 16:56                                                           ` Johannes Berg
2012-06-08 16:56                                                             ` Johannes Berg
2012-06-08 16:24                                                   ` Larry Finger
2012-06-08 16:24                                                     ` Larry Finger
2012-06-08 16:28                                                     ` Johannes Berg
2012-06-08 16:28                                                       ` Johannes Berg
2012-06-08 16:33                                                       ` Michael Büsch
2012-06-08 16:33                                                         ` Michael Büsch
2012-06-08 17:43                                                         ` Larry Finger
2012-06-08 17:43                                                           ` Larry Finger
2012-06-08 17:56                                                           ` Johannes Berg
2012-06-08 17:56                                                             ` Johannes Berg
2012-06-08 18:11                                                             ` Johannes Berg
2012-06-08 18:11                                                               ` Johannes Berg
2012-06-08 18:28                                                               ` Andre Heider
2012-06-08 18:28                                                                 ` Andre Heider
2012-06-08 18:38                                                                 ` Johannes Berg
2012-06-08 18:38                                                                   ` Johannes Berg
2012-06-08 18:10                                                           ` Michael Büsch
2012-06-08 18:10                                                             ` Michael Büsch
2012-06-08 18:23                                                             ` Larry Finger
2012-06-08 18:23                                                               ` Larry Finger
2012-06-08 18:31                                                               ` Michael Büsch
2012-06-08 18:31                                                                 ` Michael Büsch
2012-06-08 19:37                                                                 ` Larry Finger
2012-06-08 19:37                                                                   ` Larry Finger
2012-06-08 19:42                                                                   ` Andre Heider
2012-06-08 19:42                                                                     ` Andre Heider
2012-06-08 18:36                                                     ` Johannes Berg
2012-06-08 18:36                                                       ` Johannes Berg
2012-06-08 18:42                                                       ` Johannes Berg
2012-06-08 18:42                                                         ` Johannes Berg
2012-06-08 19:04                                                         ` Johannes Berg
2012-06-08 19:04                                                           ` Johannes Berg
2012-06-13  8:31                                                           ` Johannes Berg
2012-06-13  8:31                                                             ` Johannes Berg
2012-06-13 15:39                                                             ` Andre Heider
2012-06-13 15:39                                                               ` Andre Heider
2012-06-13 15:46                                                               ` Johannes Berg
2012-06-13 15:46                                                                 ` Johannes Berg
2012-06-13 18:42                                                                 ` Michael Büsch
2012-06-13 18:42                                                                   ` Michael Büsch
2012-06-14 16:26                                                                   ` Andre Heider
2012-06-14 16:26                                                                     ` Andre Heider
2012-06-14 16:37                                                                     ` Johannes Berg
2012-06-14 16:37                                                                       ` Johannes Berg
2012-06-14 17:00                                                                       ` Andre Heider
2012-06-14 17:00                                                                         ` Andre Heider
2012-06-14 17:09                                                                         ` Johannes Berg
2012-06-14 17:09                                                                           ` Johannes Berg
2012-06-14 17:17                                                                           ` Johannes Berg
2012-06-14 17:17                                                                             ` Johannes Berg
2012-06-14 17:23                                                                             ` Andre Heider
2012-06-14 17:23                                                                               ` Andre Heider
2012-06-14 17:27                                                                               ` Johannes Berg
2012-06-14 17:27                                                                                 ` Johannes Berg
2012-06-15  2:03                                                                                 ` Larry Finger
2012-06-15  2:03                                                                                   ` Larry Finger
2012-06-15  8:17                                                                                   ` Johannes Berg
2012-06-15  8:17                                                                                     ` Johannes Berg
2012-06-15 17:14                                                                                   ` Andre Heider
2012-06-15 17:14                                                                                     ` Andre Heider
2012-06-08 15:38                                   ` Johannes Berg
2012-06-08 15:38                                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339170287.5748.8.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=a.heider@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.