All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Andre Heider <a.heider@gmail.com>
Cc: "Michael Büsch" <m@bues.ch>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))
Date: Thu, 07 Jun 2012 12:25:07 -0500	[thread overview]
Message-ID: <4FD0E3F3.2060900@lwfinger.net> (raw)
In-Reply-To: <20120607180325.7752b3c0@milhouse>

On 06/07/2012 11:03 AM, Michael B?sch wrote:
>
> b43 messes with the queue count at runtime. I guess that's the reason.
> I don't know if this can be fixed now, though. The problem is that we
> first need to load the firmware before we know the queue count.
> There seem to have been some firmware loading changes, but I didn't
> track those too closely. So I don't know whether they allow fixing the
> situation or not...

The only change in firmware loading is that the probe routine places a initiates 
an item on a work queue with the firmware loading routine as the callback. 
Previously, the fw load routines were called directly from the probe routine.

There is a bug in the new implementation that I am fixing. It results in the 
inability to load firmware whenever b43 is built in; however, as long as b43 is 
a module, it works fine.

I do not understand what is different about your system than mine. I have a 
Cardbus version of the BCM4318 running kernel 3.5-rc1 from mainline. The host 
computer is a PowerBook G4 Titanium (PPC). The chip has four hardware queues and 
never had the problem that was fixed with a9d3c05. When I had trouble, it was 
with a BCM4301, which does only have a single queue.

Is it possible that Nintendo uses a special version of the BCM4318 that only 
contains a single transmit queue?

I'm building 3.5-rc1 from wireless-testing, but that will take a while. That Mac 
is not very fast.

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Andre Heider <a.heider@gmail.com>
Cc: "Michael Büsch" <m@bues.ch>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))
Date: Thu, 07 Jun 2012 12:25:07 -0500	[thread overview]
Message-ID: <4FD0E3F3.2060900@lwfinger.net> (raw)
In-Reply-To: <20120607180325.7752b3c0@milhouse>

On 06/07/2012 11:03 AM, Michael Büsch wrote:
>
> b43 messes with the queue count at runtime. I guess that's the reason.
> I don't know if this can be fixed now, though. The problem is that we
> first need to load the firmware before we know the queue count.
> There seem to have been some firmware loading changes, but I didn't
> track those too closely. So I don't know whether they allow fixing the
> situation or not...

The only change in firmware loading is that the probe routine places a initiates 
an item on a work queue with the firmware loading routine as the callback. 
Previously, the fw load routines were called directly from the probe routine.

There is a bug in the new implementation that I am fixing. It results in the 
inability to load firmware whenever b43 is built in; however, as long as b43 is 
a module, it works fine.

I do not understand what is different about your system than mine. I have a 
Cardbus version of the BCM4318 running kernel 3.5-rc1 from mainline. The host 
computer is a PowerBook G4 Titanium (PPC). The chip has four hardware queues and 
never had the problem that was fixed with a9d3c05. When I had trouble, it was 
with a BCM4301, which does only have a single queue.

Is it possible that Nintendo uses a special version of the BCM4318 that only 
contains a single transmit queue?

I'm building 3.5-rc1 from wireless-testing, but that will take a while. That Mac 
is not very fast.

Larry





  reply	other threads:[~2012-06-07 17:25 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 19:10 chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues)) Andre Heider
2012-06-06 20:35 ` Johannes Berg
2012-06-06 20:35   ` Johannes Berg
2012-06-07  7:10   ` Andre Heider
2012-06-07  7:10     ` Andre Heider
2012-06-07  7:16     ` Johannes Berg
2012-06-07  7:16       ` Johannes Berg
2012-06-07 15:24       ` Andre Heider
2012-06-07 15:24         ` Andre Heider
2012-06-07 16:03         ` Michael Büsch
2012-06-07 16:03           ` Michael Büsch
2012-06-07 17:25           ` Larry Finger [this message]
2012-06-07 17:25             ` Larry Finger
2012-06-07 17:30             ` Michael Büsch
2012-06-07 17:30               ` Michael Büsch
2012-06-07 18:29               ` Larry Finger
2012-06-07 18:29                 ` Larry Finger
2012-06-07 18:34               ` Andre Heider
2012-06-07 18:34                 ` Andre Heider
2012-06-07 18:36           ` Johannes Berg
2012-06-07 18:36             ` Johannes Berg
2012-06-07 20:56             ` Johannes Berg
2012-06-07 20:56               ` Johannes Berg
2012-06-07 21:21               ` Larry Finger
2012-06-07 21:21                 ` Larry Finger
2012-06-07 21:47                 ` Andre Heider
2012-06-07 21:47                   ` Andre Heider
2012-06-08  6:27                   ` Johannes Berg
2012-06-08  6:27                     ` Johannes Berg
2012-06-08  6:41                     ` Johannes Berg
2012-06-08  6:41                       ` Johannes Berg
2012-06-08 13:49                       ` Andre Heider
2012-06-08 13:49                         ` Andre Heider
2012-06-08 14:52                         ` Johannes Berg
2012-06-08 14:52                           ` Johannes Berg
2012-06-08 15:04                           ` Andre Heider
2012-06-08 15:04                             ` Andre Heider
2012-06-08 15:14                             ` Johannes Berg
2012-06-08 15:14                               ` Johannes Berg
2012-06-08 15:16                               ` Johannes Berg
2012-06-08 15:16                                 ` Johannes Berg
2012-06-08 15:25                                 ` Andre Heider
2012-06-08 15:25                                   ` Andre Heider
2012-06-08 15:38                                   ` Larry Finger
2012-06-08 15:38                                     ` Larry Finger
2012-06-08 15:43                                     ` Johannes Berg
2012-06-08 15:43                                       ` Johannes Berg
2012-06-08 15:44                                       ` Johannes Berg
2012-06-08 15:44                                         ` Johannes Berg
2012-06-08 15:48                                         ` Johannes Berg
2012-06-08 15:48                                           ` Johannes Berg
2012-06-08 15:52                                           ` Johannes Berg
2012-06-08 15:52                                             ` Johannes Berg
2012-06-08 15:56                                             ` Andre Heider
2012-06-08 15:56                                               ` Andre Heider
2012-06-08 15:59                                               ` Johannes Berg
2012-06-08 15:59                                                 ` Johannes Berg
2012-06-08 16:05                                                 ` Andre Heider
2012-06-08 16:05                                                   ` Andre Heider
2012-06-08 16:08                                                   ` Johannes Berg
2012-06-08 16:08                                                     ` Johannes Berg
2012-06-08 16:16                                                     ` Andre Heider
2012-06-08 16:16                                                       ` Andre Heider
2012-06-08 16:20                                                       ` Johannes Berg
2012-06-08 16:20                                                         ` Johannes Berg
2012-06-08 16:24                                                         ` Johannes Berg
2012-06-08 16:24                                                           ` Johannes Berg
2012-06-08 16:41                                                       ` Johannes Berg
2012-06-08 16:41                                                         ` Johannes Berg
2012-06-08 16:54                                                         ` Andre Heider
2012-06-08 16:54                                                           ` Andre Heider
2012-06-08 16:56                                                           ` Johannes Berg
2012-06-08 16:56                                                             ` Johannes Berg
2012-06-08 16:24                                                   ` Larry Finger
2012-06-08 16:24                                                     ` Larry Finger
2012-06-08 16:28                                                     ` Johannes Berg
2012-06-08 16:28                                                       ` Johannes Berg
2012-06-08 16:33                                                       ` Michael Büsch
2012-06-08 16:33                                                         ` Michael Büsch
2012-06-08 17:43                                                         ` Larry Finger
2012-06-08 17:43                                                           ` Larry Finger
2012-06-08 17:56                                                           ` Johannes Berg
2012-06-08 17:56                                                             ` Johannes Berg
2012-06-08 18:11                                                             ` Johannes Berg
2012-06-08 18:11                                                               ` Johannes Berg
2012-06-08 18:28                                                               ` Andre Heider
2012-06-08 18:28                                                                 ` Andre Heider
2012-06-08 18:38                                                                 ` Johannes Berg
2012-06-08 18:38                                                                   ` Johannes Berg
2012-06-08 18:10                                                           ` Michael Büsch
2012-06-08 18:10                                                             ` Michael Büsch
2012-06-08 18:23                                                             ` Larry Finger
2012-06-08 18:23                                                               ` Larry Finger
2012-06-08 18:31                                                               ` Michael Büsch
2012-06-08 18:31                                                                 ` Michael Büsch
2012-06-08 19:37                                                                 ` Larry Finger
2012-06-08 19:37                                                                   ` Larry Finger
2012-06-08 19:42                                                                   ` Andre Heider
2012-06-08 19:42                                                                     ` Andre Heider
2012-06-08 18:36                                                     ` Johannes Berg
2012-06-08 18:36                                                       ` Johannes Berg
2012-06-08 18:42                                                       ` Johannes Berg
2012-06-08 18:42                                                         ` Johannes Berg
2012-06-08 19:04                                                         ` Johannes Berg
2012-06-08 19:04                                                           ` Johannes Berg
2012-06-13  8:31                                                           ` Johannes Berg
2012-06-13  8:31                                                             ` Johannes Berg
2012-06-13 15:39                                                             ` Andre Heider
2012-06-13 15:39                                                               ` Andre Heider
2012-06-13 15:46                                                               ` Johannes Berg
2012-06-13 15:46                                                                 ` Johannes Berg
2012-06-13 18:42                                                                 ` Michael Büsch
2012-06-13 18:42                                                                   ` Michael Büsch
2012-06-14 16:26                                                                   ` Andre Heider
2012-06-14 16:26                                                                     ` Andre Heider
2012-06-14 16:37                                                                     ` Johannes Berg
2012-06-14 16:37                                                                       ` Johannes Berg
2012-06-14 17:00                                                                       ` Andre Heider
2012-06-14 17:00                                                                         ` Andre Heider
2012-06-14 17:09                                                                         ` Johannes Berg
2012-06-14 17:09                                                                           ` Johannes Berg
2012-06-14 17:17                                                                           ` Johannes Berg
2012-06-14 17:17                                                                             ` Johannes Berg
2012-06-14 17:23                                                                             ` Andre Heider
2012-06-14 17:23                                                                               ` Andre Heider
2012-06-14 17:27                                                                               ` Johannes Berg
2012-06-14 17:27                                                                                 ` Johannes Berg
2012-06-15  2:03                                                                                 ` Larry Finger
2012-06-15  2:03                                                                                   ` Larry Finger
2012-06-15  8:17                                                                                   ` Johannes Berg
2012-06-15  8:17                                                                                     ` Johannes Berg
2012-06-15 17:14                                                                                   ` Andre Heider
2012-06-15 17:14                                                                                     ` Andre Heider
2012-06-08 15:38                                   ` Johannes Berg
2012-06-08 15:38                                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD0E3F3.2060900@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=a.heider@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.