From: Shuah Khan <shuah.khan@hp.com>
To: cl@linux.com, penberg@kernel.org, glommer@parallels.com,
js1304@gmail.com
Cc: shuahkhan@gmail.com, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()
Date: Fri, 13 Jul 2012 17:12:05 -0600 [thread overview]
Message-ID: <1342221125.17464.8.camel@lorien2> (raw)
The label oops is used in CONFIG_DEBUG_VM ifdef block and is defined
outside ifdef CONFIG_DEBUG_VM block. This results in the following
build warning when built with CONFIG_DEBUG_VM disabled. Fix to move
label oops definition to inside a CONFIG_DEBUG_VM block.
mm/slab_common.c: In function a??kmem_cache_createa??:
mm/slab_common.c:101:1: warning: label a??oopsa?? defined but not used
[-Wunused-label]
Signed-off-by: Shuah Khan <shuah.khan@hp.com>
---
mm/slab_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 12637ce..aa3ca5b 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -98,7 +98,9 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align
s = __kmem_cache_create(name, size, align, flags, ctor);
+#ifdef CONFIG_DEBUG_VM
oops:
+#endif
mutex_unlock(&slab_mutex);
put_online_cpus();
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuah.khan@hp.com>
To: cl@linux.com, penberg@kernel.org, glommer@parallels.com,
js1304@gmail.com
Cc: shuahkhan@gmail.com, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()
Date: Fri, 13 Jul 2012 17:12:05 -0600 [thread overview]
Message-ID: <1342221125.17464.8.camel@lorien2> (raw)
The label oops is used in CONFIG_DEBUG_VM ifdef block and is defined
outside ifdef CONFIG_DEBUG_VM block. This results in the following
build warning when built with CONFIG_DEBUG_VM disabled. Fix to move
label oops definition to inside a CONFIG_DEBUG_VM block.
mm/slab_common.c: In function ‘kmem_cache_create’:
mm/slab_common.c:101:1: warning: label ‘oops’ defined but not used
[-Wunused-label]
Signed-off-by: Shuah Khan <shuah.khan@hp.com>
---
mm/slab_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 12637ce..aa3ca5b 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -98,7 +98,9 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align
s = __kmem_cache_create(name, size, align, flags, ctor);
+#ifdef CONFIG_DEBUG_VM
oops:
+#endif
mutex_unlock(&slab_mutex);
put_online_cpus();
--
1.7.9.5
next reply other threads:[~2012-07-13 23:12 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 23:12 Shuah Khan [this message]
2012-07-13 23:12 ` [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create() Shuah Khan
2012-07-14 9:18 ` David Rientjes
2012-07-14 9:18 ` David Rientjes
2012-07-14 12:01 ` Pekka Enberg
2012-07-14 12:01 ` Pekka Enberg
2012-07-16 3:04 ` Shuah Khan
2012-07-16 3:04 ` Shuah Khan
2012-07-16 9:58 ` David Rientjes
2012-07-16 9:58 ` David Rientjes
2012-07-16 14:17 ` Christoph Lameter
2012-07-16 14:17 ` Christoph Lameter
2012-07-16 15:56 ` Shuah Khan
2012-07-16 15:56 ` Shuah Khan
2012-07-16 19:58 ` David Rientjes
2012-07-16 19:58 ` David Rientjes
2012-07-16 20:14 ` Christoph Lameter
2012-07-16 20:14 ` Christoph Lameter
2012-07-16 23:48 ` David Rientjes
2012-07-16 23:48 ` David Rientjes
2012-07-17 14:36 ` Christoph Lameter
2012-07-17 14:36 ` Christoph Lameter
2012-07-17 14:46 ` Pekka Enberg
2012-07-17 14:46 ` Pekka Enberg
2012-07-17 15:11 ` Christoph Lameter
2012-07-17 15:11 ` Christoph Lameter
2012-07-23 7:04 ` Glauber Costa
2012-07-23 7:04 ` Glauber Costa
2012-07-25 15:28 ` Christoph Lameter
2012-07-25 15:28 ` Christoph Lameter
2012-07-17 16:52 ` Shuah Khan
2012-07-17 16:52 ` Shuah Khan
2012-07-30 10:18 ` Pekka Enberg
2012-07-30 10:18 ` Pekka Enberg
2012-07-30 19:56 ` David Rientjes
2012-07-30 19:56 ` David Rientjes
2012-07-30 20:41 ` Pekka Enberg
2012-07-30 20:41 ` Pekka Enberg
2012-07-31 2:07 ` David Rientjes
2012-07-31 2:07 ` David Rientjes
2012-07-31 6:05 ` Pekka Enberg
2012-07-31 6:05 ` Pekka Enberg
2012-08-06 3:41 ` Shuah Khan
2012-08-06 3:41 ` Shuah Khan
2012-08-06 15:14 ` [PATCH RESEND] mm: Restructure kmem_cache_create() to move debug cache integrity checks into a new function Shuah Khan
2012-08-06 15:14 ` Shuah Khan
2012-08-06 16:49 ` JoonSoo Kim
2012-08-06 16:49 ` JoonSoo Kim
2012-08-06 17:03 ` Shuah Khan
2012-08-06 17:03 ` Shuah Khan
2012-08-06 21:13 ` [PATCH v2] " Shuah Khan
2012-08-06 21:13 ` Shuah Khan
2012-08-09 14:06 ` Shuah Khan
2012-08-09 14:06 ` Shuah Khan
2012-08-09 14:13 ` Christoph Lameter (Open Source)
2012-08-09 14:13 ` Christoph Lameter (Open Source)
2012-08-09 17:01 ` Shuah Khan
2012-08-09 17:01 ` Shuah Khan
2012-08-09 19:08 ` Christoph Lameter (Open Source)
2012-08-09 19:08 ` Christoph Lameter (Open Source)
2012-08-09 19:33 ` Shuah Khan
2012-08-09 19:33 ` Shuah Khan
2012-08-12 16:40 ` [PATCH v3] " Shuah Khan
2012-08-12 16:40 ` Shuah Khan
2012-08-12 17:36 ` Christoph
2012-08-12 17:36 ` Christoph
2012-08-15 23:53 ` Andrew Morton
2012-08-15 23:53 ` Andrew Morton
2012-08-16 6:40 ` Pekka Enberg
2012-08-16 6:40 ` Pekka Enberg
2012-08-08 14:14 ` [PATCH RESEND] " Christoph Lameter (Open Source)
2012-08-08 14:14 ` Christoph Lameter (Open Source)
2012-08-08 15:13 ` Shuah Khan
2012-08-08 15:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342221125.17464.8.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.