From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
ul Mundt <lethal@linux-sh.org>,
Rob Herring <rob.herring@calxeda.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: More irqdomain problems (Was: next/mmotm unbootable on G5: irqdomain)
Date: Mon, 23 Jul 2012 16:32:41 +1000 [thread overview]
Message-ID: <1343025161.2957.22.camel@pasglop> (raw)
In-Reply-To: <1343011543.2957.2.camel@pasglop>
Allright, another one Grant:
unsigned int irq_find_mapping(struct irq_domain *domain,
irq_hw_number_t hwirq)
{
struct irq_data *data;
/* Look for default domain if nececssary */
if (domain == NULL)
domain = irq_default_domain;
if (domain == NULL)
return 0;
switch (domain->revmap_type) {
case IRQ_DOMAIN_MAP_LEGACY:
return irq_domain_legacy_revmap(domain, hwirq);
case IRQ_DOMAIN_MAP_LINEAR:
return irq_linear_revmap(domain, hwirq);
case IRQ_DOMAIN_MAP_TREE:
rcu_read_lock();
data = radix_tree_lookup(&domain->revmap_data.tree, hwirq);
rcu_read_unlock();
if (data)
return data->irq;
- break;
+ return 0;
case IRQ_DOMAIN_MAP_NOMAP:
Please, stick a proper commit message and my s-o-b and see if you can fix
your tree before you ask Linus to pull because that's not pretty on any
pseries .... irq_find_mapping() does get called for all interrupt the
first time it's mapped to check if there's a pre-existing mapping, so
the case of the thing being unpopulated is absolutely legit.
the NOMAP case has a similar dubious exit case but since I'm not that
familiar with NOMAP I haven't touched it.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Milton Miller <miltonm@bga.com>, Hugh Dickins <hughd@google.com>,
ul Mundt <lethal@linux-sh.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: More irqdomain problems (Was: next/mmotm unbootable on G5: irqdomain)
Date: Mon, 23 Jul 2012 16:32:41 +1000 [thread overview]
Message-ID: <1343025161.2957.22.camel@pasglop> (raw)
In-Reply-To: <1343011543.2957.2.camel@pasglop>
Allright, another one Grant:
unsigned int irq_find_mapping(struct irq_domain *domain,
irq_hw_number_t hwirq)
{
struct irq_data *data;
/* Look for default domain if nececssary */
if (domain == NULL)
domain = irq_default_domain;
if (domain == NULL)
return 0;
switch (domain->revmap_type) {
case IRQ_DOMAIN_MAP_LEGACY:
return irq_domain_legacy_revmap(domain, hwirq);
case IRQ_DOMAIN_MAP_LINEAR:
return irq_linear_revmap(domain, hwirq);
case IRQ_DOMAIN_MAP_TREE:
rcu_read_lock();
data = radix_tree_lookup(&domain->revmap_data.tree, hwirq);
rcu_read_unlock();
if (data)
return data->irq;
- break;
+ return 0;
case IRQ_DOMAIN_MAP_NOMAP:
Please, stick a proper commit message and my s-o-b and see if you can fix
your tree before you ask Linus to pull because that's not pretty on any
pseries .... irq_find_mapping() does get called for all interrupt the
first time it's mapped to check if there's a pre-existing mapping, so
the case of the thing being unpopulated is absolutely legit.
the NOMAP case has a similar dubious exit case but since I'm not that
familiar with NOMAP I haven't touched it.
Cheers,
Ben.
next prev parent reply other threads:[~2012-07-23 6:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 2:47 next/mmotm unbootable on G5: irqdomain Hugh Dickins
2012-07-22 2:47 ` Hugh Dickins
2012-07-22 13:09 ` Benjamin Herrenschmidt
2012-07-22 13:09 ` Benjamin Herrenschmidt
2012-07-22 14:44 ` Hugh Dickins
2012-07-22 14:44 ` Hugh Dickins
2012-07-23 2:45 ` Benjamin Herrenschmidt
2012-07-23 2:45 ` Benjamin Herrenschmidt
2012-07-23 6:32 ` Benjamin Herrenschmidt [this message]
2012-07-23 6:32 ` More irqdomain problems (Was: next/mmotm unbootable on G5: irqdomain) Benjamin Herrenschmidt
2012-07-25 5:09 ` Grant Likely
2012-07-25 5:09 ` Grant Likely
2012-07-23 7:24 ` next/mmotm unbootable on G5: irqdomain Hugh Dickins
2012-07-23 7:24 ` Hugh Dickins
2012-07-23 7:59 ` Grant Likely
2012-07-23 7:59 ` Grant Likely
2012-07-23 22:26 ` Benjamin Herrenschmidt
2012-07-23 22:26 ` Benjamin Herrenschmidt
2012-07-23 22:31 ` Grant Likely
2012-07-23 22:31 ` Grant Likely
2012-07-23 22:32 ` Grant Likely
2012-07-23 22:32 ` Grant Likely
2012-07-24 3:21 ` Benjamin Herrenschmidt
2012-07-24 3:21 ` Benjamin Herrenschmidt
2012-07-24 4:37 ` Grant Likely
2012-07-24 4:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343025161.2957.22.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=grant.likely@secretlab.ca \
--cc=hughd@google.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miltonm@bga.com \
--cc=rob.herring@calxeda.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.