* [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
@ 2012-08-02 2:32 Joshua Brindle
2012-08-02 2:38 ` Joshua Brindle
0 siblings, 1 reply; 6+ messages in thread
From: Joshua Brindle @ 2012-08-02 2:32 UTC (permalink / raw)
To: selinux; +Cc: Joshua Brindle
From: Joshua Brindle <jbrindle@tresys.com>
selabel_lookup requires the mountpoint start with a '/' to match specifications in the file_context file. Change mkyaffs2image call to add a '/' to the mount point argument
Change-Id: I255b661822401f9253ef58a2a4bdada85fc96b23
Signed-off-by: Joshua Brindle <jbrindle@tresys.com>
---
tools/releasetools/build_image.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/releasetools/build_image.py b/tools/releasetools/build_image.py
index a615d1a..9afb6f2 100755
--- a/tools/releasetools/build_image.py
+++ b/tools/releasetools/build_image.py
@@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict, out_file):
build_command.append(out_file)
if "selinux_fc" in prop_dict:
build_command.append(prop_dict["selinux_fc"])
- build_command.append(prop_dict["mount_point"])
+ build_command.append("/" . prop_dict["mount_point"])
print "Running: ", " ".join(build_command)
p = subprocess.Popen(build_command);
--
1.7.9.5
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
@ 2012-08-02 2:36 Joshua Brindle
2012-08-02 2:39 ` Joshua Brindle
0 siblings, 1 reply; 6+ messages in thread
From: Joshua Brindle @ 2012-08-02 2:36 UTC (permalink / raw)
To: selinux; +Cc: Joshua Brindle
From: Joshua Brindle <jbrindle@tresys.com>
selabel_lookup requires the mountpoint start with a '/' to match specifications in the file_context file. Change mkyaffs2image call to add a '/' to the mount point argument
Change-Id: I255b661822401f9253ef58a2a4bdada85fc96b23
Signed-off-by: Joshua Brindle <jbrindle@tresys.com>
---
tools/releasetools/build_image.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/releasetools/build_image.py b/tools/releasetools/build_image.py
index a615d1a..610e634 100755
--- a/tools/releasetools/build_image.py
+++ b/tools/releasetools/build_image.py
@@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict, out_file):
build_command.append(out_file)
if "selinux_fc" in prop_dict:
build_command.append(prop_dict["selinux_fc"])
- build_command.append(prop_dict["mount_point"])
+ build_command.append("/%s" % prop_dict["mount_point"])
print "Running: ", " ".join(build_command)
p = subprocess.Popen(build_command);
--
1.7.9.5
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
2012-08-02 2:32 [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point Joshua Brindle
@ 2012-08-02 2:38 ` Joshua Brindle
0 siblings, 0 replies; 6+ messages in thread
From: Joshua Brindle @ 2012-08-02 2:38 UTC (permalink / raw)
To: selinux; +Cc: Joshua Brindle
Ignore this patch please.
Joshua Brindle wrote:
> From: Joshua Brindle<jbrindle@tresys.com>
>
> selabel_lookup requires the mountpoint start with a '/' to match specifications in the file_context file. Change mkyaffs2image call to add a '/' to the mount point argument
>
> Change-Id: I255b661822401f9253ef58a2a4bdada85fc96b23
>
> Signed-off-by: Joshua Brindle<jbrindle@tresys.com>
> ---
> tools/releasetools/build_image.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/releasetools/build_image.py b/tools/releasetools/build_image.py
> index a615d1a..9afb6f2 100755
> --- a/tools/releasetools/build_image.py
> +++ b/tools/releasetools/build_image.py
> @@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict, out_file):
> build_command.append(out_file)
> if "selinux_fc" in prop_dict:
> build_command.append(prop_dict["selinux_fc"])
> - build_command.append(prop_dict["mount_point"])
> + build_command.append("/" . prop_dict["mount_point"])
>
> print "Running: ", " ".join(build_command)
> p = subprocess.Popen(build_command);
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
2012-08-02 2:36 Joshua Brindle
@ 2012-08-02 2:39 ` Joshua Brindle
2012-08-02 10:04 ` Robert Craig
0 siblings, 1 reply; 6+ messages in thread
From: Joshua Brindle @ 2012-08-02 2:39 UTC (permalink / raw)
To: selinux; +Cc: Joshua Brindle
Note, I have no idea why this just started happening but it is
consistent on my 4.1.1_r3 checkout. I don't know what the ramifications
of changing the mountpoint are (e.g., is that used by something other
than selabel_lookup?) so I haven't submitted it to AOSP.
Joshua Brindle wrote:
> From: Joshua Brindle<jbrindle@tresys.com>
>
> selabel_lookup requires the mountpoint start with a '/' to match specifications in the file_context file. Change mkyaffs2image call to add a '/' to the mount point argument
>
> Change-Id: I255b661822401f9253ef58a2a4bdada85fc96b23
>
> Signed-off-by: Joshua Brindle<jbrindle@tresys.com>
> ---
> tools/releasetools/build_image.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/releasetools/build_image.py b/tools/releasetools/build_image.py
> index a615d1a..610e634 100755
> --- a/tools/releasetools/build_image.py
> +++ b/tools/releasetools/build_image.py
> @@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict, out_file):
> build_command.append(out_file)
> if "selinux_fc" in prop_dict:
> build_command.append(prop_dict["selinux_fc"])
> - build_command.append(prop_dict["mount_point"])
> + build_command.append("/%s" % prop_dict["mount_point"])
>
> print "Running: ", " ".join(build_command)
> p = subprocess.Popen(build_command);
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
2012-08-02 2:39 ` Joshua Brindle
@ 2012-08-02 10:04 ` Robert Craig
2012-08-02 13:06 ` Stephen Smalley
0 siblings, 1 reply; 6+ messages in thread
From: Robert Craig @ 2012-08-02 10:04 UTC (permalink / raw)
To: Joshua Brindle; +Cc: selinux, Joshua Brindle
[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]
There has already been a patch merged with the master branch
(external/yaffs2 bd009e4d493deaf90c38da1cdbaa1db69db073ba). For now I
would cherry-pick. I'll see what we can do about getting that patch applied
to the other branches as well.
On Wed, Aug 1, 2012 at 10:39 PM, Joshua Brindle <method@manicmethod.com>wrote:
> Note, I have no idea why this just started happening but it is consistent
> on my 4.1.1_r3 checkout. I don't know what the ramifications of changing
> the mountpoint are (e.g., is that used by something other than
> selabel_lookup?) so I haven't submitted it to AOSP.
>
>
> Joshua Brindle wrote:
>
>> From: Joshua Brindle<jbrindle@tresys.com>
>>
>> selabel_lookup requires the mountpoint start with a '/' to match
>> specifications in the file_context file. Change mkyaffs2image call to add a
>> '/' to the mount point argument
>>
>> Change-Id: I255b661822401f9253ef58a2a4bda**da85fc96b23
>>
>> Signed-off-by: Joshua Brindle<jbrindle@tresys.com>
>> ---
>> tools/releasetools/build_**image.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/releasetools/build_**image.py
>> b/tools/releasetools/build_**image.py
>> index a615d1a..610e634 100755
>> --- a/tools/releasetools/build_**image.py
>> +++ b/tools/releasetools/build_**image.py
>> @@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict, out_file):
>> build_command.append(out_file)
>> if "selinux_fc" in prop_dict:
>> build_command.append(prop_**dict["selinux_fc"])
>> - build_command.append(prop_**dict["mount_point"])
>> + build_command.append("/%s" % prop_dict["mount_point"])
>>
>> print "Running: ", " ".join(build_command)
>> p = subprocess.Popen(build_**command);
>>
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.govwith
> the words "unsubscribe selinux" without quotes as the message.
>
[-- Attachment #2: Type: text/html, Size: 2828 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point
2012-08-02 10:04 ` Robert Craig
@ 2012-08-02 13:06 ` Stephen Smalley
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Smalley @ 2012-08-02 13:06 UTC (permalink / raw)
To: Robert Craig; +Cc: Joshua Brindle, selinux, Joshua Brindle
On Thu, 2012-08-02 at 06:04 -0400, Robert Craig wrote:
> There has already been a patch merged with the master branch
> (external/yaffs2 bd009e4d493deaf90c38da1cdbaa1db69db073ba). For now I
> would cherry-pick. I'll see what we can do about getting that patch
> applied to the other branches as well.
I cherry-picked it over to seandroid-4.1.1. I assume it isn't needed on
4.0.4 (and it didn't apply cleanly there).
>
>
>
> On Wed, Aug 1, 2012 at 10:39 PM, Joshua Brindle
> <method@manicmethod.com> wrote:
> Note, I have no idea why this just started happening but it is
> consistent on my 4.1.1_r3 checkout. I don't know what the
> ramifications of changing the mountpoint are (e.g., is that
> used by something other than selabel_lookup?) so I haven't
> submitted it to AOSP.
>
>
> Joshua Brindle wrote:
> From: Joshua Brindle<jbrindle@tresys.com>
>
> selabel_lookup requires the mountpoint start with a
> '/' to match specifications in the file_context file.
> Change mkyaffs2image call to add a '/' to the mount
> point argument
>
> Change-Id: I255b661822401f9253ef58a2a4bdada85fc96b23
>
> Signed-off-by: Joshua Brindle<jbrindle@tresys.com>
> ---
> tools/releasetools/build_image.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/releasetools/build_image.py
> b/tools/releasetools/build_image.py
> index a615d1a..610e634 100755
> --- a/tools/releasetools/build_image.py
> +++ b/tools/releasetools/build_image.py
> @@ -56,7 +56,7 @@ def BuildImage(in_dir, prop_dict,
> out_file):
> build_command.append(out_file)
> if "selinux_fc" in prop_dict:
> build_command.append(prop_dict["selinux_fc"])
> - build_command.append(prop_dict["mount_point"])
> + build_command.append("/%s" %
> prop_dict["mount_point"])
>
> print "Running: ", " ".join(build_command)
> p = subprocess.Popen(build_command);
>
> --
>
> This message was distributed to subscribers of the selinux
> mailing list.
> If you no longer wish to subscribe, send mail to
> majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
>
>
--
Stephen Smalley
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-02 13:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 2:32 [PATCH build/] Fix mkyaffs2image call to add a '/' to the mount point Joshua Brindle
2012-08-02 2:38 ` Joshua Brindle
-- strict thread matches above, loose matches on Subject: below --
2012-08-02 2:36 Joshua Brindle
2012-08-02 2:39 ` Joshua Brindle
2012-08-02 10:04 ` Robert Craig
2012-08-02 13:06 ` Stephen Smalley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.