From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org
Subject: Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration
Date: Thu, 06 Sep 2012 02:49:14 +0000 [thread overview]
Message-ID: <1346899754.19098.15.camel@pasglop> (raw)
In-Reply-To: <1346899471.19098.14.camel@pasglop>
On Thu, 2012-09-06 at 12:44 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2012-09-06 at 10:20 +0800, Fengguang Wu wrote:
> > Hi Michael,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> > head: 8b64a9dfb091f1eca8b7e58da82f1e7d1d5fe0ad
> > commit: 474e3d569b63f7275cfec072d7ef7b2ffb8904c8 [11/29] powerpc/pseries: Remove uses of abs_to_virt() and virt_to_abs()
> > config: powerpc-allmodconfig (attached as .config)
> >
> > All related error/warning messages:
> >
> > arch/powerpc/platforms/pseries/iommu.c: In function 'enable_ddw':
> > arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
>
> Thanks. That seems to be building in my tree oddly, I didn't even have a
> warning. Maybe some conditional inclusion ? I will add a commit that
> adds an explicit #include of memblock.h
Ok, I see. It's a subtle bisection breakage, the next commit fixes it.
Oh well, I won't rebase for that, but thanks for the heads up.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org
Subject: Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM'
Date: Thu, 06 Sep 2012 12:49:14 +1000 [thread overview]
Message-ID: <1346899754.19098.15.camel@pasglop> (raw)
In-Reply-To: <1346899471.19098.14.camel@pasglop>
On Thu, 2012-09-06 at 12:44 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2012-09-06 at 10:20 +0800, Fengguang Wu wrote:
> > Hi Michael,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> > head: 8b64a9dfb091f1eca8b7e58da82f1e7d1d5fe0ad
> > commit: 474e3d569b63f7275cfec072d7ef7b2ffb8904c8 [11/29] powerpc/pseries: Remove uses of abs_to_virt() and virt_to_abs()
> > config: powerpc-allmodconfig (attached as .config)
> >
> > All related error/warning messages:
> >
> > arch/powerpc/platforms/pseries/iommu.c: In function 'enable_ddw':
> > arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
>
> Thanks. That seems to be building in my tree oddly, I didn't even have a
> warning. Maybe some conditional inclusion ? I will add a commit that
> adds an explicit #include of memblock.h
Ok, I see. It's a subtle bisection breakage, the next commit fixes it.
Oh well, I won't rebase for that, but thanks for the heads up.
Cheers,
Ben.
next prev parent reply other threads:[~2012-09-06 2:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 2:20 [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' Fengguang Wu
2012-09-06 2:44 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration Benjamin Herrenschmidt
2012-09-06 2:44 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' Benjamin Herrenschmidt
2012-09-06 2:49 ` Benjamin Herrenschmidt [this message]
2012-09-06 2:49 ` Benjamin Herrenschmidt
2012-09-06 3:03 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration Fengguang Wu
2012-09-06 3:03 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' Fengguang Wu
2012-09-06 3:05 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration Benjamin Herrenschmidt
2012-09-06 3:05 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' Benjamin Herrenschmidt
2012-09-06 3:18 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration Fengguang Wu
2012-09-06 3:18 ` [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346899754.19098.15.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.