From: Shuah Khan <shuah.khan@hp.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: fujita.tomonori@lab.ntt.co.jp,
Andrew Morton <akpm@linux-foundation.org>,
paul.gortmaker@windriver.com, bhelgaas@google.com,
amwang@redhat.com, joerg.roedel@amd.com, kubakici@wp.pl,
dan.carpenter@oracle.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
devel@linuxdriverproject.org, shuahkhan@gmail.com
Subject: Re: [RFC] DMA mapping error check analysis
Date: Fri, 07 Sep 2012 10:54:29 -0600 [thread overview]
Message-ID: <1347036869.2603.28.camel@lorien2> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1209071218550.1674-100000@iolanthe.rowland.org>
On Fri, 2012-09-07 at 12:20 -0400, Alan Stern wrote:
> On Fri, 7 Sep 2012, Shuah Khan wrote:
>
> > I analyzed all calls to dma_map_single() and dma_map_page() in the
> > kernel, to see if callers check for mapping errors, before using the
> > returned address.
> >
> > The goal of this analysis is to find drivers that currently do not
> > check dma mapping errors, and fix them.
> >
> > I documented the results of this analysis:
> >
> > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis
> >
> > Please review and give me feedback on the analysis and the proposed
> > next steps.
>
> Your first table (dma_map_single) lists drivers/usb/core/usb.c and
> marks it as Bad. This is a mistake because the code is #ifdef'ed out.
> It hasn't been used in many years; it should be removed.
Thanks for catching it. I did note that in my research notes and that
was left out by mistake when I put the table together. Table is updated
now with your comment and marked it a Cleanup item.
-- Shuah
next prev parent reply other threads:[~2012-09-07 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 14:14 [PATCH] dma-debug: Add dma map/unmap error tracking support Shuah Khan
2012-09-04 21:05 ` Konrad Rzeszutek Wilk
2012-09-04 22:57 ` Shuah Khan
2012-09-05 11:57 ` Konrad Rzeszutek Wilk
2012-09-05 14:34 ` Shuah Khan
2012-09-05 19:30 ` Shuah Khan
2012-09-07 15:53 ` [RFC] DMA mapping error check analysis Shuah Khan
2012-09-07 16:20 ` Alan Stern
2012-09-07 16:54 ` Shuah Khan [this message]
2012-09-10 7:53 ` Clemens Ladisch
2012-09-10 15:26 ` Shuah Khan
2012-09-10 17:17 ` Stefan Richter
2012-09-10 17:42 ` Clemens Ladisch
2012-09-10 19:28 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347036869.2603.28.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=kubakici@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=shuahkhan@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.