From: Clemens Ladisch <clemens@ladisch.de>
To: shuah.khan@hp.com
Cc: LKML <linux-kernel@vger.kernel.org>,
shuahkhan@gmail.com, linux1394-devel@lists.sf.net
Subject: Re: [RFC] DMA mapping error check analysis
Date: Mon, 10 Sep 2012 09:53:20 +0200 [thread overview]
Message-ID: <504D9C70.5000102@ladisch.de> (raw)
In-Reply-To: <1347033200.2603.19.camel@lorien2>
Shuah Khan wrote:
> I analyzed all calls to dma_map_single() and dma_map_page() in the
> kernel, to see if callers check for mapping errors, before using the
> returned address.
>
> The goal of this analysis is to find drivers that currently do not
> check dma mapping errors, and fix them.
>
> I documented the results of this analysis:
>
> http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis
> File Name # of calls Status
> drivers/firewire/core-iso.c 1 Unmap Broken
> drivers/firewire/ohci.c 1 Unmap Broken
In ohci.c, ar_context_release() takes care of cleanup.
In core-iso.c, on failure, the callers are responsible to call
fw_iso_buffer_destroy() eventually. (ioctl_create_iso_context()
doesn't do this correctly if it's called multiple times.)
Regards,
Clemens
next prev parent reply other threads:[~2012-09-10 7:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 14:14 [PATCH] dma-debug: Add dma map/unmap error tracking support Shuah Khan
2012-09-04 21:05 ` Konrad Rzeszutek Wilk
2012-09-04 22:57 ` Shuah Khan
2012-09-05 11:57 ` Konrad Rzeszutek Wilk
2012-09-05 14:34 ` Shuah Khan
2012-09-05 19:30 ` Shuah Khan
2012-09-07 15:53 ` [RFC] DMA mapping error check analysis Shuah Khan
2012-09-07 16:20 ` Alan Stern
2012-09-07 16:54 ` Shuah Khan
2012-09-10 7:53 ` Clemens Ladisch [this message]
2012-09-10 15:26 ` Shuah Khan
2012-09-10 17:17 ` Stefan Richter
2012-09-10 17:42 ` Clemens Ladisch
2012-09-10 19:28 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504D9C70.5000102@ladisch.de \
--to=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sf.net \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.