From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: shuah.khan@hp.com, LKML <linux-kernel@vger.kernel.org>,
linux1394-devel@lists.sf.net, shuahkhan@gmail.com
Subject: Re: [RFC] DMA mapping error check analysis
Date: Mon, 10 Sep 2012 21:28:04 +0200 [thread overview]
Message-ID: <20120910212804.30342e41@stein> (raw)
In-Reply-To: <504E267A.8060307@ladisch.de>
On Sep 10 Clemens Ladisch wrote:
> fw_iso_buffer_map_dma() maps as many pages as it can, and saves in
> ->page_count_mapped how many pages need unmapping.
>
> When fw_iso_buffer_map_dma() fails, ioctl_create_iso_context() does _not_
> call fw_iso_buffer_destroy() but takes care to not change the cdev's
> state in any other way. So ioctl_create_iso_context() can be called
> again and will then call fw_iso_buffer_map_dma(), which will happily
> map the pages a second time, overwriting the previous mapped addresses.
Indeed; thank you. I make a note to fix this when I get some time.
--
Stefan Richter
-=====-===-- =--= -=-=-
http://arcgraph.de/sr/
prev parent reply other threads:[~2012-09-10 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 14:14 [PATCH] dma-debug: Add dma map/unmap error tracking support Shuah Khan
2012-09-04 21:05 ` Konrad Rzeszutek Wilk
2012-09-04 22:57 ` Shuah Khan
2012-09-05 11:57 ` Konrad Rzeszutek Wilk
2012-09-05 14:34 ` Shuah Khan
2012-09-05 19:30 ` Shuah Khan
2012-09-07 15:53 ` [RFC] DMA mapping error check analysis Shuah Khan
2012-09-07 16:20 ` Alan Stern
2012-09-07 16:54 ` Shuah Khan
2012-09-10 7:53 ` Clemens Ladisch
2012-09-10 15:26 ` Shuah Khan
2012-09-10 17:17 ` Stefan Richter
2012-09-10 17:42 ` Clemens Ladisch
2012-09-10 19:28 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910212804.30342e41@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sf.net \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.