All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: peter.senna@gmail.com, shemminger@vyatta.com,
	mlindner@marvell.com, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Fri, 05 Oct 2012 00:09:55 +0000	[thread overview]
Message-ID: <1349395795.2008.26.camel@joe-AO722> (raw)
In-Reply-To: <20121004.145419.1859367129463136197.davem@davemloft.net>

On Thu, 2012-10-04 at 14:54 -0400, David Miller wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
> > On Thu, Oct 4, 2012 at 8:23 PM, David Miller <davem@davemloft.net> wrote:
> >> We want to know the implications of the bug being fixed.
> >> Does it potentially cause an OOPS?  Bad reference counting and thus
> >> potential leaks or early frees?
> >>
> >> You have to analyze the implications and ramifications of the bug
> >> being fixed.  We need that information.

You are asking for deeper level analysis that may not
be reasonably possible from the robotic patch fixed
by a robotic piece of a bit of code correction via a
static analysis.

> >> It's just "bad error code, this is the script that fixed it, kthx,
> >> bye" which is pretty much useless for anaylsis.

Which may be all but impossible but for the handful of
folks that know all the gory/intimate details of the
original bit of code.

> What does it potentially cause the caller to do?  Will it potentially
> treat an error as a success and as a result register an object
> illegally?
> 
> Real analysis please.  The text you provided above is basically still
> robotic and could be used to describe any error code return fix.

Right, it's useful to attempt but may be infeasible in
practice.




WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: peter.senna@gmail.com, shemminger@vyatta.com,
	mlindner@marvell.com, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Thu, 04 Oct 2012 17:09:55 -0700	[thread overview]
Message-ID: <1349395795.2008.26.camel@joe-AO722> (raw)
In-Reply-To: <20121004.145419.1859367129463136197.davem@davemloft.net>

On Thu, 2012-10-04 at 14:54 -0400, David Miller wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
> > On Thu, Oct 4, 2012 at 8:23 PM, David Miller <davem@davemloft.net> wrote:
> >> We want to know the implications of the bug being fixed.
> >> Does it potentially cause an OOPS?  Bad reference counting and thus
> >> potential leaks or early frees?
> >>
> >> You have to analyze the implications and ramifications of the bug
> >> being fixed.  We need that information.

You are asking for deeper level analysis that may not
be reasonably possible from the robotic patch fixed
by a robotic piece of a bit of code correction via a
static analysis.

> >> It's just "bad error code, this is the script that fixed it, kthx,
> >> bye" which is pretty much useless for anaylsis.

Which may be all but impossible but for the handful of
folks that know all the gory/intimate details of the
original bit of code.

> What does it potentially cause the caller to do?  Will it potentially
> treat an error as a success and as a result register an object
> illegally?
> 
> Real analysis please.  The text you provided above is basically still
> robotic and could be used to describe any error code return fix.

Right, it's useful to attempt but may be infeasible in
practice.




  reply	other threads:[~2012-10-05  0:09 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 16:18 [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code Peter Senna Tschudin
2012-10-03 16:18 ` Peter Senna Tschudin
2012-10-03 16:25 ` Stephen Hemminger
2012-10-03 16:25   ` Stephen Hemminger
2012-10-03 18:48   ` David Miller
2012-10-03 18:48     ` David Miller
2012-10-04  9:05   ` Peter Senna Tschudin
2012-10-04  9:05     ` Peter Senna Tschudin
2012-10-04 14:44     ` Stephen Hemminger
2012-10-04 14:44       ` Stephen Hemminger
2012-10-04 17:32       ` Peter Senna Tschudin
2012-10-04 17:32         ` Peter Senna Tschudin
2012-10-04 17:40         ` Stephen Hemminger
2012-10-04 17:40           ` Stephen Hemminger
2012-10-04 18:13           ` Peter Senna Tschudin
2012-10-04 18:13             ` Peter Senna Tschudin
2012-10-04 18:23         ` David Miller
2012-10-04 18:23           ` David Miller
2012-10-04 18:49           ` Peter Senna Tschudin
2012-10-04 18:49             ` Peter Senna Tschudin
2012-10-04 18:54             ` David Miller
2012-10-04 18:54               ` David Miller
2012-10-05  0:09               ` Joe Perches [this message]
2012-10-05  0:09                 ` Joe Perches
2012-10-05  5:22                 ` Julia Lawall
2012-10-05  5:22                   ` Julia Lawall
2012-10-05  7:36                   ` Joe Perches
2012-10-05  7:36                     ` Joe Perches
2012-10-05  8:02                     ` Dan Carpenter
2012-10-05  8:02                       ` Dan Carpenter
2012-10-05  8:08                     ` Julia Lawall
2012-10-05  8:08                       ` Julia Lawall
2012-10-10 17:08                       ` Peter Senna Tschudin
2012-10-10 17:08                         ` Peter Senna Tschudin
2012-10-10 17:40                         ` Ezequiel Garcia
2012-10-10 17:40                           ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349395795.2008.26.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlindner@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.