All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	David Miller <davem@davemloft.net>,
	peter.senna@gmail.com, shemminger@vyatta.com,
	mlindner@marvell.com, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Fri, 05 Oct 2012 08:02:03 +0000	[thread overview]
Message-ID: <20121005080203.GX4587@mwanda> (raw)
In-Reply-To: <1349422595.2008.55.camel@joe-AO722>

On Fri, Oct 05, 2012 at 12:36:35AM -0700, Joe Perches wrote:
> On Fri, 2012-10-05 at 07:22 +0200, Julia Lawall wrote:
> > A tool was used to find a potential problem, and then Peter
> > studied the code to see what fix was appropriate.
> 
> Hi Julia.
> 
> Was it true that a static analysis tool found the original
> potential issue?  If so, what tool was it?
> 
> But wasn't the scripted fix applied to the rest of the tree
> robotically?

It was coccinelle.  It just prints a warning.  You have to go in
manually, review the code and pick the correct error code.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	David Miller <davem@davemloft.net>,
	peter.senna@gmail.com, shemminger@vyatta.com,
	mlindner@marvell.com, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Fri, 5 Oct 2012 11:02:03 +0300	[thread overview]
Message-ID: <20121005080203.GX4587@mwanda> (raw)
In-Reply-To: <1349422595.2008.55.camel@joe-AO722>

On Fri, Oct 05, 2012 at 12:36:35AM -0700, Joe Perches wrote:
> On Fri, 2012-10-05 at 07:22 +0200, Julia Lawall wrote:
> > A tool was used to find a potential problem, and then Peter
> > studied the code to see what fix was appropriate.
> 
> Hi Julia.
> 
> Was it true that a static analysis tool found the original
> potential issue?  If so, what tool was it?
> 
> But wasn't the scripted fix applied to the rest of the tree
> robotically?

It was coccinelle.  It just prints a warning.  You have to go in
manually, review the code and pick the correct error code.

regards,
dan carpenter


  reply	other threads:[~2012-10-05  8:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 16:18 [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code Peter Senna Tschudin
2012-10-03 16:18 ` Peter Senna Tschudin
2012-10-03 16:25 ` Stephen Hemminger
2012-10-03 16:25   ` Stephen Hemminger
2012-10-03 18:48   ` David Miller
2012-10-03 18:48     ` David Miller
2012-10-04  9:05   ` Peter Senna Tschudin
2012-10-04  9:05     ` Peter Senna Tschudin
2012-10-04 14:44     ` Stephen Hemminger
2012-10-04 14:44       ` Stephen Hemminger
2012-10-04 17:32       ` Peter Senna Tschudin
2012-10-04 17:32         ` Peter Senna Tschudin
2012-10-04 17:40         ` Stephen Hemminger
2012-10-04 17:40           ` Stephen Hemminger
2012-10-04 18:13           ` Peter Senna Tschudin
2012-10-04 18:13             ` Peter Senna Tschudin
2012-10-04 18:23         ` David Miller
2012-10-04 18:23           ` David Miller
2012-10-04 18:49           ` Peter Senna Tschudin
2012-10-04 18:49             ` Peter Senna Tschudin
2012-10-04 18:54             ` David Miller
2012-10-04 18:54               ` David Miller
2012-10-05  0:09               ` Joe Perches
2012-10-05  0:09                 ` Joe Perches
2012-10-05  5:22                 ` Julia Lawall
2012-10-05  5:22                   ` Julia Lawall
2012-10-05  7:36                   ` Joe Perches
2012-10-05  7:36                     ` Joe Perches
2012-10-05  8:02                     ` Dan Carpenter [this message]
2012-10-05  8:02                       ` Dan Carpenter
2012-10-05  8:08                     ` Julia Lawall
2012-10-05  8:08                       ` Julia Lawall
2012-10-10 17:08                       ` Peter Senna Tschudin
2012-10-10 17:08                         ` Peter Senna Tschudin
2012-10-10 17:40                         ` Ezequiel Garcia
2012-10-10 17:40                           ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121005080203.GX4587@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlindner@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.