From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Push selects for TWD/SCU into machine entries
Date: Mon, 08 Oct 2012 13:15:56 +0100 [thread overview]
Message-ID: <1349698556.4322.18.camel@hornet> (raw)
In-Reply-To: <1349340644-13937-1-git-send-email-sboyd@codeaurora.org>
On Thu, 2012-10-04 at 09:50 +0100, Stephen Boyd wrote:
> The TWD and SCU configs are selected by default as long as
> SCORPIONMP is false and/or MCT is false. Implementing the logic
> this way certainly saves lines in the Kconfig but it precludes
> those machines which select SCORPIONMP or MCT from participating
> in the single zImage effort because when those machines are
> combined with other SMP capable machines the TWD and SCU are no
> longer selected.
>
> Push the select out to the machine entries so that we can compile
> these machines together and still select the appropriate configs.
[...]
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index c952960..4f8e0db 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -11,6 +11,8 @@ config ARCH_VEXPRESS
> select HAVE_CLK
> select HAVE_PATA_PLATFORM
> select HAVE_SMP
> + select HAVE_ARM_SCU if SMP
> + select HAVE_ARM_TWD if LOCAL_TIMERS
> select ICST
> select MIGHT_HAVE_CACHE_L2X0
> select NO_IOPORT
If you move these two lines before HAVE_CLK so everything stays in
alphabetical order ;-) you can add my Acked-by for vexpress:
Acked-by: Pawel Moll <pawel.moll@arm.com>
Thanks!
Pawel
WARNING: multiple messages have this Message-ID (diff)
From: Pawel Moll <pawel.moll@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Brown <davidb@codeaurora.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Russell King <linux@arm.linux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Shiraz Hashim <shiraz.hashim@st.com>,
Simon Horman <horms@verge.net.au>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Tony Lindgren <tony@atomide.com>,
Viresh Kumar <viresh.linux@gmail.com>
Subject: Re: [PATCH] ARM: Push selects for TWD/SCU into machine entries
Date: Mon, 08 Oct 2012 13:15:56 +0100 [thread overview]
Message-ID: <1349698556.4322.18.camel@hornet> (raw)
In-Reply-To: <1349340644-13937-1-git-send-email-sboyd@codeaurora.org>
On Thu, 2012-10-04 at 09:50 +0100, Stephen Boyd wrote:
> The TWD and SCU configs are selected by default as long as
> SCORPIONMP is false and/or MCT is false. Implementing the logic
> this way certainly saves lines in the Kconfig but it precludes
> those machines which select SCORPIONMP or MCT from participating
> in the single zImage effort because when those machines are
> combined with other SMP capable machines the TWD and SCU are no
> longer selected.
>
> Push the select out to the machine entries so that we can compile
> these machines together and still select the appropriate configs.
[...]
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index c952960..4f8e0db 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -11,6 +11,8 @@ config ARCH_VEXPRESS
> select HAVE_CLK
> select HAVE_PATA_PLATFORM
> select HAVE_SMP
> + select HAVE_ARM_SCU if SMP
> + select HAVE_ARM_TWD if LOCAL_TIMERS
> select ICST
> select MIGHT_HAVE_CACHE_L2X0
> select NO_IOPORT
If you move these two lines before HAVE_CLK so everything stays in
alphabetical order ;-) you can add my Acked-by for vexpress:
Acked-by: Pawel Moll <pawel.moll@arm.com>
Thanks!
Pawel
next prev parent reply other threads:[~2012-10-08 12:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 8:50 [PATCH] ARM: Push selects for TWD/SCU into machine entries Stephen Boyd
2012-10-04 8:50 ` Stephen Boyd
2012-10-04 8:52 ` viresh kumar
2012-10-04 8:52 ` viresh kumar
2012-10-04 9:11 ` Santosh Shilimkar
2012-10-04 9:11 ` Santosh Shilimkar
2012-10-04 19:01 ` Stephen Boyd
2012-10-04 19:01 ` Stephen Boyd
2012-10-05 1:12 ` Simon Horman
2012-10-05 1:12 ` Simon Horman
2012-10-05 6:42 ` Santosh Shilimkar
2012-10-05 6:42 ` Santosh Shilimkar
2012-10-04 13:05 ` Rob Herring
2012-10-04 13:05 ` Rob Herring
2012-10-04 19:22 ` Stephen Boyd
2012-10-04 19:22 ` Stephen Boyd
2012-10-08 12:56 ` Rob Herring
2012-10-08 12:56 ` Rob Herring
2012-10-05 1:13 ` Simon Horman
2012-10-05 1:13 ` Simon Horman
2012-10-08 12:15 ` Pawel Moll [this message]
2012-10-08 12:15 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349698556.4322.18.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.