All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adil Mujeeb <mujeeb.adil@gmail.com>
To: pavel@ucw.cz
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, Adil Mujeeb <mujeeb.adil@gmail.com>
Subject: [PATCH 9/9] Staging: winbond: wb35tx_s: Fixed coding style issues
Date: Fri, 12 Oct 2012 22:07:15 +0530	[thread overview]
Message-ID: <1350059835-5408-10-git-send-email-mujeeb.adil@gmail.com> (raw)
In-Reply-To: <1350059835-5408-1-git-send-email-mujeeb.adil@gmail.com>

Fixed most of the checkpatch.pl reported ERRORs and WARNINGs.
Some "line over 80 characters" warning left.

Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com>
---
 linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h |   49 +++++++++------------
 1 files changed, 21 insertions(+), 28 deletions(-)

diff --git a/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h b/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h
index f70f433..02a1f27 100644
--- a/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h
+++ b/linux-3.6-rc7/drivers/staging/winbond/wb35tx_s.h
@@ -3,45 +3,38 @@
 
 #include "mds_s.h"
 
-//====================================
-// IS89C35 Tx related definition
-//====================================
-#define TX_INTERFACE			0	// Interface 1
-#define TX_PIPE					3	// endpoint 4
-#define TX_INTERRUPT			1	// endpoint 2
-#define MAX_INTERRUPT_LENGTH	64	// It must be 64 for EP2 hardware
-
-
-
-//====================================
-// Internal variable for module
-//====================================
+/* IS89C35 Tx related definition */
+#define TX_INTERFACE		0	/* Interface 1 */
+#define TX_PIPE			3	/* endpoint 4 */
+#define TX_INTERRUPT		1	/* endpoint 2 */
+#define MAX_INTERRUPT_LENGTH	64	/* It must be 64 for EP2 hardware */
 
+/* Internal variable for module */
 
 struct wb35_tx {
-	// For Tx buffer
-	u8	TxBuffer[ MAX_USB_TX_BUFFER_NUMBER ][ MAX_USB_TX_BUFFER ];
+	/* For Tx buffer */
+	u8		TxBuffer[MAX_USB_TX_BUFFER_NUMBER][MAX_USB_TX_BUFFER];
 
-	// For Interrupt pipe
-	u8	EP2_buf[MAX_INTERRUPT_LENGTH];
+	/* For Interrupt pipe */
+	u8		EP2_buf[MAX_INTERRUPT_LENGTH];
 
-	atomic_t	TxResultCount;// For thread control of EP2 931130.4.m
-	atomic_t	TxFireCounter;// For thread control of EP4 931130.4.n
-	u32			ByteTransfer;
+	atomic_t	TxResultCount; /* For thread control of EP2 931130.4.m */
+	atomic_t	TxFireCounter; /* For thread control of EP4 931130.4.n */
+	u32		ByteTransfer;
 
-	u32	    TxSendIndex;// The next index of Mds array to be sent
-	u32	    EP2vm_state; // for EP2vm state
-	u32	    EP4vm_state; // for EP4vm state
-	u32	    tx_halt; // Stopping VM
+	u32		TxSendIndex; /* next index of Mds array to be sent */
+	u32		EP2vm_state; /* for EP2vm state */
+	u32		EP4vm_state; /* for EP4vm state */
+	u32		tx_halt; /* Stopping VM */
 
-	struct urb *				Tx4Urb;
-	struct urb *				Tx2Urb;
+	struct urb	*Tx4Urb;
+	struct urb	*Tx2Urb;
 
 	int		EP2VM_status;
 	int		EP4VM_status;
 
-	u32	TxFillCount; // 20060928
-	u32	TxTimer; // 20060928 Add if sending packet not great than 13
+	u32		TxFillCount; /* 20060928 */
+	u32		TxTimer; /* 20060928 Add if sending packet not great than 13 */
 };
 
 #endif
-- 
1.7.7.3


  parent reply	other threads:[~2012-10-12 16:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 16:37 [PATCH 0/9] Staging: winbond: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 1/9] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 2/9] Staging: winbond: phy_calibration: " Adil Mujeeb
2012-10-12 16:53   ` Joe Perches
2012-10-21 10:38     ` Pavel Machek
2012-10-12 16:37 ` [PATCH 3/9] Staging: winbond: mds: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 4/9] Staging: winbond: sem_api: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 5/9] Staging: winbond: wb35reg: Fixed coding style issues Adil Mujeeb
2012-10-21 10:39   ` Pavel Machek
2012-10-12 16:37 ` [PATCH 6/9] Staging: winbond: wb35rx_f: " Adil Mujeeb
2012-10-12 16:37 ` [PATCH 7/9] Staging: winbond: wb35rx_s: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 8/9] taging: winbond: wb35tx: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` Adil Mujeeb [this message]
2012-10-21 10:42 ` [PATCH 0/9] Staging: winbond: " Pavel Machek
2012-10-21 11:22   ` Adil Mujeeb
2012-10-22 20:34 ` Greg KH
2012-10-23 10:11   ` Adil Mujeeb
2012-10-23 18:45     ` Greg KH
2012-11-07 18:52       ` Adil Mujeeb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350059835-5408-10-git-send-email-mujeeb.adil@gmail.com \
    --to=mujeeb.adil@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.