From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: Adil Mujeeb <mujeeb.adil@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] Staging: winbond: phy_calibration: Fixed coding style issue
Date: Sun, 21 Oct 2012 12:38:38 +0200 [thread overview]
Message-ID: <20121021103838.GC14031@elf.ucw.cz> (raw)
In-Reply-To: <1350060799.2243.31.camel@joe-AO722>
On Fri 2012-10-12 09:53:19, Joe Perches wrote:
> On Fri, 2012-10-12 at 22:07 +0530, Adil Mujeeb wrote:
> > Removed checkpatch.pl script reported ERRORs
> []
> > diff --git a/linux-3.6-rc7/drivers/staging/winbond/phy_calibration.c b/linux-3.6-rc7/drivers/staging/winbond/phy_calibration.c
> []
> > -#define AG_CONST 0.6072529350
> > +#define AG_CONST (0.6072529350)
>
> That one is unnecessary.
> checkpatch is defective here.
Agreed.
> I wonder why there is any floating point
> in the code at all though.
Some kind of signal strength computations. I'm not an wifi expert... :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2012-10-21 10:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 16:37 [PATCH 0/9] Staging: winbond: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 1/9] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 2/9] Staging: winbond: phy_calibration: " Adil Mujeeb
2012-10-12 16:53 ` Joe Perches
2012-10-21 10:38 ` Pavel Machek [this message]
2012-10-12 16:37 ` [PATCH 3/9] Staging: winbond: mds: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 4/9] Staging: winbond: sem_api: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 5/9] Staging: winbond: wb35reg: Fixed coding style issues Adil Mujeeb
2012-10-21 10:39 ` Pavel Machek
2012-10-12 16:37 ` [PATCH 6/9] Staging: winbond: wb35rx_f: " Adil Mujeeb
2012-10-12 16:37 ` [PATCH 7/9] Staging: winbond: wb35rx_s: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 8/9] taging: winbond: wb35tx: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 9/9] Staging: winbond: wb35tx_s: " Adil Mujeeb
2012-10-21 10:42 ` [PATCH 0/9] Staging: winbond: " Pavel Machek
2012-10-21 11:22 ` Adil Mujeeb
2012-10-22 20:34 ` Greg KH
2012-10-23 10:11 ` Adil Mujeeb
2012-10-23 18:45 ` Greg KH
2012-11-07 18:52 ` Adil Mujeeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121021103838.GC14031@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.