From: Pavel Machek <pavel@ucw.cz>
To: Adil Mujeeb <mujeeb.adil@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] Staging: winbond: Fixed coding style issues
Date: Sun, 21 Oct 2012 12:42:17 +0200 [thread overview]
Message-ID: <20121021104217.GE14031@elf.ucw.cz> (raw)
In-Reply-To: <1350059835-5408-1-git-send-email-mujeeb.adil@gmail.com>
On Fri 2012-10-12 22:07:06, Adil Mujeeb wrote:
>
> winbond directory files have lots of coding style issues. The patch
set tries to remove *most* (if not all) of the coding style
issues. checkpatch.pl script is still complaining (like 80 characters
limit) but major part of the serious coding style issues have been
rectified.
ACK on patches except 2 and 5. Plus if you could keep the printks,
that would be great. When the driver is debugged and in wide use, we
can remove them, but now they are useful...
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2012-10-21 10:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 16:37 [PATCH 0/9] Staging: winbond: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 1/9] Staging: winbond: wbusb: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 2/9] Staging: winbond: phy_calibration: " Adil Mujeeb
2012-10-12 16:53 ` Joe Perches
2012-10-21 10:38 ` Pavel Machek
2012-10-12 16:37 ` [PATCH 3/9] Staging: winbond: mds: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 4/9] Staging: winbond: sem_api: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 5/9] Staging: winbond: wb35reg: Fixed coding style issues Adil Mujeeb
2012-10-21 10:39 ` Pavel Machek
2012-10-12 16:37 ` [PATCH 6/9] Staging: winbond: wb35rx_f: " Adil Mujeeb
2012-10-12 16:37 ` [PATCH 7/9] Staging: winbond: wb35rx_s: Fixed coding style issue Adil Mujeeb
2012-10-12 16:37 ` [PATCH 8/9] taging: winbond: wb35tx: Fixed coding style issues Adil Mujeeb
2012-10-12 16:37 ` [PATCH 9/9] Staging: winbond: wb35tx_s: " Adil Mujeeb
2012-10-21 10:42 ` Pavel Machek [this message]
2012-10-21 11:22 ` [PATCH 0/9] Staging: winbond: " Adil Mujeeb
2012-10-22 20:34 ` Greg KH
2012-10-23 10:11 ` Adil Mujeeb
2012-10-23 18:45 ` Greg KH
2012-11-07 18:52 ` Adil Mujeeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121021104217.GE14031@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.